From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10D71ECE564 for ; Wed, 19 Sep 2018 13:59:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CA3052151B for ; Wed, 19 Sep 2018 13:59:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA3052151B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732226AbeISTh5 (ORCPT ); Wed, 19 Sep 2018 15:37:57 -0400 Received: from mga02.intel.com ([134.134.136.20]:37348 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727657AbeISTh4 (ORCPT ); Wed, 19 Sep 2018 15:37:56 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Sep 2018 06:59:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,394,1531810800"; d="scan'208";a="75601162" Received: from pqueiros-mobl.ger.corp.intel.com (HELO localhost) ([10.249.37.13]) by orsmga006.jf.intel.com with ESMTP; 19 Sep 2018 06:59:49 -0700 Date: Wed, 19 Sep 2018 16:59:48 +0300 From: Jarkko Sakkinen To: Tomas Winkler Cc: Jason Gunthorpe , Alexander Usyskin , Tadeusz Struk , linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 02/20] tpm: sort objects in the Makefile Message-ID: <20180919135948.GE26571@linux.intel.com> References: <20180918093459.19165-1-tomas.winkler@intel.com> <20180918093459.19165-3-tomas.winkler@intel.com> <20180919134853.GB26571@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180919134853.GB26571@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 19, 2018 at 04:48:53PM +0300, Jarkko Sakkinen wrote: > On Tue, Sep 18, 2018 at 12:34:41PM +0300, Tomas Winkler wrote: > > Make the tpm Makefile a bit more in order by putting > > objects in one column and group together tpm2 modules > > The change is fine but do you mean by the subordinate clause here? > > /Jarkko > > > > > Signed-off-by: Tomas Winkler > > --- > > V2: 1. back to tpm-y notation > > 2. Partially sort files alphanumerically. > > V3: Rebase > > > > drivers/char/tpm/Makefile | 15 ++++++++++++--- > > 1 file changed, 12 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/char/tpm/Makefile b/drivers/char/tpm/Makefile > > index 4e9c33ca1f8f..efc785053627 100644 > > --- a/drivers/char/tpm/Makefile > > +++ b/drivers/char/tpm/Makefile > > @@ -3,9 +3,18 @@ > > # Makefile for the kernel tpm device drivers. > > # > > obj-$(CONFIG_TCG_TPM) += tpm.o > > -tpm-y := tpm-interface.o tpm-dev.o tpm-sysfs.o tpm-chip.o tpm2-cmd.o \ > > - tpm-dev-common.o tpmrm-dev.o eventlog/common.o eventlog/tpm1.o \ > > - eventlog/tpm2.o tpm2-space.o > > +tpm-y := tpm-chip.o > > +tpm-y += tpm-dev-common.o > > +tpm-y += tpm-dev.o > > +tpm-y += tpm-interface.o > > +tpm-y += tpm2-cmd.o > > +tpm-y += tpmrm-dev.o > > +tpm-y += tpm2-space.o > > +tpm-y += tpm-sysfs.o > > +tpm-y += eventlog/common.o > > +tpm-y += eventlog/tpm1.o > > +tpm-y += eventlog/tpm2.o > > + > > tpm-$(CONFIG_ACPI) += tpm_ppi.o eventlog/acpi.o > > tpm-$(CONFIG_EFI) += eventlog/efi.o > > tpm-$(CONFIG_OF) += eventlog/of.o > > -- > > 2.14.4 > > Forgot to add this: Tested-by: Jarkko Sakkinen /Jarkko