archive mirror
 help / color / mirror / Atom feed
From: Dominique Martinet <>
To: Greg Kroah-Hartman <>
Cc: Miguel Ojeda <>,
	linux-kernel <>,
	Rasmus Villemoes <>,
	Eli Friedman <>,
	Christopher Li <>,
	Kees Cook <>, Ingo Molnar <>,
	Geert Uytterhoeven <>,
	Masahiro Yamada <>,
	Joe Perches <>,
	Linus Torvalds <>,
Subject: Re: [PATCH v2 2/2] Compiler Attributes: naked can be shared
Date: Thu, 20 Sep 2018 09:36:50 +0200	[thread overview]
Message-ID: <20180920073650.GA6001@nautica> (raw)
In-Reply-To: <>

Greg Kroah-Hartman wrote on Thu, Sep 20, 2018:
> "Fixes:" is not just for stable, we use it wherever we have a patch that
> we know fixes a problem introduced in another patch.
> For this instance, I think we should just revert the offending patch,
> which should resolve the issue for everyone and then you can try to redo
> your series to get it right the next time.
> Sound good?

Except that 815f0ddb346c ("include/linux/compiler*.h: make compiler-*.h
mutually exclusive") itself fixes cafa0010cd51 ("Raise the minimum
required gcc version to 4.6"), which breaks clang altogether (as used by
example by bcc for most BPF programs, that I caught before -rc1 got
released so we got both in rc1)

I'm not aware of anything that would break if both were to be reverted,
I have no opinion on which way to go.

> Why not just route these through Andrew?  He takes lots of stuff like
> this for this very reason.

That works for me (although it might have helped if Andrew had been in
Cc at any point in this discussion...), but part of the discussion was
about seriously maintaining these files, and Miguel stepped up to help
with that so it could make sense to have his own tree.

Frankly, after this whole episode I'd find quite helpful if "compiler
stuff" (or headers maintainance in general) were to grow its own mailing
list and start being considered like a proper component of the kernel.

It does impact quite a few people, and it's neigh-impossible to review
this stuff as things are right now with a hand-picked list of CCs, no
matter how large it is -- I don't mind if it goes in -next through its
own branch or through Andrew, but a proper place where folks interested
in these could subscribe and test/review the patches would be awesome.

Dominique Martinet

  reply	other threads:[~2018-09-20  7:37 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-18 16:55 [PATCH v2 0/2] Compiler Attributes: (naked only, for v4.19) Miguel Ojeda
2018-09-18 16:55 ` [PATCH v2 1/2] Compiler Attributes: naked was fixed in gcc 4.6 Miguel Ojeda
2018-09-18 16:55 ` [PATCH v2 2/2] Compiler Attributes: naked can be shared Miguel Ojeda
2018-09-18 17:34   ` Greg Kroah-Hartman
2018-09-18 18:56     ` Miguel Ojeda
2018-09-19 21:14       ` Greg Kroah-Hartman
2018-09-19 23:00         ` Miguel Ojeda
2018-09-20  6:00           ` Stefan Agner
2018-09-20  7:19             ` Greg Kroah-Hartman
2018-09-20  7:20           ` Greg Kroah-Hartman
2018-09-19 23:05         ` Dominique Martinet
2018-09-19 23:56           ` Miguel Ojeda
2018-09-20  0:10             ` Dominique Martinet
2018-09-20  7:22               ` Greg Kroah-Hartman
2018-09-20  7:36                 ` Dominique Martinet [this message]
2018-09-20  7:49                   ` Geert Uytterhoeven
2018-09-20 16:11                   ` Miguel Ojeda
2018-09-20 12:18                 ` Miguel Ojeda
2018-09-20 13:57 ` [PATCH v2 0/2] Compiler Attributes: (naked only, for v4.19) Greg Kroah-Hartman
2018-09-20 13:59   ` Greg Kroah-Hartman
2018-09-20 16:13     ` Miguel Ojeda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180920073650.GA6001@nautica \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v2 2/2] Compiler Attributes: naked can be shared' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).