From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,URIBL_DBL_ABUSE_MALW,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7CB6ECE566 for ; Thu, 20 Sep 2018 16:33:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 631D621535 for ; Thu, 20 Sep 2018 16:33:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="Uq4zw7cv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 631D621535 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731404AbeITWSM (ORCPT ); Thu, 20 Sep 2018 18:18:12 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:41923 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727588AbeITWSM (ORCPT ); Thu, 20 Sep 2018 18:18:12 -0400 Received: by mail-pf1-f194.google.com with SMTP id h79-v6so4622820pfk.8 for ; Thu, 20 Sep 2018 09:33:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Ksx6AZoFTsa/ItgNP+XxdXWFtWVr0BxMGyKMhba/aws=; b=Uq4zw7cvWG0cAL6BAkqsSyAF0f50gMob5OzOd4qHwFhp/zlSXh566lYA9qkTvVhGPB /kzICHGF2I/eE0VAq/sYUZi+7rNbD8GNVanZV5anhQa06xgn7lib7Op93UEpjZmRGsxm yXPNGiPgbNz7uHI9Fy40Xi8BskuvuPx2U4+HU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Ksx6AZoFTsa/ItgNP+XxdXWFtWVr0BxMGyKMhba/aws=; b=qTFfYyksQ7GZxH/VFtv4/03Sth4m8qTAbBkOZi/XMsyXCtXl9ZLCfqH/QfJb+NsK8y 7cvGMz8auk2uX3wIkQmhjQIu/zZE73thzXfw+jhwusicveJs7Pv+ofMacZlLDPLb0YFT r6ZplHrBZvL0HaST4i01ZY2POoRTlZwjYwSvXFc1OOoUopt826X+V8ljYVPIuK/mFQws Ujl0tp1OJTnB3ictvBJUOHdlyKKUmGxer5kUq8GfEh3aWrPEQI8ZsBrn4jEnCI8WdBDS a2EqZxnQbS14IOzRSS3tMjYkzNEtpJm/CDa/tC8YKqn9Aeu5Y3OtQAkMq3rp6h9zmTex yS4w== X-Gm-Message-State: APzg51AF0y5dX3JpYnXXcyNfH3U15RGdky2ekxJROPX6+b861Xuv3eGp 5TVGbUnFAThutHzUZls8LbOXTg== X-Google-Smtp-Source: ANB0VdbK0NEWE3KB2aV9/EWmoPrTvY4MTWwK/htrRGYTM7aUJeTj/IZQ9VDUV48MAoC7uMHH230Hrg== X-Received: by 2002:a63:cc04:: with SMTP id x4-v6mr36862249pgf.33.1537461233218; Thu, 20 Sep 2018 09:33:53 -0700 (PDT) Received: from tuxbook-pro (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id 6-v6sm40494396pfs.58.2018.09.20.09.33.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 20 Sep 2018 09:33:52 -0700 (PDT) Date: Thu, 20 Sep 2018 09:38:02 -0700 From: Bjorn Andersson To: Bartosz Golaszewski Cc: Michael Turquette , Stephen Boyd , Greg Kroah-Hartman , "Rafael J . Wysocki" , Arend van Spriel , Ulf Hansson , Bjorn Helgaas , Vivek Gautam , Robin Murphy , Joe Perches , Heikki Krogerus , Andrew Morton , Mike Rapoport , Michal Hocko , Al Viro , Jonathan Corbet , Roman Gushchin , Huang Ying , Kees Cook , Arnd Bergmann , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 1/4] devres: constify p in devm_kfree() Message-ID: <20180920163802.GF1367@tuxbook-pro> References: <20180828093332.20674-1-brgl@bgdev.pl> <20180828093332.20674-2-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180828093332.20674-2-brgl@bgdev.pl> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 28 Aug 02:33 PDT 2018, Bartosz Golaszewski wrote: > Make devm_kfree() signature uniform with that of kfree(). To avoid > compiler warnings: cast p to (void *) when calling devres_destroy(). > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Bartosz Golaszewski > --- > drivers/base/devres.c | 5 +++-- > include/linux/device.h | 2 +- > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/base/devres.c b/drivers/base/devres.c > index f98a097e73f2..438c91a43508 100644 > --- a/drivers/base/devres.c > +++ b/drivers/base/devres.c > @@ -885,11 +885,12 @@ EXPORT_SYMBOL_GPL(devm_kasprintf); > * > * Free memory allocated with devm_kmalloc(). > */ > -void devm_kfree(struct device *dev, void *p) > +void devm_kfree(struct device *dev, const void *p) > { > int rc; > > - rc = devres_destroy(dev, devm_kmalloc_release, devm_kmalloc_match, p); > + rc = devres_destroy(dev, devm_kmalloc_release, > + devm_kmalloc_match, (void *)p); > WARN_ON(rc); > } > EXPORT_SYMBOL_GPL(devm_kfree); > diff --git a/include/linux/device.h b/include/linux/device.h > index 8f882549edee..33f7cb271fbb 100644 > --- a/include/linux/device.h > +++ b/include/linux/device.h > @@ -692,7 +692,7 @@ static inline void *devm_kcalloc(struct device *dev, > { > return devm_kmalloc_array(dev, n, size, flags | __GFP_ZERO); > } > -extern void devm_kfree(struct device *dev, void *p); > +extern void devm_kfree(struct device *dev, const void *p); > extern char *devm_kstrdup(struct device *dev, const char *s, gfp_t gfp) __malloc; > extern void *devm_kmemdup(struct device *dev, const void *src, size_t len, > gfp_t gfp); > -- > 2.18.0 >