From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Arend van Spriel <aspriel@gmail.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Vivek Gautam <vivek.gautam@codeaurora.org>,
Robin Murphy <robin.murphy@arm.com>,
Joe Perches <joe@perches.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
Michal Hocko <mhocko@suse.com>, Al Viro <viro@zeniv.linux.org.uk>,
Jonathan Corbet <corbet@lwn.net>, Roman Gushchin <guro@fb.com>,
Huang Ying <ying.huang@intel.com>,
Kees Cook <keescook@chromium.org>, Arnd Bergmann <arnd@arndb.de>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v2 4/4] clk: pmc-atom: use devm_kstrdup_const()
Date: Thu, 20 Sep 2018 09:39:28 -0700 [thread overview]
Message-ID: <20180920163928.GI1367@tuxbook-pro> (raw)
In-Reply-To: <20180828093332.20674-5-brgl@bgdev.pl>
On Tue 28 Aug 02:33 PDT 2018, Bartosz Golaszewski wrote:
> Use devm_kstrdup_const() in the pmc-atom driver. This mostly serves as
> an example of how to use this new routine to shrink driver code.
>
> While we're at it: replace a call to kcalloc() with devm_kcalloc().
>
> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> drivers/clk/x86/clk-pmc-atom.c | 19 ++++---------------
> 1 file changed, 4 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/clk/x86/clk-pmc-atom.c b/drivers/clk/x86/clk-pmc-atom.c
> index 08ef69945ffb..daa2192e6568 100644
> --- a/drivers/clk/x86/clk-pmc-atom.c
> +++ b/drivers/clk/x86/clk-pmc-atom.c
> @@ -253,14 +253,6 @@ static void plt_clk_unregister_fixed_rate_loop(struct clk_plt_data *data,
> plt_clk_unregister_fixed_rate(data->parents[i]);
> }
>
> -static void plt_clk_free_parent_names_loop(const char **parent_names,
> - unsigned int i)
> -{
> - while (i--)
> - kfree_const(parent_names[i]);
> - kfree(parent_names);
> -}
> -
> static void plt_clk_unregister_loop(struct clk_plt_data *data,
> unsigned int i)
> {
> @@ -286,8 +278,8 @@ static const char **plt_clk_register_parents(struct platform_device *pdev,
> if (!data->parents)
> return ERR_PTR(-ENOMEM);
>
> - parent_names = kcalloc(nparents, sizeof(*parent_names),
> - GFP_KERNEL);
> + parent_names = devm_kcalloc(&pdev->dev, nparents,
> + sizeof(*parent_names), GFP_KERNEL);
> if (!parent_names)
> return ERR_PTR(-ENOMEM);
>
> @@ -300,7 +292,8 @@ static const char **plt_clk_register_parents(struct platform_device *pdev,
> err = PTR_ERR(data->parents[i]);
> goto err_unreg;
> }
> - parent_names[i] = kstrdup_const(clks[i].name, GFP_KERNEL);
> + parent_names[i] = devm_kstrdup_const(&pdev->dev,
> + clks[i].name, GFP_KERNEL);
> }
>
> data->nparents = nparents;
> @@ -308,7 +301,6 @@ static const char **plt_clk_register_parents(struct platform_device *pdev,
>
> err_unreg:
> plt_clk_unregister_fixed_rate_loop(data, i);
> - plt_clk_free_parent_names_loop(parent_names, i);
> return ERR_PTR(err);
> }
>
> @@ -351,15 +343,12 @@ static int plt_clk_probe(struct platform_device *pdev)
> goto err_unreg_clk_plt;
> }
>
> - plt_clk_free_parent_names_loop(parent_names, data->nparents);
> -
> platform_set_drvdata(pdev, data);
> return 0;
>
> err_unreg_clk_plt:
> plt_clk_unregister_loop(data, i);
> plt_clk_unregister_parents(data);
> - plt_clk_free_parent_names_loop(parent_names, data->nparents);
> return err;
> }
>
> --
> 2.18.0
>
next prev parent reply other threads:[~2018-09-20 16:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-28 9:33 [PATCH v2 0/4] devres: provide and use devm_kstrdup_const() Bartosz Golaszewski
2018-08-28 9:33 ` [PATCH v2 1/4] devres: constify p in devm_kfree() Bartosz Golaszewski
2018-09-20 16:38 ` Bjorn Andersson
2018-08-28 9:33 ` [PATCH v2 2/4] mm: move is_kernel_rodata() to asm-generic/sections.h Bartosz Golaszewski
2018-09-20 16:38 ` Bjorn Andersson
2018-08-28 9:33 ` [PATCH v2 3/4] devres: provide devm_kstrdup_const() Bartosz Golaszewski
2018-09-20 16:39 ` Bjorn Andersson
2018-08-28 9:33 ` [PATCH v2 4/4] clk: pmc-atom: use devm_kstrdup_const() Bartosz Golaszewski
2018-08-30 21:53 ` Stephen Boyd
2018-09-20 16:39 ` Bjorn Andersson [this message]
2018-09-20 12:59 ` [PATCH v2 0/4] devres: provide and " Bartosz Golaszewski
2018-10-12 17:48 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180920163928.GI1367@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=aspriel@gmail.com \
--cc=bhelgaas@google.com \
--cc=brgl@bgdev.pl \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=guro@fb.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mturquette@baylibre.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robin.murphy@arm.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=sboyd@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=viro@zeniv.linux.org.uk \
--cc=vivek.gautam@codeaurora.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).