[PATCH] f2fs: fix to recover inode's uid/gid during POR

[PATCH] f2fs: fix to recover inode's uid/gid during POR

[Chao Yu]

Step to reproduce this bug:
1. logon as root
2. mount -t f2fs /dev/sdd /mnt;
3. touch /mnt/file;
4. chown system /mnt/file; chgrp system /mnt/file;
5. xfs_io -f /mnt/file -c "fsync";
6. godown /mnt;
7. umount /mnt;
8. mount -t f2fs /dev/sdd /mnt;

After step 8) we will expect file's uid/gid are all system, but during
recovery, these two fields were not been recovered, fix it.

Signed-off-by: Chao Yu <yuchao0@huawei.com>
---
 fs/f2fs/recovery.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c
index ba678efe7cad..da9f59b9044e 100644
--- a/fs/f2fs/recovery.c
+++ b/fs/f2fs/recovery.c
@@ -209,6 +209,8 @@ static void recover_inode(struct inode *inode, struct page *page)
 	char *name;
 
 	inode->i_mode = le16_to_cpu(raw->i_mode);
+	i_uid_write(inode, le32_to_cpu(raw->i_uid));
+	i_gid_write(inode, le32_to_cpu(raw->i_gid));
 	f2fs_i_size_write(inode, le64_to_cpu(raw->i_size));
 	inode->i_atime.tv_sec = le64_to_cpu(raw->i_atime);
 	inode->i_ctime.tv_sec = le64_to_cpu(raw->i_ctime);
-- 
2.18.0.rc1

Re: [PATCH] f2fs: fix to recover inode's uid/gid during POR

[Jaegeuk Kim]

On 09/20, Chao Yu wrote:
> Step to reproduce this bug:
> 1. logon as root
> 2. mount -t f2fs /dev/sdd /mnt;
> 3. touch /mnt/file;
> 4. chown system /mnt/file; chgrp system /mnt/file;
> 5. xfs_io -f /mnt/file -c "fsync";
> 6. godown /mnt;
> 7. umount /mnt;
> 8. mount -t f2fs /dev/sdd /mnt;
> 
> After step 8) we will expect file's uid/gid are all system, but during
> recovery, these two fields were not been recovered, fix it.

Hmm, I tried this before, but wasn't enough to fix everything. :(

> 
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
>  fs/f2fs/recovery.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c
> index ba678efe7cad..da9f59b9044e 100644
> --- a/fs/f2fs/recovery.c
> +++ b/fs/f2fs/recovery.c
> @@ -209,6 +209,8 @@ static void recover_inode(struct inode *inode, struct page *page)
>  	char *name;
>  
>  	inode->i_mode = le16_to_cpu(raw->i_mode);
> +	i_uid_write(inode, le32_to_cpu(raw->i_uid));
> +	i_gid_write(inode, le32_to_cpu(raw->i_gid));
>  	f2fs_i_size_write(inode, le64_to_cpu(raw->i_size));
>  	inode->i_atime.tv_sec = le64_to_cpu(raw->i_atime);
>  	inode->i_ctime.tv_sec = le64_to_cpu(raw->i_ctime);
> -- 
> 2.18.0.rc1

Re: [PATCH] f2fs: fix to recover inode's uid/gid during POR

[Christoph Hellwig]

On Thu, Sep 20, 2018 at 05:41:30PM +0800, Chao Yu wrote:
> Step to reproduce this bug:
> 1. logon as root
> 2. mount -t f2fs /dev/sdd /mnt;
> 3. touch /mnt/file;
> 4. chown system /mnt/file; chgrp system /mnt/file;
> 5. xfs_io -f /mnt/file -c "fsync";
> 6. godown /mnt;
> 7. umount /mnt;
> 8. mount -t f2fs /dev/sdd /mnt;

Please wire this up for xfstests (as a generic test).

Re: [PATCH] f2fs: fix to recover inode's uid/gid during POR

[Chao Yu]

Hi Christoph,

On 2018/9/21 14:06, Christoph Hellwig wrote:
> On Thu, Sep 20, 2018 at 05:41:30PM +0800, Chao Yu wrote:
>> Step to reproduce this bug:
>> 1. logon as root
>> 2. mount -t f2fs /dev/sdd /mnt;
>> 3. touch /mnt/file;
>> 4. chown system /mnt/file; chgrp system /mnt/file;
>> 5. xfs_io -f /mnt/file -c "fsync";
>> 6. godown /mnt;
>> 7. umount /mnt;
>> 8. mount -t f2fs /dev/sdd /mnt;
> 
> Please wire this up for xfstests (as a generic test).

No problem, I just plan to.

Out of curiosity, are you filter some key words like 'recover' in your
email client to find this so quickly?

Thanks,

> 
> 

Re: [PATCH] f2fs: fix to recover inode's uid/gid during POR

[Christoph Hellwig]

On Fri, Sep 21, 2018 at 02:20:49PM +0800, Chao Yu wrote:
> No problem, I just plan to.
> 
> Out of curiosity, are you filter some key words like 'recover' in your
> email client to find this so quickly?

No, I just do a quick glanceof lkml every morning, and this just caught
my eye.