From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71E4EC433F4 for ; Sat, 22 Sep 2018 08:13:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 12C5421523 for ; Sat, 22 Sep 2018 08:13:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 12C5421523 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727473AbeIVOGK convert rfc822-to-8bit (ORCPT ); Sat, 22 Sep 2018 10:06:10 -0400 Received: from mail.bootlin.com ([62.4.15.54]:57465 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725874AbeIVOGK (ORCPT ); Sat, 22 Sep 2018 10:06:10 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 8E99320795; Sat, 22 Sep 2018 10:13:27 +0200 (CEST) Received: from bbrezillon (unknown [91.160.177.164]) by mail.bootlin.com (Postfix) with ESMTPSA id 2167220726; Sat, 22 Sep 2018 10:13:27 +0200 (CEST) Date: Sat, 22 Sep 2018 10:13:26 +0200 From: Boris Brezillon To: Miquel Raynal Cc: Naga Sureshkumar Relli , "richard@nod.at" , "dwmw2@infradead.org" , "computersforpeace@gmail.com" , "marek.vasut@gmail.com" , "kyungmin.park@samsung.com" , "absahu@codeaurora.org" , "peterpandong@micron.com" , "frieder.schrempf@exceet.de" , "linux-mtd@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Michal Simek , "nagasureshkumarrelli@gmail.com" Subject: Re: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller Message-ID: <20180922101326.6f139da2@bbrezillon> In-Reply-To: <20180922095340.4fe373f8@xps13> References: <1534511964-20342-1-git-send-email-naga.sureshkumar.relli@xilinx.com> <1534511964-20342-3-git-send-email-naga.sureshkumar.relli@xilinx.com> <20180820184013.57fd7b5c@bbrezillon> <20180922095340.4fe373f8@xps13> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 22 Sep 2018 09:53:40 +0200 Miquel Raynal wrote: > Hi Naga, > > Naga Sureshkumar Relli wrote on Tue, 11 Sep 2018 > 05:23:09 +0000: > > > Hi Boris, > > > > > -----Original Message----- > > > From: Boris Brezillon [mailto:boris.brezillon@bootlin.com] > > > Sent: Monday, August 20, 2018 10:10 PM > > > To: Naga Sureshkumar Relli > > > Cc: miquel.raynal@bootlin.com; richard@nod.at; dwmw2@infradead.org; > > > computersforpeace@gmail.com; marek.vasut@gmail.com; kyungmin.park@samsung.com; > > > absahu@codeaurora.org; peterpandong@micron.com; frieder.schrempf@exceet.de; linux- > > > mtd@lists.infradead.org; linux-kernel@vger.kernel.org; Michal Simek ; > > > nagasureshkumarrelli@gmail.com > > > Subject: Re: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for Arasan NAND > > > Flash Controller > > > > > > Hi Naga, > > > > > > On Fri, 17 Aug 2018 18:49:24 +0530 > > > Naga Sureshkumar Relli wrote: > > > > > > > > > I haven't finished reviewing the driver but there are still a bunch of things that look strange, for > > > instance, your ->read/write_page() implementation looks suspicious. Let's discuss that before > > > you send a new version. Sorry, I've been too busy to finish my review :-/. Please submit the new version as Miquel suggested. > > Could you please review the remaining stuff? > > I have the changes ready with me which will address all your comments given to this series. > > > > Thanks, > > Naga Sureshkumar Relli > > Please submit the new version that is ready, the rest of the review will > come. > > > Thanks, > Miquèl