* [f2fs-dev][PATCH] f2fs: fix remount problem of option io_bits
@ 2018-09-22 14:43 Chengguang Xu
2018-09-25 7:42 ` Chao Yu
0 siblings, 1 reply; 2+ messages in thread
From: Chengguang Xu @ 2018-09-22 14:43 UTC (permalink / raw)
To: jaegeuk, yuchao0; +Cc: linux-f2fs-devel, linux-kernel, Chengguang Xu
Currently we show mount option "io_bits=%u" as "io_size=%uKB",
it will cause option parsing problem(unrecognized mount option)
in remount.
Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
---
fs/f2fs/super.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 896b885f504e..8c96c4e9ee8d 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -1336,7 +1336,8 @@ static int f2fs_show_options(struct seq_file *seq, struct dentry *root)
from_kgid_munged(&init_user_ns,
F2FS_OPTION(sbi).s_resgid));
if (F2FS_IO_SIZE_BITS(sbi))
- seq_printf(seq, ",io_size=%uKB", F2FS_IO_SIZE_KB(sbi));
+ seq_printf(seq, ",io_bits=%u",
+ F2FS_OPTION(sbi).write_io_size_bits);
#ifdef CONFIG_F2FS_FAULT_INJECTION
if (test_opt(sbi, FAULT_INJECTION)) {
seq_printf(seq, ",fault_injection=%u",
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [f2fs-dev][PATCH] f2fs: fix remount problem of option io_bits
2018-09-22 14:43 [f2fs-dev][PATCH] f2fs: fix remount problem of option io_bits Chengguang Xu
@ 2018-09-25 7:42 ` Chao Yu
0 siblings, 0 replies; 2+ messages in thread
From: Chao Yu @ 2018-09-25 7:42 UTC (permalink / raw)
To: Chengguang Xu, jaegeuk; +Cc: linux-f2fs-devel, linux-kernel
On 2018/9/22 22:43, Chengguang Xu wrote:
> Currently we show mount option "io_bits=%u" as "io_size=%uKB",
> it will cause option parsing problem(unrecognized mount option)
> in remount.
>
> Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-25 7:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-22 14:43 [f2fs-dev][PATCH] f2fs: fix remount problem of option io_bits Chengguang Xu
2018-09-25 7:42 ` Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).