Hi Nathan, Thank you for the patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.19-rc4 next-20180921] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Nathan-Chancellor/media-cx18-Don-t-check-for-address-of-video_dev/20180922-192000 base: git://linuxtv.org/media_tree.git master config: xtensa-allmodconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 8.1.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=8.1.0 make.cross ARCH=xtensa All errors (new ones prefixed by >>): drivers/media//pci/cx18/cx18-driver.c: In function 'cx18_cancel_out_work_orders': >> drivers/media//pci/cx18/cx18-driver.c:1255:7: error: used struct type value where scalar is required if (cx->streams[i].video_dev) ^~ vim +1255 drivers/media//pci/cx18/cx18-driver.c 1250 1251 static void cx18_cancel_out_work_orders(struct cx18 *cx) 1252 { 1253 int i; 1254 for (i = 0; i < CX18_MAX_STREAMS; i++) > 1255 if (cx->streams[i].video_dev) 1256 cancel_work_sync(&cx->streams[i].out_work_order); 1257 } 1258 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation