From: kbuild test robot <lkp@intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: kbuild-all@01.org, Linux PM <linux-pm@vger.kernel.org>,
Linux ACPI <linux-acpi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>
Subject: Re: [PATCH] PM / suspend: Count suspend-to-idle loop as sleep time
Date: Sat, 22 Sep 2018 23:50:03 +0800 [thread overview]
Message-ID: <201809222359.VAo99gnA%fengguang.wu@intel.com> (raw)
In-Reply-To: <9611469.2z7W9akjOQ@aspire.rjw.lan>
[-- Attachment #1: Type: text/plain, Size: 2873 bytes --]
Hi Rafael,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v4.19-rc4 next-20180921]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Rafael-J-Wysocki/PM-suspend-Count-suspend-to-idle-loop-as-sleep-time/20180914-170606
config: i386-randconfig-a1-09200857 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
kernel/power/suspend.o: In function `s2idle_loop':
>> kernel/power/suspend.c:168: undefined reference to `timekeeping_inject_sleeptime64'
vim +168 kernel/power/suspend.c
109
110 static void s2idle_loop(void)
111 {
112 ktime_t start, delta;
113
114 pm_pr_dbg("suspend-to-idle\n");
115
116 start = ktime_get();
117
118 for (;;) {
119 int error;
120
121 dpm_noirq_begin();
122
123 /*
124 * Suspend-to-idle equals
125 * frozen processes + suspended devices + idle processors.
126 * Thus s2idle_enter() should be called right after
127 * all devices have been suspended.
128 *
129 * Wakeups during the noirq suspend of devices may be spurious,
130 * so prevent them from terminating the loop right away.
131 */
132 error = dpm_noirq_suspend_devices(PMSG_SUSPEND);
133 if (!error)
134 s2idle_enter();
135 else if (error == -EBUSY && pm_wakeup_pending())
136 error = 0;
137
138 if (!error && s2idle_ops && s2idle_ops->wake)
139 s2idle_ops->wake();
140
141 dpm_noirq_resume_devices(PMSG_RESUME);
142
143 dpm_noirq_end();
144
145 if (error)
146 break;
147
148 if (s2idle_ops && s2idle_ops->sync)
149 s2idle_ops->sync();
150
151 if (pm_wakeup_pending())
152 break;
153
154 pm_wakeup_clear(false);
155 }
156
157 /*
158 * If the monotonic clock difference between the start of the loop and
159 * this point is too large, user space may get confused about whether or
160 * not the system has been suspended and tasks may get killed by
161 * watchdogs etc., so count the loop as "sleep time" to compensate for
162 * that.
163 */
164 delta = ktime_sub(ktime_get(), start);
165 if (ktime_to_ns(delta) > 0) {
166 struct timespec64 timespec64_delta = ktime_to_timespec64(delta);
167
> 168 timekeeping_inject_sleeptime64(×pec64_delta);
169 }
170
171 pm_pr_dbg("resume from suspend-to-idle\n");
172 }
173
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 35247 bytes --]
prev parent reply other threads:[~2018-09-22 17:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 6:59 [PATCH] PM / suspend: Count suspend-to-idle loop as sleep time Rafael J. Wysocki
2018-09-14 7:40 ` Peter Zijlstra
2018-09-14 7:47 ` Rafael J. Wysocki
2018-09-14 8:04 ` Peter Zijlstra
2018-09-14 8:13 ` [PATCH v2] " Rafael J. Wysocki
2018-09-14 8:28 ` [PATCH] " Mika Penttilä
2018-09-14 8:46 ` Rafael J. Wysocki
2018-09-14 9:53 ` Mika Penttilä
2018-09-14 10:06 ` Rafael J. Wysocki
2018-09-14 12:41 ` Thomas Gleixner
2018-09-17 8:08 ` Rafael J. Wysocki
2018-09-22 15:50 ` kbuild test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201809222359.VAo99gnA%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@01.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).