From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Craig Tatlor <ctatlor97@gmail.com>
Cc: linux-arm-msm@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Sricharan R <sricharan@codeaurora.org>,
Stephen Boyd <sboyd@codeaurora.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-soc@vger.kernel.org
Subject: Re: [PATCH] firmware: qcom: scm: Add sdm660 soc compatible
Date: Mon, 24 Sep 2018 10:43:41 -0700 [thread overview]
Message-ID: <20180924174341.GN1367@tuxbook-pro> (raw)
In-Reply-To: <20180811162453.10930-1-ctatlor97@gmail.com>
On Sat 11 Aug 09:24 PDT 2018, Craig Tatlor wrote:
> Add the compatible for SDM660.
> This does not need clocks to do scm calls
>
> Signed-off-by: Craig Tatlor <ctatlor97@gmail.com>
Andy picked my clock-rework patch for the scm driver, so we can now do:
compatible = "qcom,scm-sdm660", "qcom,scm";
and get the desired result.
Please respin your patch without the code update.
Regards,
Bjorn
> ---
> Documentation/devicetree/bindings/firmware/qcom,scm.txt | 1 +
> drivers/firmware/qcom_scm.c | 3 +++
> 2 files changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.txt b/Documentation/devicetree/bindings/firmware/qcom,scm.txt
> index fcf6979c0b6d..499608fcc864 100644
> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.txt
> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.txt
> @@ -11,6 +11,7 @@ Required properties:
> * "qcom,scm-msm8660" for MSM8660 platforms
> * "qcom,scm-msm8690" for MSM8690 platforms
> * "qcom,scm-msm8996" for MSM8996 platforms
> + * "qcom,scm-sdm660" for SDM660 platforms
> * "qcom,scm-ipq4019" for IPQ4019 platforms
> * "qcom,scm" for later processors (MSM8916, APQ8084, MSM8974, etc)
> - clocks: One to three clocks may be required based on compatible.
> diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
> index e778af766fae..ee113ceb5d41 100644
> --- a/drivers/firmware/qcom_scm.c
> +++ b/drivers/firmware/qcom_scm.c
> @@ -603,6 +603,9 @@ static const struct of_device_id qcom_scm_dt_match[] = {
> { .compatible = "qcom,scm-msm8996",
> .data = NULL, /* no clocks */
> },
> + { .compatible = "qcom,scm-sdm660",
> + .data = NULL, /* no clocks */
> + },
> { .compatible = "qcom,scm-ipq4019",
> .data = NULL, /* no clocks */
> },
> --
> 2.18.0
>
prev parent reply other threads:[~2018-09-24 17:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-11 16:24 [PATCH] firmware: qcom: scm: Add sdm660 soc compatible Craig Tatlor
2018-08-14 20:57 ` Rob Herring
2018-08-15 20:31 ` Stephen Boyd
2018-09-24 17:43 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180924174341.GN1367@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=ctatlor97@gmail.com \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=sricharan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).