From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32555ECE560 for ; Mon, 24 Sep 2018 17:59:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EC60B2098A for ; Mon, 24 Sep 2018 17:59:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC60B2098A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730789AbeIYAC0 (ORCPT ); Mon, 24 Sep 2018 20:02:26 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:53774 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728468AbeIYAC0 (ORCPT ); Mon, 24 Sep 2018 20:02:26 -0400 Received: from localhost (ip-213-127-77-73.ip.prioritytelecom.net [213.127.77.73]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 5E2B9E8A; Mon, 24 Sep 2018 17:59:05 +0000 (UTC) Date: Mon, 24 Sep 2018 19:59:02 +0200 From: Greg Kroah-Hartman To: Joe Perches Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Bart Van Assche , Jason Gunthorpe , Sasha Levin Subject: Re: [PATCH 3.18 104/105] IB/nes: Fix a compiler warning Message-ID: <20180924175902.GB19402@kroah.com> References: <20180924113113.268650190@linuxfoundation.org> <20180924113123.002918395@linuxfoundation.org> <6f7ca3c205bada768c3918b1feacbbd5ce23a64d.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6f7ca3c205bada768c3918b1feacbbd5ce23a64d.camel@perches.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 24, 2018 at 09:38:26AM -0700, Joe Perches wrote: > On Mon, 2018-09-24 at 13:34 +0200, Greg Kroah-Hartman wrote: > > 3.18-stable review patch. If anyone has any objections, please let me know. > > Why should this sort of change be applied to a stable release? Originally I was just going to drop this as it's not fixing something. But it might be, if that macro is used in a if() statement, or something like that, it could be doing something unintended. So I don't feel like auditing all 500+ instances where this is used, it's easier to just accept the patch. thanks, greg k-h