From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Christophe Kerello <christophe.kerello@st.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>, <richard@nod.at>,
<dwmw2@infradead.org>, <computersforpeace@gmail.com>,
<marek.vasut@gmail.com>, <robh+dt@kernel.org>,
<mark.rutland@arm.com>, <linux-mtd@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>
Subject: Re: [PATCH 2/3] mtd: rawnand: stm32_fmc2: add STM32 FMC2 NAND flash controller driver
Date: Mon, 24 Sep 2018 19:26:32 +0200 [thread overview]
Message-ID: <20180924192632.1d5754da@bbrezillon> (raw)
In-Reply-To: <6df8455e-2fb2-e65c-a492-fba42a9453f3@st.com>
On Mon, 24 Sep 2018 18:36:36 +0200
Christophe Kerello <christophe.kerello@st.com> wrote:
> >> +static int stm32_fmc2_resume(struct device *dev)
> >> +{
> >> + struct stm32_fmc2 *fmc2 = dev_get_drvdata(dev);
> >> + int i, ret;
> >> +
> >> + pinctrl_pm_select_default_state(dev);
> >> +
> >> + ret = clk_prepare_enable(fmc2->clk);
> >> + if (ret) {
> >> + dev_err(dev, "can not enable the clock\n");
> >> + return ret;
> >> + }
> >> +
> >> + stm32_fmc2_init(fmc2);
> >> + stm32_fmc2_timings_init(fmc2);
> >> + stm32_fmc2_setup(fmc2);
> >> +
> >> + for (i = 0; i < fmc2->ncs; i++)
> >> + nand_reset(&fmc2->chip, i);
> >
> > This means you have one different NAND chip wired on each CS.
> >
> > We could have two CS wired to the same NAND chip. Calling nand_reset
> > twice would be harmless but a lost of time.
Actually, you have to call nand_reset() for each CS, otherwise not all
dies are reset.
next prev parent reply other threads:[~2018-09-24 17:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 15:47 [PATCH 0/3] mtd: rawnand: add STM32 FMC2 NAND flash controller driver christophe.kerello
2018-09-17 15:47 ` [PATCH 1/3] dt-bindings: mtd: stm32_fmc2: add STM32 FMC2 NAND controller documentation christophe.kerello
2018-09-22 8:34 ` Miquel Raynal
2018-09-24 16:36 ` Christophe Kerello
2018-09-24 17:17 ` Boris Brezillon
2018-09-25 9:14 ` Christophe Kerello
2018-09-17 15:47 ` [PATCH 2/3] mtd: rawnand: stm32_fmc2: add STM32 FMC2 NAND flash controller driver christophe.kerello
2018-09-17 17:05 ` kbuild test robot
2018-09-17 17:32 ` kbuild test robot
2018-09-22 13:48 ` Miquel Raynal
2018-09-24 16:36 ` Christophe Kerello
2018-09-24 17:26 ` Boris Brezillon [this message]
2018-10-29 9:22 ` Miquel Raynal
2018-09-23 11:34 ` Miquel Raynal
2018-09-24 16:36 ` Christophe Kerello
2018-09-24 17:23 ` Boris Brezillon
2018-09-25 9:14 ` Christophe Kerello
2018-09-17 15:47 ` [PATCH 3/3] mtd: rawnand: stm32_fmc2: add manual mode christophe.kerello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180924192632.1d5754da@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=christophe.kerello@st.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).