From: kbuild test robot <lkp@intel.com>
To: Song Liu <songliubraving@fb.com>
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com, Song Liu <songliubraving@fb.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Oleg Nesterov <oleg@redhat.com>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
"Naveen N . Rao" <naveen.n.rao@linux.vnet.ibm.com>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH RESEND] trace_uprobe: support reference counter in fd-based uprobe
Date: Tue, 25 Sep 2018 14:26:10 +0800 [thread overview]
Message-ID: <201809251403.5GBHgN7F%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180924211236.4149482-1-songliubraving@fb.com>
[-- Attachment #1: Type: text/plain, Size: 2522 bytes --]
Hi Song,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on tip/perf/core]
[also build test ERROR on v4.19-rc5 next-20180925]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Song-Liu/trace_uprobe-support-reference-counter-in-fd-based-uprobe/20180925-135454
config: i386-randconfig-x005-201838 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
kernel/trace/trace_uprobe.c: In function 'create_local_trace_uprobe':
>> kernel/trace/trace_uprobe.c:1376:4: error: 'struct trace_uprobe' has no member named 'ref_ctr_offset'
tu->ref_ctr_offset = ref_ctr_offset;
^~
vim +1376 kernel/trace/trace_uprobe.c
1340
1341 #ifdef CONFIG_PERF_EVENTS
1342 struct trace_event_call *
1343 create_local_trace_uprobe(char *name, unsigned long offs,
1344 unsigned long ref_ctr_offset, bool is_return)
1345 {
1346 struct trace_uprobe *tu;
1347 struct path path;
1348 int ret;
1349
1350 ret = kern_path(name, LOOKUP_FOLLOW, &path);
1351 if (ret)
1352 return ERR_PTR(ret);
1353
1354 if (!d_is_reg(path.dentry)) {
1355 path_put(&path);
1356 return ERR_PTR(-EINVAL);
1357 }
1358
1359 /*
1360 * local trace_kprobes are not added to probe_list, so they are never
1361 * searched in find_trace_kprobe(). Therefore, there is no concern of
1362 * duplicated name "DUMMY_EVENT" here.
1363 */
1364 tu = alloc_trace_uprobe(UPROBE_EVENT_SYSTEM, "DUMMY_EVENT", 0,
1365 is_return);
1366
1367 if (IS_ERR(tu)) {
1368 pr_info("Failed to allocate trace_uprobe.(%d)\n",
1369 (int)PTR_ERR(tu));
1370 path_put(&path);
1371 return ERR_CAST(tu);
1372 }
1373
1374 tu->offset = offs;
1375 tu->path = path;
> 1376 tu->ref_ctr_offset = ref_ctr_offset;
1377 tu->filename = kstrdup(name, GFP_KERNEL);
1378 init_trace_event_call(tu, &tu->tp.call);
1379
1380 if (set_print_fmt(&tu->tp, is_ret_probe(tu)) < 0) {
1381 ret = -ENOMEM;
1382 goto error;
1383 }
1384
1385 return &tu->tp.call;
1386 error:
1387 free_trace_uprobe(tu);
1388 return ERR_PTR(ret);
1389 }
1390
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 36102 bytes --]
next prev parent reply other threads:[~2018-09-25 6:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 21:12 [PATCH RESEND] trace_uprobe: support reference counter in fd-based uprobe Song Liu
2018-09-25 6:26 ` kbuild test robot [this message]
2018-09-25 14:46 ` Song Liu
2018-09-26 16:06 ` Steven Rostedt
2018-09-28 7:18 ` Peter Zijlstra
2018-09-28 7:23 ` Song Liu
2018-09-28 7:52 ` Peter Zijlstra
2018-09-28 14:50 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201809251403.5GBHgN7F%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@01.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=oleg@redhat.com \
--cc=rostedt@goodmis.org \
--cc=songliubraving@fb.com \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).