From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B620C43382 for ; Tue, 25 Sep 2018 13:06:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E63C62086B for ; Tue, 25 Sep 2018 13:06:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E63C62086B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729055AbeIYTNp (ORCPT ); Tue, 25 Sep 2018 15:13:45 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:12700 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727165AbeIYTNp (ORCPT ); Tue, 25 Sep 2018 15:13:45 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 497DF521CB4AA; Tue, 25 Sep 2018 21:05:48 +0800 (CST) Received: from localhost (10.202.226.46) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.399.0; Tue, 25 Sep 2018 21:05:42 +0800 Date: Tue, 25 Sep 2018 14:05:30 +0100 From: Jonathan Cameron To: Song Qiang CC: , , , , , , , , , , Subject: Re: [PATCH 1/2] iio: magnetometer: Add DT support for PNI RM3100 Message-ID: <20180925140530.00005fa3@huawei.com> In-Reply-To: <20180925031724.21399-1-songqiang1304521@gmail.com> References: <20180925031724.21399-1-songqiang1304521@gmail.com> Organization: Huawei X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.226.46] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Sep 2018 11:17:23 +0800 Song Qiang wrote: > PNI RM3100 is a high resolution, large signal immunity magnetometer, > composed of 3 single sensors and a processing chip with MagI2C Interface. > PNI is not in the vendors' list, so this patch is also adding it. > > Signed-off-by: Song Qiang Hi Song, Please clearly mark the title of the patch with V2. [PATCH 1/2 V2] ... (or I'm also happy with a cover letter that does the same though other maintainers ask for every patch to be marked v2). This makes it easy to quickly short the versions and check we are looking at the latest. > --- > Changes in v2: > - Remove bus specific part in compatible string. > > .../bindings/iio/magnetometer/pni,rm3100.txt | 20 +++++++++++++++++++ > .../devicetree/bindings/vendor-prefixes.txt | 1 + > 2 files changed, 21 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/magnetometer/pni,rm3100.txt > > diff --git a/Documentation/devicetree/bindings/iio/magnetometer/pni,rm3100.txt b/Documentation/devicetree/bindings/iio/magnetometer/pni,rm3100.txt > new file mode 100644 > index 000000000000..4677690fc5d0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/magnetometer/pni,rm3100.txt > @@ -0,0 +1,20 @@ > +* PNI RM3100 3-axis magnetometer sensor > + > +Required properties: > + > +- compatible : should be "pni,rm3100" > +- reg : the I2C address or SPI chip select number of the sensor. > + > +Optional properties: > + > +- interrupts: data ready (DRDY) from the chip. > + The interrupts can be triggered on rising edges. > + > +Example: > + > +rm3100: rm3100@20 { > + compatible = "pni,rm3100"; > + reg = <0x20>; > + interrupt-parent = <&gpio0>; > + interrupts = <4 IRQ_TYPE_EDGE_RISING>; > +}; > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt > index 41f0b97eb933..5bf3395fe9ae 100644 > --- a/Documentation/devicetree/bindings/vendor-prefixes.txt > +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt > @@ -288,6 +288,7 @@ pine64 Pine64 > pixcir PIXCIR MICROELECTRONICS Co., Ltd > plathome Plat'Home Co., Ltd. > plda PLDA > +pni PNI A quick scan around their website suggests they are actually "PNI Sensor Corporation" I'm not sure how fussy we are on naming in here but probable best to be as specific as possible. > portwell Portwell Inc. > poslab Poslab Technology Co., Ltd. > powervr PowerVR (deprecated, use img)