From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00DEFC43382 for ; Tue, 25 Sep 2018 18:54:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AAF0A2086B for ; Tue, 25 Sep 2018 18:54:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="hy5rG6Fa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AAF0A2086B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727675AbeIZBCz (ORCPT ); Tue, 25 Sep 2018 21:02:55 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:38735 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727325AbeIZBCy (ORCPT ); Tue, 25 Sep 2018 21:02:54 -0400 Received: by mail-pg1-f196.google.com with SMTP id r77-v6so7091780pgr.5 for ; Tue, 25 Sep 2018 11:53:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=59Ctqn6p9LkduqETHrhIZzTWaR9rJMivRNGJp75lx4w=; b=hy5rG6FaSLgDHPGHundPwvtpEZSkvcH40foeCjOutQUrAETCEePSkzzL+Jt+QZdrfm DzLcTsDtP+OfNCs1VWhoYwPT+88SAGi2JnLIpB4x6qfpLB8FMpdZlQqYlUpDzsSXB24N JjcJ0QkckYk8G1Wnz3NoxtXULgECcfVdHQfBg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=59Ctqn6p9LkduqETHrhIZzTWaR9rJMivRNGJp75lx4w=; b=Rzs6IokYThE/M+AgOYDUKS9F8TqkwwR2cdh1E9hqg7WFD06N7OThaV1TAl6RhXD8Aq I0JtHo3lKKWiw/oi0Tda6mFzIKMTPIKqv7bVV5Ydp8NzcxOAr6UCfbF4SooSC5aKPU35 9oVBUQU1tOAHn66tRPF+soOXDmgsVCrtsK6HlY/m2lh/kMXqbMKDCZcQ+d8CWdjFNhzZ 8RiueERZ1sH33VX4tkO1lZeOy91jnibEZ6ZfO23KtRC3tRmxBKAsPwVfxmxfcXBOsTeJ D2r/sLiPJ5AVgd0haonvZZQ3U+DbMpCKNVfJyX9xV4djaX40BMnUG3KBk1mT19ll6RTw XN3A== X-Gm-Message-State: ABuFfojdnoWbXVAIuTpJ9R+43UNXLuJ5XDF7JgL5B+BVxpz6WDE03jMi jFfzro32wg9mTgoyBnO76erv2Q== X-Google-Smtp-Source: ACcGV62E8YNgm+iIH+HReKKf01VwD5vVFG4DQ4RqyfR/qXYuBMrll+6qZ8HKgRexsqFiI37y/w5CIg== X-Received: by 2002:a63:a80c:: with SMTP id o12-v6mr2198405pgf.271.1537901638959; Tue, 25 Sep 2018 11:53:58 -0700 (PDT) Received: from mka.mtv.corp.google.com ([2620:15c:202:1:b6af:f85:ed6c:ac6a]) by smtp.gmail.com with ESMTPSA id p7-v6sm5208971pfb.101.2018.09.25.11.53.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Sep 2018 11:53:58 -0700 (PDT) From: Matthias Kaehlcke To: Greg Kroah-Hartman , "Rafael J . Wysocki" , Sakari Ailus , Marcin Wojtas , Andy Shevchenko , Sinan Kaya , Marcel Holtmann , Johan Hedberg , Andrew Morton , Pekka Enberg , Masahiro Yamada , Alexey Dobriyan Cc: linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, Balakrishna Godavarthi , Loic Poulain , Brian Norris , Miguel Ojeda , Rasmus Villemoes , Eli Friedman , Christopher Li , Kees Cook , Ingo Molnar , Geert Uytterhoeven , Joe Perches , Dominique Martinet , Linus Torvalds , linux-sparse@vger.kernel.org Subject: [PATCH v3 1/2] Compiler Attributes: naked can be shared Date: Tue, 25 Sep 2018 11:53:38 -0700 Message-Id: <20180925185339.80701-2-mka@chromium.org> X-Mailer: git-send-email 2.19.0.605.g01d371f741-goog In-Reply-To: <20180925185339.80701-1-mka@chromium.org> References: <20180925185339.80701-1-mka@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miguel Ojeda The naked attribute is supported by at least gcc >= 4.6 (for ARM, which is the only current user), gcc >= 8 (for x86), clang >= 3.1 and icc >= 13. See https://godbolt.org/z/350Dyc Therefore, move it out of compiler-gcc.h so that the definition is shared by all compilers. This also fixes Clang support for ARM32 --- 815f0ddb346c ("include/linux/compiler*.h: make compiler-*.h mutually exclusive"). Fixes: 815f0ddb346c ("include/linux/compiler*.h: make compiler-*.h mutually exclusive") Cc: Rasmus Villemoes Cc: Eli Friedman Cc: Christopher Li Cc: Kees Cook Cc: Ingo Molnar Cc: Geert Uytterhoeven Cc: Greg Kroah-Hartman Cc: Masahiro Yamada Cc: Joe Perches Cc: Dominique Martinet Cc: Linus Torvalds Cc: linux-sparse@vger.kernel.org Suggested-by: Arnd Bergmann Tested-by: Stefan Agner Reviewed-by: Stefan Agner Reviewed-by: Luc Van Oostenryck Reviewed-by: Nick Desaulniers Signed-off-by: Miguel Ojeda Signed-off-by: Greg Kroah-Hartman --- include/linux/compiler-gcc.h | 8 -------- include/linux/compiler_types.h | 8 ++++++++ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h index 25d3dd6b2702..4d36b27214fd 100644 --- a/include/linux/compiler-gcc.h +++ b/include/linux/compiler-gcc.h @@ -79,14 +79,6 @@ #define __noretpoline __attribute__((indirect_branch("keep"))) #endif -/* - * it doesn't make sense on ARM (currently the only user of __naked) - * to trace naked functions because then mcount is called without - * stack and frame pointer being set up and there is no chance to - * restore the lr register to the value before mcount was called. - */ -#define __naked __attribute__((naked)) notrace - #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) #define __optimize(level) __attribute__((__optimize__(level))) diff --git a/include/linux/compiler_types.h b/include/linux/compiler_types.h index 3525c179698c..db192becfec4 100644 --- a/include/linux/compiler_types.h +++ b/include/linux/compiler_types.h @@ -226,6 +226,14 @@ struct ftrace_likely_data { #define notrace __attribute__((no_instrument_function)) #endif +/* + * it doesn't make sense on ARM (currently the only user of __naked) + * to trace naked functions because then mcount is called without + * stack and frame pointer being set up and there is no chance to + * restore the lr register to the value before mcount was called. + */ +#define __naked __attribute__((naked)) notrace + #define __compiler_offsetof(a, b) __builtin_offsetof(a, b) /* -- 2.19.0.605.g01d371f741-goog