From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Rajat Jain <rajatja@google.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Dmitry Torokhov <dtor@google.com>,
linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org, Rajat Jain <rajatxjain@gmail.com>
Subject: Re: sdhci driver card-detect is broken because gpiolib can't fallback to _CRS?
Date: Wed, 26 Sep 2018 10:47:56 +0300 [thread overview]
Message-ID: <20180926074756.GD2664@lahna.fi.intel.com> (raw)
In-Reply-To: <CACK8Z6Ebo0giDifRHBg13pe_mO18vb1n0+LGMoMjkLai6X9MNg@mail.gmail.com>
Hi,
On Tue, Sep 25, 2018 at 01:54:57PM -0700, Rajat Jain wrote:
> * Use con_id=NULL if it is dealing with a legacy BIOS (i.e. no _DSD
> properties in the ACPI).
> * Use con_id=<actual string> if it is dealing with a modern BIOS (i.e.
> which provides _DSD for the <string> property)
Or you can use con_id=<actual string> everywhere and supply
acpi_dev_add_driver_gpios() where needed to cover cases where BIOS does
not provide _DSD. See also Documentation/acpi/gpio-properties.txt for
more information.
In case of SDHCI I think the correct way is to stick using _CRS lookup
only because there typically is just one GpioInt() and I have not seen a
single BIOS yet where they implement _DSD for this besides yours. If
there is not way to change the BIOS implementation then I guess we just
need to amend the driver to call acpi_dev_add_driver_gpios().
next prev parent reply other threads:[~2018-09-26 7:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 20:54 sdhci driver card-detect is broken because gpiolib can't fallback to _CRS? Rajat Jain
2018-09-26 7:47 ` Mika Westerberg [this message]
2018-09-26 8:42 ` Andy Shevchenko
2018-09-26 19:25 ` Rajat Jain
2018-09-27 7:26 ` Andy Shevchenko
2018-09-27 17:56 ` Rajat Jain
2018-09-28 8:42 ` Linus Walleij
2018-09-28 12:34 ` Rajat Jain
2018-09-28 13:13 ` Linus Walleij
2018-10-18 21:51 ` [PATCH] mmc: sdhci-pci: Try "cd" for card-detect lookup before using NULL Rajat Jain
2018-10-19 9:13 ` Andy Shevchenko
2018-10-22 23:34 ` Rajat Jain
2018-10-24 10:02 ` Andy Shevchenko
2018-10-24 18:03 ` Dmitry Torokhov
2018-10-29 15:23 ` Andy Shevchenko
2018-10-29 17:22 ` Rajat Jain
2018-10-29 17:43 ` Andy Shevchenko
2018-10-29 19:43 ` Rajat Jain
2018-10-29 22:17 ` [PATCH v2] " Rajat Jain
2018-10-30 7:53 ` Adrian Hunter
2018-11-12 11:05 ` Ulf Hansson
2018-11-12 11:25 ` Andy Shevchenko
2018-11-13 1:26 ` Rajat Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180926074756.GD2664@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=adrian.hunter@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dtor@google.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=rajatja@google.com \
--cc=rajatxjain@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).