From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81A69C43382 for ; Wed, 26 Sep 2018 17:12:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 138A62150B for ; Wed, 26 Sep 2018 17:12:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 138A62150B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728728AbeIZX0A (ORCPT ); Wed, 26 Sep 2018 19:26:00 -0400 Received: from muru.com ([72.249.23.125]:57370 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727832AbeIZX0A (ORCPT ); Wed, 26 Sep 2018 19:26:00 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id E583D80FA; Wed, 26 Sep 2018 17:16:24 +0000 (UTC) Date: Wed, 26 Sep 2018 10:12:00 -0700 From: Tony Lindgren To: Grygorii Strashko Cc: Linus Walleij , linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] gpio: omap: switch to use irq_chip pm runtime Message-ID: <20180926171200.GV5662@atomide.com> References: <20180925191446.31504-1-grygorii.strashko@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180925191446.31504-1-grygorii.strashko@ti.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Grygorii Strashko [180925 19:19]: > The PM runtime management can be delegated from OMAP GPIO driver to the IRQ > chip core, since commit be45beb2df69 ("genirq: Add runtime power management > support for IRQ chips") introduces runtime power management support for IRQ > chips. > > Hence, drop custom PM runtime support for OMAP GPIO IRQs and switch to IRQ > chip core PM runtime (set irq_chip->parent_device). This would be cool but looks like this patch oopses early during boot at least on omap3 though, maybe because BANK_USED is not for irqs only? Regards, Tony 8< --------------------- gpio gpiochip0: (gpio-0-31): added GPIO chardev (254:0) gpiochip_setup_dev: registered GPIOs 0 to 31 on device: gpiochip0 (gpio-0-31) OMAP GPIO hardware version 2.5 gpio gpiochip1: (gpio-32-63): added GPIO chardev (254:1) gpiochip_setup_dev: registered GPIOs 32 to 63 on device: gpiochip1 (gpio-32-63) gpio gpiochip2: (gpio-64-95): added GPIO chardev (254:2) gpiochip_setup_dev: registered GPIOs 64 to 95 on device: gpiochip2 (gpio-64-95) gpio gpiochip3: (gpio-96-127): added GPIO chardev (254:3) gpiochip_setup_dev: registered GPIOs 96 to 127 on device: gpiochip3 (gpio-96-127) gpio gpiochip4: (gpio-128-159): added GPIO chardev (254:4) gpiochip_setup_dev: registered GPIOs 128 to 159 on device: gpiochip4 (gpio-128-159) gpio gpiochip5: (gpio-160-191): added GPIO chardev (254:5) gpiochip_setup_dev: registered GPIOs 160 to 191 on device: gpiochip5 (gpio-160-191) omap-gpmc 6e000000.gpmc: GPMC revision 5.0 gpmc_mem_init: disabling cs 0 mapped at 0x0-0x1000000 gpiochip_find_base: found new base at 508 gpio gpiochip6: (omap-gpmc): added GPIO chardev (254:6) gpiochip_setup_dev: registered GPIOs 508 to 511 on device: gpiochip6 (omap-gpmc) Unhandled fault: external abort on non-linefetch (0x1028) at 0xfb056028 pgd = (ptrval) [fb056028] *pgd=49011452(bad) Internal error: : 1028 [#1] SMP ARM Modules linked in: CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.19.0-rc4+ #4913 Hardware name: Generic OMAP36xx (Flattened Device Tree) PC is at omap_gpio_ack_irq+0x54/0x5c LR is at omap_gpio_ack_irq+0x20/0x5c pc : [] lr : [] psr: 200000d3 sp : c7103718 ip : 00000001 fp : c710372c r10: c72b2860 r9 : c17028b8 r8 : 00000000 r7 : 00000000 r6 : c01c4418 r5 : 00000000 r4 : c7297414 r3 : fb056028 r2 : 00000002 r1 : 00000028 r0 : fb056000 Flags: nzCv IRQs off FIQs off Mode SVC_32 ISA ARM Segment none Control: 10c5387d Table: 80004019 DAC: 00000051 Process swapper/0 (pid: 1, stack limit = 0x(ptrval)) ... [] (omap_gpio_ack_irq) from [] (__irq_do_set_handler+0x1c0/0x1e4) [] (__irq_do_set_handler) from [] (__irq_set_handler+0x58/0x88) [] (__irq_set_handler) from [] (irq_set_chip_and_handler_name+0x38/0x3c) [] (irq_set_chip_and_handler_name) from [] (gpiochip_irq_map+0x94/0x13c) [] (gpiochip_irq_map) from [] (irq_domain_associate+0x80/0x1c0) [] (irq_domain_associate) from [] (irq_create_mapping+0x74/0xdc) [] (irq_create_mapping) from [] (irq_create_fwspec_mapping+0x15c/0x338) [] (irq_create_fwspec_mapping) from [] (irq_create_of_mapping+0x68/0x88) [] (irq_create_of_mapping) from [] (of_irq_get+0x74/0xc4) [] (of_irq_get) from [] (of_irq_to_resource+0x34/0xe8) [] (of_irq_to_resource) from [] (of_irq_to_resource_table+0x48/0x5c) [] (of_irq_to_resource_table) from [] (of_device_alloc+0xf8/0x294) [] (of_device_alloc) from [] (of_platform_device_create_pdata+0x58/0xc8) [] (of_platform_device_create_pdata) from [] (of_platform_device_create+0x20/0x24) [] (of_platform_device_create) from [] (gpmc_probe_generic_child+0x2ec/0x990) [] (gpmc_probe_generic_child) from [] (gpmc_probe+0x3e0/0x5a8) [] (gpmc_probe) from [] (platform_drv_probe+0x58/0xa8) [] (platform_drv_probe) from [] (really_probe+0x200/0x2cc) [] (really_probe) from [] (driver_probe_device+0x6c/0x174) [] (driver_probe_device) from [] (__device_attach_driver+0xc0/0xe4) [] (__device_attach_driver) from [] (bus_for_each_drv+0x8c/0xd4) [] (bus_for_each_drv) from [] (__device_attach+0xdc/0x14c) [] (__device_attach) from [] (device_initial_probe+0x1c/0x20) [] (device_initial_probe) from [] (bus_probe_device+0x98/0xa0) [] (bus_probe_device) from [] (device_add+0x364/0x628) [] (device_add) from [] (of_device_add+0x40/0x48) [] (of_device_add) from [] (of_platform_device_create_pdata+0x9c/0xc8) [] (of_platform_device_create_pdata) from [] (of_platform_bus_create+0x1b4/0x254) [] (of_platform_bus_create) from [] (of_platform_bus_create+0x200/0x254) [] (of_platform_bus_create) from [] (of_platform_populate+0x6c/0xbc) [] (of_platform_populate) from [] (pdata_quirks_init+0x7c/0xa0) [] (pdata_quirks_init) from [] (omap_generic_init+0x1c/0x28) [] (omap_generic_init) from [] (customize_machine+0x2c/0x38) [] (customize_machine) from [] (do_one_initcall+0x90/0x398) [] (do_one_initcall) from [] (kernel_init_freeable+0x478/0x558) [] (kernel_init_freeable) from [] (kernel_init+0x18/0x124) [] (kernel_init) from [] (ret_from_fork+0x14/0x20) Exception stack(0xc7103fb0 to 0xc7103ff8) 3fa0: 00000000 00000000 00000000 00000000 3fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 3fe0: 00000000 00000000 00000000 00000000 00000013 00000000 Code: e3510000 0a000001 e0803001 e5832000 (e5933000) ---[ end trace 43f0b1bf9cbb2007 ]---