From: MyungJoo Ham <myungjoo.ham@samsung.com>
To: Kyungmin Park <kyungmin.park@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "john.reitan@arm.com" <john.reitan@arm.com>,
"beata.michalska@arm.com" <beata.michalska@arm.com>,
Vincent Donnefort <vincent.donnefort@arm.com>
Subject: RE: [PATCH v2] PM / devfreq: Stop the governor before device_unregister()
Date: Thu, 27 Sep 2018 14:20:36 +0900 [thread overview]
Message-ID: <20180927052036epcms1p15fb2970f4ddc0256096d674d6932aabd@epcms1p1> (raw)
In-Reply-To: <1537544432-34712-1-git-send-email-vincent.donnefort@arm.com>
> From: Vincent Donnefort <vincent.donnefort@arm.com>
>
> device_release() is freeing the resources before calling the device
> specific release callback which is, in the case of devfreq, stopping
> the governor.
>
> It is a problem as some governors are using the device resources. e.g.
> simpleondemand which is using the devfreq deferrable monitoring work. If it
> is not stopped before the resources are freed, it might lead to a use after
> free.
>
> Signed-off-by: Vincent Donnefort <vincent.donnefort@arm.com>
> Reviewed-by: John Einar Reitan <john.reitan@arm.com>
> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Cheers,
MyungJoo
prev parent reply other threads:[~2018-09-27 5:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180830100409epcas3p266dc05fdd02cd2c086a4355e9a481007@epcas3p2.samsung.com>
2018-08-30 10:02 ` [PATCH] PM / devfreq: stopping the governor before device_unregister() vincent.donnefort
2018-08-31 8:52 ` Chanwoo Choi
2018-09-21 15:40 ` [PATCH v2] PM / devfreq: Stop " vincent.donnefort
[not found] ` <CGME20180921154052epcas1p4d4ba6b7435a50f1f77ae85ceda594b69@epcms1p1>
2018-09-27 5:20 ` MyungJoo Ham [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180927052036epcms1p15fb2970f4ddc0256096d674d6932aabd@epcms1p1 \
--to=myungjoo.ham@samsung.com \
--cc=beata.michalska@arm.com \
--cc=cw00.choi@samsung.com \
--cc=john.reitan@arm.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=vincent.donnefort@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).