linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Oscar Salvador <osalvador@techadventures.net>
To: Arun KS <arunks@codeaurora.org>
Cc: kys@microsoft.com, haiyangz@microsoft.com,
	sthemmin@microsoft.com, boris.ostrovsky@oracle.com,
	jgross@suse.com, akpm@linux-foundation.org,
	dan.j.williams@intel.com, mhocko@suse.com, vbabka@suse.cz,
	iamjoonsoo.kim@lge.com, gregkh@linuxfoundation.org,
	osalvador@suse.de, malat@debian.org,
	kirill.shutemov@linux.intel.com, jrdr.linux@gmail.com,
	yasu.isimatu@gmail.com, mgorman@techsingularity.net,
	aaron.lu@intel.com, devel@linuxdriverproject.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	xen-devel@lists.xenproject.org, vatsa@codeaurora.org,
	vinmenon@codeaurora.org, getarunks@gmail.com
Subject: Re: [PATCH v3] memory_hotplug: Free pages as higher order
Date: Thu, 27 Sep 2018 09:09:58 +0200	[thread overview]
Message-ID: <20180927070957.GA19369@techadventures.net> (raw)
In-Reply-To: <1538031530-25489-1-git-send-email-arunks@codeaurora.org>

On Thu, Sep 27, 2018 at 12:28:50PM +0530, Arun KS wrote:
> +	__free_pages_boot_core(page, order);

I am not sure, but if we are going to use that function from the memory-hotplug code,
we might want to rename that function to something more generic?
The word "boot" suggests that this is only called from the boot stage.

And what about the prefetch operations? 
I saw that you removed them in your previous patch and that had some benefits [1].

Should we remove them here as well?

[1] https://patchwork.kernel.org/patch/10613359/ 

Thanks
-- 
Oscar Salvador
SUSE L3

  reply	other threads:[~2018-09-27  7:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-27  6:58 Arun KS
2018-09-27  7:09 ` Oscar Salvador [this message]
2018-09-27  8:09   ` Arun KS
2018-09-27  7:11 ` Juergen Gross
2018-09-27  8:11   ` Arun KS

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180927070957.GA19369@techadventures.net \
    --to=osalvador@techadventures.net \
    --cc=aaron.lu@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=arunks@codeaurora.org \
    --cc=boris.ostrovsky@oracle.com \
    --cc=dan.j.williams@intel.com \
    --cc=devel@linuxdriverproject.org \
    --cc=getarunks@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=haiyangz@microsoft.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=jgross@suse.com \
    --cc=jrdr.linux@gmail.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=kys@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=malat@debian.org \
    --cc=mgorman@techsingularity.net \
    --cc=mhocko@suse.com \
    --cc=osalvador@suse.de \
    --cc=sthemmin@microsoft.com \
    --cc=vatsa@codeaurora.org \
    --cc=vbabka@suse.cz \
    --cc=vinmenon@codeaurora.org \
    --cc=xen-devel@lists.xenproject.org \
    --cc=yasu.isimatu@gmail.com \
    --subject='Re: [PATCH v3] memory_hotplug: Free pages as higher order' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).