From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A0C1C43382 for ; Thu, 27 Sep 2018 14:52:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 110F221580 for ; Thu, 27 Sep 2018 14:52:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 110F221580 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728161AbeI0VL0 (ORCPT ); Thu, 27 Sep 2018 17:11:26 -0400 Received: from mga09.intel.com ([134.134.136.24]:23697 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727338AbeI0VLZ (ORCPT ); Thu, 27 Sep 2018 17:11:25 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Sep 2018 07:52:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,311,1534834800"; d="scan'208";a="87151763" Received: from jsakkine-mobl1.tm.intel.com (HELO localhost) ([10.237.50.69]) by orsmga003.jf.intel.com with ESMTP; 27 Sep 2018 07:52:39 -0700 Date: Thu, 27 Sep 2018 17:52:38 +0300 From: Jarkko Sakkinen To: Borislav Petkov Cc: x86@kernel.org, platform-driver-x86@vger.kernel.org, dave.hansen@intel.com, sean.j.christopherson@intel.com, nhorman@redhat.com, npmccallum@redhat.com, serge.ayoun@intel.com, shay.katz-zamir@intel.com, linux-sgx@vger.kernel.org, andriy.shevchenko@linux.intel.com, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Konrad Rzeszutek Wilk , David Woodhouse , David Wang , "Kirill A. Shutemov" , "Levin, Alexander (Sasha Levin)" , Jia Zhang , "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , He Chen , Luwei Kang , kvm@vger.kernel.org, Radim =?utf-8?B?S3LEjW3DocWZ?= , Piotr Luc , Paolo Bonzini Subject: Re: [PATCH v14 04/19] x86/cpufeatures: Add SGX feature bits Message-ID: <20180927145238.GA9769@linux.intel.com> References: <20180925130845.9962-1-jarkko.sakkinen@linux.intel.com> <20180925130845.9962-5-jarkko.sakkinen@linux.intel.com> <20180925164854.GF23986@zn.tnic> <20180926111139.GA12037@linux.intel.com> <20180926113617.GD5584@zn.tnic> <20180927131642.GE5436@linux.intel.com> <20180927135139.GB19687@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180927135139.GB19687@zn.tnic> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 27, 2018 at 03:51:39PM +0200, Borislav Petkov wrote: > On Thu, Sep 27, 2018 at 04:16:42PM +0300, Jarkko Sakkinen wrote: > > Still kind of leaves me puzzled about the situation :-) Why this wasn't > > used for example to replace detect_vmx_virtcap()? > > I don't understand - detect_vmx_virtcap() is setting X86_FEATURE bits > based on MSR settings. get_scattered_cpuid_leaf() is regenerating a > CPUID leaf from the scattered bits. > > Looks like apples and oranges to me... > > -- > Regards/Gruss, > Boris. > > Good mailing practices for 400: avoid top-posting and trim the reply. Ugh, sorry, I was not thinking clearly :-) /Jarkko