From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: jdelvare@suse.com, linux@roeck-us.net, mark.rutland@arm.com,
corbet@lwn.net, afd@ti.com, linux-hwmon@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v5 1/2] dt-bindings: hwmon: Add ina3221 documentation
Date: Thu, 27 Sep 2018 11:39:56 -0700 [thread overview]
Message-ID: <20180927183955.GB15719@Asurada-Nvidia.nvidia.com> (raw)
In-Reply-To: <20180927174413.GB7587@bogus>
On Thu, Sep 27, 2018 at 12:44:13PM -0500, Rob Herring wrote:
> > +2) child nodes
> > + Required properties:
> > + - reg: Must be 0, 1 or 2, corresponding to IN1, IN2 or IN3 port of INA3221
> > +
> > + Optional properties:
> > + - label: Name of the input source
> > + - shunt-resistor-micro-ohms: Shunt resistor value in micro-Ohm
> > + - status: Should be "disabled" if no input source
>
> Don't need to explicitly list status.
Will remove in v6.
> > +
> > + Example:
> > +
> > + input@0 {
> > + reg = <0x0>;
> > + status = "disabled";
> > + };
> > + input@1 {
> > + reg = <0x1>;
> > + shunt-resistor-micro-ohms = <5000>;
> > + };
> > + input@2 {
> > + reg = <0x2>;
> > + label = "VDD_5V";
> > + shunt-resistor-micro-ohms = <5000>;
> > + };
>
> Please combine the examples into one complete example.
Will merge them in v6.
Thank you
Nicolin
next prev parent reply other threads:[~2018-09-27 18:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 22:59 [PATCH v5 0/2] Add an initial DT binding doc for ina3221 Nicolin Chen
2018-09-25 22:59 ` [PATCH v5 1/2] dt-bindings: hwmon: Add ina3221 documentation Nicolin Chen
2018-09-26 1:52 ` Guenter Roeck
2018-09-26 3:08 ` Nicolin Chen
2018-09-26 3:40 ` Guenter Roeck
2018-09-26 6:14 ` Nicolin Chen
2018-09-27 17:42 ` Rob Herring
2018-09-27 17:44 ` Rob Herring
2018-09-27 18:39 ` Nicolin Chen [this message]
2018-09-25 22:59 ` [PATCH v5 2/2] hwmon: ina3221: Read channel input source info from DT Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180927183955.GB15719@Asurada-Nvidia.nvidia.com \
--to=nicoleotsuka@gmail.com \
--cc=afd@ti.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).