From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CE28C43382 for ; Thu, 27 Sep 2018 19:10:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F271421708 for ; Thu, 27 Sep 2018 19:10:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="WIU7NWQs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F271421708 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728676AbeI1BaZ (ORCPT ); Thu, 27 Sep 2018 21:30:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:55028 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727587AbeI1BaY (ORCPT ); Thu, 27 Sep 2018 21:30:24 -0400 Received: from jouet.infradead.org (unknown [179.97.41.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C4483215F0; Thu, 27 Sep 2018 19:10:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1538075440; bh=+W1uZdQWCbjLT/q8xzUT5/v0jCpXynNBnoh63nniVzs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WIU7NWQsJ7eEfBydN7ElHVbKj5mW02PXig3YI0+gMKWBFx232bYKA1K7VY8y8/5lY 84kKz+gQpRDGQKxrDVkr8oO4V4+KddXr7MxiHXWR5bw8BIaGPlQ5x/TuBlwAfw2FnC aaxlH5Koc7S7Pdue93U6FR49lJwQrVP8X5YaOYbA= Received: by jouet.infradead.org (Postfix, from userid 1000) id B8E6B1401A1; Thu, 27 Sep 2018 16:10:37 -0300 (-03) Date: Thu, 27 Sep 2018 16:10:37 -0300 From: Arnaldo Carvalho de Melo To: Milian Wolff Cc: jolsa@kernel.org, yao.jin@linux.intel.com, namhyung@kernel.org, Linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: Re: [PATCH 3/3] perf report: don't crash on invalid inline debug information Message-ID: <20180927191037.GG25764@kernel.org> References: <20180926135207.30263-1-milian.wolff@kdab.com> <20180926135207.30263-3-milian.wolff@kdab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180926135207.30263-3-milian.wolff@kdab.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Sep 26, 2018 at 03:52:07PM +0200, Milian Wolff escreveu: > When the function name for an inline frame is invalid, we must > not try to demangle this symbol, otherwise we crash with: > > #0 0x0000555555895c01 in bfd_demangle () > #1 0x0000555555823262 in demangle_sym (dso=0x555555d92b90, elf_name=0x0, kmodule=0) at util/symbol-elf.c:215 > #2 dso__demangle_sym (dso=dso@entry=0x555555d92b90, kmodule=, kmodule@entry=0, elf_name=elf_name@entry=0x0) at util/symbol-elf.c:400 > #3 0x00005555557fef4b in new_inline_sym (funcname=0x0, base_sym=0x555555d92b90, dso=0x555555d92b90) at util/srcline.c:89 > #4 inline_list__append_dso_a2l (dso=dso@entry=0x555555c7bb00, node=node@entry=0x555555e31810, sym=sym@entry=0x555555d92b90) at util/srcline.c:264 > #5 0x00005555557ff27f in addr2line (dso_name=dso_name@entry=0x555555d92430 "/home/milian/.debug/.build-id/f7/186d14bb94f3c6161c010926da66033d24fce5/elf", addr=addr@entry=2888, file=file@entry=0x0, > line=line@entry=0x0, dso=dso@entry=0x555555c7bb00, unwind_inlines=unwind_inlines@entry=true, node=0x555555e31810, sym=0x555555d92b90) at util/srcline.c:313 > #6 0x00005555557ffe7c in addr2inlines (sym=0x555555d92b90, dso=0x555555c7bb00, addr=2888, dso_name=0x555555d92430 "/home/milian/.debug/.build-id/f7/186d14bb94f3c6161c010926da66033d24fce5/elf") > at util/srcline.c:358 > > So instead handle the case where we get invalid function names > for inlined frames and use a fallback '??' function name instead. > > While this crash was originally reported by Hadrien for rust code, > I can now also reproduce it with trivial C++ code. Indeed, it seems > like libbfd fails to interpret the debug information for the inline > frame symbol name: > > $ addr2line -e /home/milian/.debug/.build-id/f7/186d14bb94f3c6161c010926da66033d24fce5/elf -if b48 > main > /usr/include/c++/8.2.1/complex:610 > ?? > /usr/include/c++/8.2.1/complex:618 > ?? > /usr/include/c++/8.2.1/complex:675 > ?? > /usr/include/c++/8.2.1/complex:685 > main > /home/milian/projects/kdab/rnd/hotspot/tests/test-clients/cpp-inlining/main.cpp:39 > > I've reported this bug upstream and also attached a patch there > which should fix this issue: > https://sourceware.org/bugzilla/show_bug.cgi?id=23715 Millian, what about this one, which is the cset it is fixing? - Arnaldo > Signed-off-by: Milian Wolff > Cc: Arnaldo Carvalho de Melo > Reported-by: Hadrien Grasland > --- > tools/perf/util/srcline.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tools/perf/util/srcline.c b/tools/perf/util/srcline.c > index 09d6746e6ec8..e767c4a9d4d2 100644 > --- a/tools/perf/util/srcline.c > +++ b/tools/perf/util/srcline.c > @@ -85,6 +85,9 @@ static struct symbol *new_inline_sym(struct dso *dso, > struct symbol *inline_sym; > char *demangled = NULL; > > + if (!funcname) > + funcname = "??"; > + > if (dso) { > demangled = dso__demangle_sym(dso, 0, funcname); > if (demangled) > -- > 2.19.0