From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: jdelvare@suse.com, robh+dt@kernel.org, mark.rutland@arm.com,
corbet@lwn.net, afd@ti.com, linux-hwmon@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v7 2/2] hwmon: ina3221: Read channel input source info from DT
Date: Thu, 27 Sep 2018 15:11:12 -0700 [thread overview]
Message-ID: <20180927221111.GA29012@Asurada-Nvidia.nvidia.com> (raw)
In-Reply-To: <20180927220620.GD9198@roeck-us.net>
On Thu, Sep 27, 2018 at 03:06:20PM -0700, Guenter Roeck wrote:
> I am quite sure I asked to use kstrtobool(). Did that get lost or do you have
> some reason to not use it ?
>
> I can understand if you don't want to change ina3221_is_enable() to
> ina3221_is_enabled(), since that is POV, but I don't really understand
> why you did not make the other changes. Am I missing something ?
Sorry, my fault. It's not really "I don't want to" but I missed the
part in that review. Will fix them all.
Thanks
Nicolin
prev parent reply other threads:[~2018-09-27 22:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 20:54 [PATCH v7 0/2] Add an initial DT binding doc for ina3221 Nicolin Chen
2018-09-27 20:54 ` [PATCH v7 1/2] dt-bindings: hwmon: Add ina3221 documentation Nicolin Chen
2018-09-27 20:54 ` [PATCH v7 2/2] hwmon: ina3221: Read channel input source info from DT Nicolin Chen
2018-09-27 22:06 ` Guenter Roeck
2018-09-27 22:11 ` Nicolin Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180927221111.GA29012@Asurada-Nvidia.nvidia.com \
--to=nicoleotsuka@gmail.com \
--cc=afd@ti.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).