* Bad MAINTAINERS pattern in section 'ACPI'
@ 2018-09-28 21:50 Joe Perches
2018-09-28 23:06 ` Bjorn Helgaas
0 siblings, 1 reply; 4+ messages in thread
From: Joe Perches @ 2018-09-28 21:50 UTC (permalink / raw)
To: linux-kernel
Cc: Rafael J . Wysocki, Len Brown, linux-acpi, Bjorn Helgaas, Keith Busch
Please fix this defect appropriately.
linux-next MAINTAINERS section:
308 ACPI
309 M: "Rafael J. Wysocki" <rjw@rjwysocki.net>
310 M: Len Brown <lenb@kernel.org>
311 L: linux-acpi@vger.kernel.org
312 W: https://01.org/linux-acpi
313 Q: https://patchwork.kernel.org/project/linux-acpi/list/
314 T: git git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm
315 B: https://bugzilla.kernel.org
316 S: Supported
317 F: drivers/acpi/
318 F: drivers/pnp/pnpacpi/
319 F: include/linux/acpi.h
320 F: include/linux/fwnode.h
321 F: include/acpi/
322 F: Documentation/acpi/
323 F: Documentation/ABI/testing/sysfs-bus-acpi
324 F: Documentation/ABI/testing/configfs-acpi
325 F: drivers/pci/*acpi*
326 F: drivers/pci/*/*acpi*
--> 327 F: drivers/pci/*/*/*acpi*
328 F: tools/power/acpi/
Commit that introduced this:
commit 15fd830dd310e6cf589478e5e1e7733caf68e777
Author: Bjorn Helgaas <bhelgaas@google.com>
Date: Wed Jun 26 13:38:37 2013 -0600
MAINTAINERS: Add ACPI folks for ACPI-related things under drivers/pci
Add file patterns so get_maintainers.pl reports both PCI and ACPI folks
for ACPI-related things in drivers/pci.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
MAINTAINERS | 3 +++
1 file changed, 3 insertions(+)
Last commit with drivers/pci/*/*/*acpi*
commit 256a459370930bed087f92bb763517f8b09407eb
Author: Bjorn Helgaas <bhelgaas@google.com>
Date: Fri Jun 8 08:39:45 2018 -0500
PCI/AER: Squash aerdrv_acpi.c into aerdrv.c
Squash aerdrv_acpi.c into aerdrv.c. No functional change intended.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Keith Busch <keith.busch@intel.com>
drivers/pci/pcie/aer/Makefile | 1 -
drivers/pci/pcie/aer/aerdrv.c | 122 ++++++++++++++++++++++++++++++++
drivers/pci/pcie/aer/aerdrv_acpi.c | 141 -------------------------------------
3 files changed, 122 insertions(+), 142 deletions(-)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Bad MAINTAINERS pattern in section 'ACPI'
2018-09-28 21:50 Bad MAINTAINERS pattern in section 'ACPI' Joe Perches
@ 2018-09-28 23:06 ` Bjorn Helgaas
2018-09-29 13:18 ` Rafael J. Wysocki
2018-10-01 18:54 ` Bjorn Helgaas
0 siblings, 2 replies; 4+ messages in thread
From: Bjorn Helgaas @ 2018-09-28 23:06 UTC (permalink / raw)
To: Joe Perches
Cc: linux-kernel, Rafael J . Wysocki, Len Brown, linux-acpi,
Bjorn Helgaas, Keith Busch, Tony Luck, Borislav Petkov,
linux-pci
[+cc Tony, Borislav (ACPI APEI reviewers), linux-pci]
On Fri, Sep 28, 2018 at 02:50:53PM -0700, Joe Perches wrote:
> Please fix this defect appropriately.
>
> linux-next MAINTAINERS section:
>
> 308 ACPI
> 309 M: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> 310 M: Len Brown <lenb@kernel.org>
> 311 L: linux-acpi@vger.kernel.org
> 312 W: https://01.org/linux-acpi
> 313 Q: https://patchwork.kernel.org/project/linux-acpi/list/
> 314 T: git git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm
> 315 B: https://bugzilla.kernel.org
> 316 S: Supported
> 317 F: drivers/acpi/
> 318 F: drivers/pnp/pnpacpi/
> 319 F: include/linux/acpi.h
> 320 F: include/linux/fwnode.h
> 321 F: include/acpi/
> 322 F: Documentation/acpi/
> 323 F: Documentation/ABI/testing/sysfs-bus-acpi
> 324 F: Documentation/ABI/testing/configfs-acpi
> 325 F: drivers/pci/*acpi*
> 326 F: drivers/pci/*/*acpi*
> --> 327 F: drivers/pci/*/*/*acpi*
> 328 F: tools/power/acpi/
My proposal to fix this:
commit a99051c0d3c59fd259fd76a8bbd9837b76b509d9
Author: Bjorn Helgaas <bhelgaas@google.com>
Date: Fri Sep 28 17:34:21 2018 -0500
MAINTAINERS: Remove obsolete drivers/pci pattern from ACPI section
Prior to 256a45937093 ("PCI/AER: Squash aerdrv_acpi.c into aerdrv.c"),
drivers/pci/pcie/aer/aerdrv_acpi.c contained code to parse the ACPI HEST
table. That code now lives in drivers/pci/pcie/aer.c.
Remove the "F: drivers/pci/*/*/*acpi*" pattern because it matches nothing.
We could add a "F: drivers/pci/pcie/aer.c" pattern to the ACPI APEI
section, but that file sees a lot of changes, almost none of which are of
interest to the ACPI folks.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
diff --git a/MAINTAINERS b/MAINTAINERS
index 700408b7bc53..9babd8a0406b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -324,7 +324,6 @@ F: Documentation/ABI/testing/sysfs-bus-acpi
F: Documentation/ABI/testing/configfs-acpi
F: drivers/pci/*acpi*
F: drivers/pci/*/*acpi*
-F: drivers/pci/*/*/*acpi*
F: tools/power/acpi/
ACPI APEI
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: Bad MAINTAINERS pattern in section 'ACPI'
2018-09-28 23:06 ` Bjorn Helgaas
@ 2018-09-29 13:18 ` Rafael J. Wysocki
2018-10-01 18:54 ` Bjorn Helgaas
1 sibling, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2018-09-29 13:18 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Joe Perches, Linux Kernel Mailing List, Rafael J. Wysocki,
Len Brown, ACPI Devel Maling List, Bjorn Helgaas, Keith Busch,
Tony Luck, Borislav Petkov, Linux PCI
On Sat, Sep 29, 2018 at 1:06 AM Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> [+cc Tony, Borislav (ACPI APEI reviewers), linux-pci]
>
> On Fri, Sep 28, 2018 at 02:50:53PM -0700, Joe Perches wrote:
> > Please fix this defect appropriately.
> >
> > linux-next MAINTAINERS section:
> >
> > 308 ACPI
> > 309 M: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> > 310 M: Len Brown <lenb@kernel.org>
> > 311 L: linux-acpi@vger.kernel.org
> > 312 W: https://01.org/linux-acpi
> > 313 Q: https://patchwork.kernel.org/project/linux-acpi/list/
> > 314 T: git git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm
> > 315 B: https://bugzilla.kernel.org
> > 316 S: Supported
> > 317 F: drivers/acpi/
> > 318 F: drivers/pnp/pnpacpi/
> > 319 F: include/linux/acpi.h
> > 320 F: include/linux/fwnode.h
> > 321 F: include/acpi/
> > 322 F: Documentation/acpi/
> > 323 F: Documentation/ABI/testing/sysfs-bus-acpi
> > 324 F: Documentation/ABI/testing/configfs-acpi
> > 325 F: drivers/pci/*acpi*
> > 326 F: drivers/pci/*/*acpi*
> > --> 327 F: drivers/pci/*/*/*acpi*
> > 328 F: tools/power/acpi/
>
> My proposal to fix this:
>
> commit a99051c0d3c59fd259fd76a8bbd9837b76b509d9
> Author: Bjorn Helgaas <bhelgaas@google.com>
> Date: Fri Sep 28 17:34:21 2018 -0500
>
> MAINTAINERS: Remove obsolete drivers/pci pattern from ACPI section
>
> Prior to 256a45937093 ("PCI/AER: Squash aerdrv_acpi.c into aerdrv.c"),
> drivers/pci/pcie/aer/aerdrv_acpi.c contained code to parse the ACPI HEST
> table. That code now lives in drivers/pci/pcie/aer.c.
>
> Remove the "F: drivers/pci/*/*/*acpi*" pattern because it matches nothing.
>
> We could add a "F: drivers/pci/pcie/aer.c" pattern to the ACPI APEI
> section, but that file sees a lot of changes, almost none of which are of
> interest to the ACPI folks.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 700408b7bc53..9babd8a0406b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -324,7 +324,6 @@ F: Documentation/ABI/testing/sysfs-bus-acpi
> F: Documentation/ABI/testing/configfs-acpi
> F: drivers/pci/*acpi*
> F: drivers/pci/*/*acpi*
> -F: drivers/pci/*/*/*acpi*
> F: tools/power/acpi/
Looks good to me.
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Bad MAINTAINERS pattern in section 'ACPI'
2018-09-28 23:06 ` Bjorn Helgaas
2018-09-29 13:18 ` Rafael J. Wysocki
@ 2018-10-01 18:54 ` Bjorn Helgaas
1 sibling, 0 replies; 4+ messages in thread
From: Bjorn Helgaas @ 2018-10-01 18:54 UTC (permalink / raw)
To: Joe Perches
Cc: linux-kernel, Rafael J . Wysocki, Len Brown, linux-acpi,
Bjorn Helgaas, Keith Busch, Tony Luck, Borislav Petkov,
linux-pci
On Fri, Sep 28, 2018 at 06:06:17PM -0500, Bjorn Helgaas wrote:
> [+cc Tony, Borislav (ACPI APEI reviewers), linux-pci]
>
> On Fri, Sep 28, 2018 at 02:50:53PM -0700, Joe Perches wrote:
> > Please fix this defect appropriately.
> >
> > linux-next MAINTAINERS section:
> >
> > 308 ACPI
> > 309 M: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> > 310 M: Len Brown <lenb@kernel.org>
> > 311 L: linux-acpi@vger.kernel.org
> > 312 W: https://01.org/linux-acpi
> > 313 Q: https://patchwork.kernel.org/project/linux-acpi/list/
> > 314 T: git git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm
> > 315 B: https://bugzilla.kernel.org
> > 316 S: Supported
> > 317 F: drivers/acpi/
> > 318 F: drivers/pnp/pnpacpi/
> > 319 F: include/linux/acpi.h
> > 320 F: include/linux/fwnode.h
> > 321 F: include/acpi/
> > 322 F: Documentation/acpi/
> > 323 F: Documentation/ABI/testing/sysfs-bus-acpi
> > 324 F: Documentation/ABI/testing/configfs-acpi
> > 325 F: drivers/pci/*acpi*
> > 326 F: drivers/pci/*/*acpi*
> > --> 327 F: drivers/pci/*/*/*acpi*
> > 328 F: tools/power/acpi/
>
> My proposal to fix this:
>
> commit a99051c0d3c59fd259fd76a8bbd9837b76b509d9
> Author: Bjorn Helgaas <bhelgaas@google.com>
> Date: Fri Sep 28 17:34:21 2018 -0500
>
> MAINTAINERS: Remove obsolete drivers/pci pattern from ACPI section
>
> Prior to 256a45937093 ("PCI/AER: Squash aerdrv_acpi.c into aerdrv.c"),
> drivers/pci/pcie/aer/aerdrv_acpi.c contained code to parse the ACPI HEST
> table. That code now lives in drivers/pci/pcie/aer.c.
>
> Remove the "F: drivers/pci/*/*/*acpi*" pattern because it matches nothing.
>
> We could add a "F: drivers/pci/pcie/aer.c" pattern to the ACPI APEI
> section, but that file sees a lot of changes, almost none of which are of
> interest to the ACPI folks.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 700408b7bc53..9babd8a0406b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -324,7 +324,6 @@ F: Documentation/ABI/testing/sysfs-bus-acpi
> F: Documentation/ABI/testing/configfs-acpi
> F: drivers/pci/*acpi*
> F: drivers/pci/*/*acpi*
> -F: drivers/pci/*/*/*acpi*
> F: tools/power/acpi/
>
> ACPI APEI
Applied with Rafael's ack to for-linus for v4.19.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-10-01 18:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-28 21:50 Bad MAINTAINERS pattern in section 'ACPI' Joe Perches
2018-09-28 23:06 ` Bjorn Helgaas
2018-09-29 13:18 ` Rafael J. Wysocki
2018-10-01 18:54 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).