From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Lukasz Majewski <lukma@denx.de>
Cc: Frieder Schrempf <frieder.schrempf@exceet.de>,
Mark Rutland <mark.rutland@arm.com>,
linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org, yogeshnarayan.gaur@nxp.com,
richard@nod.at, Stefan Agner <stefan@agner.ch>,
Fabio Estevam <festevam@gmail.com>,
Fabio Estevam <fabio.estevam@nxp.com>,
prabhakar.kushwaha@nxp.com, han.xu@nxp.com, broonie@kernel.org,
david.wolfe@nxp.com, computersforpeace@gmail.com,
dwmw2@infradead.org, albert.aribaud@3adev.fr
Subject: Re: [RFC/RFT PATCH v1 0/9] mtd: fsl: quadspi: Fixes for fsl-quadspi.c driver (vybrid HW)
Date: Sat, 29 Sep 2018 00:03:59 +0200 [thread overview]
Message-ID: <20180929000359.34fe18ae@bbrezillon> (raw)
In-Reply-To: <20180926220739.620-1-lukma@denx.de>
Hi Lukasz,
On Thu, 27 Sep 2018 00:07:30 +0200
Lukasz Majewski <lukma@denx.de> wrote:
> Please find following set of patches, which provide improved behaviour
> of the fsl-quadspi.c driver on Vybrid vf610 HW.
>
> Below code is based on previous work done by Albert ARIBAUD:
> https://patchwork.ozlabs.org/patch/675401/
>
> I've cleaned up the code a bit, make separate patches, exclude not
> needed parts and port it to v4.19-rc3.
>
> After applying those patches, the quadspi controller on vf610 works
> with UBI/UBIFS.
> The problem is with some corner case writes to raw MTD device
> (like writing 1023B with single byte writes). Those fail sometimes.
>
> Regression tests can be found in the following repository:
> https://github.com/lmajewski/tests-spi/tree/master/tests
>
> (Please read README.txt).
>
> The NXP's community thread regarding HW issues in this block on
> the vf610:
> https://community.nxp.com/thread/485139
>
> Maybe those patches will be helpful with the new, work in progress
> driver for spi-fsl-qspi.c
Talking about that, can you try to port your fixes on top of Frieder's
patchset? I'm pretty sure some bug fixes are irrelevant after the
migration to spi-mem (patch 1, 3, 4, 5, 6, 7 and 9 should be dropped I
think).
>
> Lukasz Majewski (9):
> Revert "mtd: fsl-quadspi: Rename SEQID_QUAD_READ to SEQID_READ"
> mtd: qspi: Provide quirk to read only half of RX buffer (NXP's vybrid)
> mtd: spi: Do not setup the default seqid as we got it set for DUAL and
> QUAD
> mtd: spi: Modify the HW capability mask according to supported RX
> lanes
> mtd: spi: Provide LUT entry to perform DUAL read
> mtd: spi: Enhance the fsl_qspi_read() method to support DUAL and QUAD
> mtd: spi: Add SPI_NOR_DUAL_READ property for the 'n25q128a13' Micron
> memory
> mtd: spi: Allocate memory corresponding to maximal fsl-quadspi.c
> controller area
> mtd: spi: Skip reading the Serial Flash Discoverable Parameters
next prev parent reply other threads:[~2018-09-28 22:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 22:07 [RFC/RFT PATCH v1 0/9] mtd: fsl: quadspi: Fixes for fsl-quadspi.c driver (vybrid HW) Lukasz Majewski
2018-09-26 22:07 ` [RFC/RFT PATCH v1 1/9] Revert "mtd: fsl-quadspi: Rename SEQID_QUAD_READ to SEQID_READ" Lukasz Majewski
2018-09-26 22:07 ` [RFC/RFT PATCH v1 2/9] mtd: qspi: Provide quirk to read only half of RX buffer (NXP's vybrid) Lukasz Majewski
2018-09-26 22:07 ` [RFC/RFT PATCH v1 3/9] mtd: spi: Do not setup the default seqid as we got it set for DUAL and QUAD Lukasz Majewski
2018-09-26 22:07 ` [RFC/RFT PATCH v1 4/9] mtd: spi: Modify the HW capability mask according to supported RX lanes Lukasz Majewski
2018-09-26 22:07 ` [RFC/RFT PATCH v1 5/9] mtd: spi: Provide LUT entry to perform DUAL read Lukasz Majewski
2018-09-26 22:07 ` [RFC/RFT PATCH v1 6/9] mtd: spi: Enhance the fsl_qspi_read() method to support DUAL and QUAD Lukasz Majewski
2018-09-26 22:07 ` [RFC/RFT PATCH v1 7/9] mtd: spi: Add SPI_NOR_DUAL_READ property for the 'n25q128a13' Micron memory Lukasz Majewski
2018-09-26 22:07 ` [RFC/RFT PATCH v1 8/9] mtd: spi: Allocate memory corresponding to maximal fsl-quadspi.c controller area Lukasz Majewski
2018-09-26 22:07 ` [RFC/RFT PATCH v1 9/9] mtd: spi: Skip reading the Serial Flash Discoverable Parameters Lukasz Majewski
2018-09-28 16:01 ` Cyrille Pitchen
2018-09-29 20:57 ` Lukasz Majewski
2018-09-28 22:03 ` Boris Brezillon [this message]
2018-09-29 21:02 ` [RFC/RFT PATCH v1 0/9] mtd: fsl: quadspi: Fixes for fsl-quadspi.c driver (vybrid HW) Lukasz Majewski
2018-09-30 5:39 ` Boris Brezillon
2018-09-30 16:22 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180929000359.34fe18ae@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=albert.aribaud@3adev.fr \
--cc=broonie@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=david.wolfe@nxp.com \
--cc=dwmw2@infradead.org \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=frieder.schrempf@exceet.de \
--cc=han.xu@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=lukma@denx.de \
--cc=mark.rutland@arm.com \
--cc=prabhakar.kushwaha@nxp.com \
--cc=richard@nod.at \
--cc=stefan@agner.ch \
--cc=yogeshnarayan.gaur@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).