From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 013FAC43143 for ; Sat, 29 Sep 2018 00:27:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C3D12206B8 for ; Sat, 29 Sep 2018 00:27:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C3D12206B8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727421AbeI2GyK (ORCPT ); Sat, 29 Sep 2018 02:54:10 -0400 Received: from muru.com ([72.249.23.125]:57826 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726287AbeI2GyK (ORCPT ); Sat, 29 Sep 2018 02:54:10 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 8C0D880C0; Sat, 29 Sep 2018 00:32:19 +0000 (UTC) Date: Fri, 28 Sep 2018 17:27:53 -0700 From: Tony Lindgren To: Dmitry Osipenko Cc: Maciej Purski , Mark Brown , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Carlos Hernandez , Marek Szyprowski Subject: Re: [PATCH] regulator: core: Pass max_uV value to regulator_set_voltage_rdev Message-ID: <20180929002753.GT5662@atomide.com> References: <20180615112916.GK112168@atomide.com> <1529330913-11152-1-git-send-email-m.purski@samsung.com> <20180702080505.GN112168@atomide.com> <95655644-ef41-f5bd-7e8e-a257d48cd020@gmail.com> <20180928202251.GM5662@atomide.com> <2c0132ff-ea0f-f19e-ebfb-a0d077565d2c@gmail.com> <20180928224109.GS5662@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Dmitry Osipenko [180928 23:55]: > On 9/29/18 2:17 AM, Dmitry Osipenko wrote: > > On 9/29/18 1:41 AM, Tony Lindgren wrote: > >> I'm still getting these errors after init: > > > > Thank you very much again, seems I got what's wrong with your case. The ti-abb-regulator driver sets the "abb->current_info_idx = -EINVAL" on probe and that value is getting updated only after the first voltage change, hence _regulator_get_voltage() returns -22. OK that's starting to make some sense now thanks. > > Please try this patch: > > I've revised the patch and here is the current final version. Hey cool this one works now :) I suggest you rework the whole series with these fixes. I recall the series had a problem with git bisect too between the patches. It will make life easier for other people who may need to git bisect these patches. Thanks, Tony