From: kbuild test robot <lkp@intel.com>
To: Waiman Long <longman@redhat.com>
Cc: kbuild-all@01.org, Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org, Waiman Long <longman@redhat.com>
Subject: Re: [PATCH 4/5] locking/lockdep: Make class->ops a percpu counter
Date: Sat, 29 Sep 2018 04:42:00 +0800 [thread overview]
Message-ID: <201809290457.e8RfciDq%fengguang.wu@intel.com> (raw)
In-Reply-To: <1538157201-29173-5-git-send-email-longman@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 4823 bytes --]
Hi Waiman,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on tip/locking/core]
[also build test ERROR on v4.19-rc5 next-20180928]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Waiman-Long/locking-lockdep-Remove-add_chain_cache_classes/20180929-031820
config: x86_64-randconfig-u0-09290404 (attached as .config)
compiler: gcc-5 (Debian 5.5.0-3) 5.4.1 20171010
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
kernel/locking/lockdep_proc.c: In function 'l_show':
>> kernel/locking/lockdep_proc.c:71:34: error: 'struct lock_class' has no member named 'ops'
seq_printf(m, " OPS:%8ld", class->ops);
^
vim +71 kernel/locking/lockdep_proc.c
068135e63 kernel/lockdep_proc.c Jason Baron 2007-02-10 57
a8f24a397 kernel/lockdep_proc.c Ingo Molnar 2006-07-03 58 static int l_show(struct seq_file *m, void *v)
a8f24a397 kernel/lockdep_proc.c Ingo Molnar 2006-07-03 59 {
8109e1de8 kernel/lockdep_proc.c Li Zefan 2009-08-17 60 struct lock_class *class = list_entry(v, struct lock_class, lock_entry);
068135e63 kernel/lockdep_proc.c Jason Baron 2007-02-10 61 struct lock_list *entry;
f510b233c kernel/lockdep_proc.c Peter Zijlstra 2009-01-22 62 char usage[LOCK_USAGE_CHARS];
a8f24a397 kernel/lockdep_proc.c Ingo Molnar 2006-07-03 63
8109e1de8 kernel/lockdep_proc.c Li Zefan 2009-08-17 64 if (v == &all_lock_classes) {
94c61c0ae kernel/lockdep_proc.c Tim Pepper 2007-10-11 65 seq_printf(m, "all lock classes:\n");
94c61c0ae kernel/lockdep_proc.c Tim Pepper 2007-10-11 66 return 0;
94c61c0ae kernel/lockdep_proc.c Tim Pepper 2007-10-11 67 }
94c61c0ae kernel/lockdep_proc.c Tim Pepper 2007-10-11 68
a8f24a397 kernel/lockdep_proc.c Ingo Molnar 2006-07-03 69 seq_printf(m, "%p", class->key);
a8f24a397 kernel/lockdep_proc.c Ingo Molnar 2006-07-03 70 #ifdef CONFIG_DEBUG_LOCKDEP
a8f24a397 kernel/lockdep_proc.c Ingo Molnar 2006-07-03 @71 seq_printf(m, " OPS:%8ld", class->ops);
a8f24a397 kernel/lockdep_proc.c Ingo Molnar 2006-07-03 72 #endif
df60a8441 kernel/lockdep_proc.c Stephen Hemminger 2008-08-15 73 #ifdef CONFIG_PROVE_LOCKING
df60a8441 kernel/lockdep_proc.c Stephen Hemminger 2008-08-15 74 seq_printf(m, " FD:%5ld", lockdep_count_forward_deps(class));
df60a8441 kernel/lockdep_proc.c Stephen Hemminger 2008-08-15 75 seq_printf(m, " BD:%5ld", lockdep_count_backward_deps(class));
df60a8441 kernel/lockdep_proc.c Stephen Hemminger 2008-08-15 76 #endif
a8f24a397 kernel/lockdep_proc.c Ingo Molnar 2006-07-03 77
f510b233c kernel/lockdep_proc.c Peter Zijlstra 2009-01-22 78 get_usage_chars(class, usage);
f510b233c kernel/lockdep_proc.c Peter Zijlstra 2009-01-22 79 seq_printf(m, " %s", usage);
a8f24a397 kernel/lockdep_proc.c Ingo Molnar 2006-07-03 80
068135e63 kernel/lockdep_proc.c Jason Baron 2007-02-10 81 seq_printf(m, ": ");
068135e63 kernel/lockdep_proc.c Jason Baron 2007-02-10 82 print_name(m, class);
068135e63 kernel/lockdep_proc.c Jason Baron 2007-02-10 83 seq_puts(m, "\n");
068135e63 kernel/lockdep_proc.c Jason Baron 2007-02-10 84
068135e63 kernel/lockdep_proc.c Jason Baron 2007-02-10 85 list_for_each_entry(entry, &class->locks_after, entry) {
068135e63 kernel/lockdep_proc.c Jason Baron 2007-02-10 86 if (entry->distance == 1) {
2429e4ee7 kernel/lockdep_proc.c Huang, Ying 2008-06-13 87 seq_printf(m, " -> [%p] ", entry->class->key);
068135e63 kernel/lockdep_proc.c Jason Baron 2007-02-10 88 print_name(m, entry->class);
068135e63 kernel/lockdep_proc.c Jason Baron 2007-02-10 89 seq_puts(m, "\n");
068135e63 kernel/lockdep_proc.c Jason Baron 2007-02-10 90 }
a8f24a397 kernel/lockdep_proc.c Ingo Molnar 2006-07-03 91 }
a8f24a397 kernel/lockdep_proc.c Ingo Molnar 2006-07-03 92 seq_puts(m, "\n");
a8f24a397 kernel/lockdep_proc.c Ingo Molnar 2006-07-03 93
a8f24a397 kernel/lockdep_proc.c Ingo Molnar 2006-07-03 94 return 0;
a8f24a397 kernel/lockdep_proc.c Ingo Molnar 2006-07-03 95 }
a8f24a397 kernel/lockdep_proc.c Ingo Molnar 2006-07-03 96
:::::: The code at line 71 was first introduced by commit
:::::: a8f24a3978c5f82419e1c90dc90460731204f46f [PATCH] lockdep: procfs
:::::: TO: Ingo Molnar <mingo@elte.hu>
:::::: CC: Linus Torvalds <torvalds@g5.osdl.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 30896 bytes --]
next prev parent reply other threads:[~2018-09-28 20:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 17:53 [PATCH 0/5] locking/lockdep: Improve lockdep performance Waiman Long
2018-09-28 17:53 ` [PATCH 1/5] locking/lockdep: Remove add_chain_cache_classes() Waiman Long
2018-09-28 17:53 ` [PATCH 2/5] locking/lockdep: Eliminate redundant irqs check in __lock_acquire() Waiman Long
2018-10-02 9:06 ` Ingo Molnar
2018-09-28 17:53 ` [PATCH 3/5] locking/lockdep: Add a faster path in __lock_release() Waiman Long
2018-10-02 9:03 ` Ingo Molnar
2018-09-28 17:53 ` [PATCH 4/5] locking/lockdep: Make class->ops a percpu counter Waiman Long
2018-09-28 20:25 ` kbuild test robot
2018-09-28 20:31 ` Waiman Long
2018-09-28 20:42 ` kbuild test robot [this message]
2018-10-02 9:39 ` Peter Zijlstra
2018-10-02 9:55 ` Ingo Molnar
2018-10-02 14:10 ` Waiman Long
2018-10-02 14:28 ` Peter Zijlstra
2018-10-02 18:53 ` Ingo Molnar
2018-09-28 17:53 ` [PATCH 5/5] locking/lockdep: Call lock_release after releasing the lock Waiman Long
2018-10-02 9:08 ` Ingo Molnar
2018-10-02 9:06 ` [PATCH 0/5] locking/lockdep: Improve lockdep performance Ingo Molnar
2018-10-02 13:57 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201809290457.e8RfciDq%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).