From: Jonathan Cameron <jic23@kernel.org>
To: Song Qiang <songqiang1304521@gmail.com>
Cc: Rob Herring <robh@kernel.org>, Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Mark Rutland <mark.rutland@arm.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Matt Ranostay <matt.ranostay@konsulko.com>,
Thomas Gleixner <tglx@linutronix.de>,
Andreas Klinger <ak@it-klinger.de>,
linux-iio@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v6 2/2] iio: proximity: vl53l0x: add interrupt support
Date: Mon, 1 Oct 2018 19:44:46 +0100 [thread overview]
Message-ID: <20181001194446.2b613a69@archlinux> (raw)
In-Reply-To: <20181001035739.GA17143@Eros>
On Mon, 1 Oct 2018 11:58:14 +0800
Song Qiang <songqiang1304521@gmail.com> wrote:
> On Fri, Sep 28, 2018 at 06:52:13PM -0500, Rob Herring wrote:
> > On Fri, Sep 28, 2018 at 4:36 AM Song Qiang <songqiang1304521@gmail.com> wrote:
> > >
> > > On Wed, Sep 26, 2018 at 05:46:18PM -0500, Rob Herring wrote:
> > > > On Sat, Sep 22, 2018 at 04:05:23PM +0100, Jonathan Cameron wrote:
> > > > > On Tue, 18 Sep 2018 16:24:22 +0800
> > > > > Song Qiang <songqiang1304521@gmail.com> wrote:
> > > > >
> > > > > > The first version of this driver issues a measuring request and polling
> > > > > > for a status register in the device for measuring completes.
> > > > > > vl53l0x support configuring GPIO1 on it to generate interrupt to
> > > > > > indicate that new measurement is ready. This patch adds support for
> > > > > > using this mechanisim to reduce cpu cost.
> > > > > >
> > > > > > Signed-off-by: Song Qiang <songqiang1304521@gmail.com>
> > > > > Hi Song.
> > > > >
> > > > > Looks correct in principal but a few things to tidy up before
> > > > > this is ready to apply.
> > > > >
> > > > > Also we have an unrelated change in here to check the devices ID.
> > > > > That should be in it's own patch.
> > > > >
> > > > > Thanks,
> > > > >
> > > > > Jonathan
> > > > > > ---
> > > > > > .../bindings/iio/proximity/vl53l0x.txt | 14 +-
> > > >
> > > > This should have been split with the complete binding in one patch
> > > > rather than piecemeal driver feature by feature.
> > > >
> > >
> > > Hi Rob,
> > >
> > > A few days ago when I was submitting this driver, I didn't do it very
> > > well, the function of this driver is limited. I added interrupt support
> > > the next day after you acked my first patch. I thought it's not polite
> > > to add something after someone acked that patch, so I send the interrupt
> > > support as a second patch. The first patch is merged to togreg now, but
> > > this doesn't. I don't know when can I add new functions to the code that
> > > just merged to togreg branch, could you offer some suggestions?
> >
> > You just needed to state why you didn't add a ack. But really, just
> > don't send things except as RFC until they are "done".
> >
> > What to do next depends on Jonathan and whether he wants a follow-up
> > patch or he will drop the first one.
> >
> > > > > > drivers/iio/proximity/vl53l0x-i2c.c | 135 +++++++++++++++---
> > > > > > 2 files changed, 129 insertions(+), 20 deletions(-)
> > > > > >
> > > > > > diff --git a/Documentation/devicetree/bindings/iio/proximity/vl53l0x.txt b/Documentation/devicetree/bindings/iio/proximity/vl53l0x.txt
> > > > > > index ab9a9539fec4..40290f8dd70f 100644
> > > > > > --- a/Documentation/devicetree/bindings/iio/proximity/vl53l0x.txt
> > > > > > +++ b/Documentation/devicetree/bindings/iio/proximity/vl53l0x.txt
> > > > > > @@ -4,9 +4,21 @@ Required properties:
> > > > > > - compatible: must be "st,vl53l0x-i2c"
> > > >
> > > > Is there more than one interface on this device, such as SPI? If not,
> > > > then '-i2c' should be dropped.
> > > >
> > >
> > > Yes, there is a CCI(Camera Control Interface) for communication.
> >
> > Isn't CCI just a subset of I2C? I should clarify my question is
> > whether there's more than 1 mutually exclusive control interface (as
> > many devices have control and data interfaces) where you could have 2
> > different drivers. A common example are devices with I2C and SPI
> > interfaces.
> >
> > Rob
>
> Hi Rob, Jonathan,
>
> I don't know things about CCI very well, and google also tells me little
> about it. Actually, I found it difficult to find a standard definition
> about it. Then I dug into vl53l0x's API source code, and what I can
> tell is when we use these two interfaces, the whole programming
> framework is different, even though the pysical bus of them are likely
> to be the same.
> Source code of CCI uses a 'msm_camera_i2c_fn_t' struct and a
> 'v4l2_file_operations' as hardware interfaces for controlling device,
> while the i2c one just uses generic i2c bus interfaces.
>
> This explanation is for why the file name still contains '-i2c'.
>
File names are easy to change in future compared to device tree bindings
(which may be fixed for ever in an embedded platform).
So this isn't a problem at all.
Thanks,
Jonathan
> yours,
> Song Qiang
next prev parent reply other threads:[~2018-10-01 18:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 8:24 [PATCH v6 1/2] iio: proximity: Add driver support for ST's VL53L0X ToF ranging sensor Song Qiang
2018-09-18 8:24 ` [PATCH v6 2/2] iio: proximity: vl53l0x: add interrupt support Song Qiang
2018-09-22 15:05 ` Jonathan Cameron
2018-09-26 22:46 ` Rob Herring
2018-09-28 9:36 ` Song Qiang
2018-09-28 23:52 ` Rob Herring
2018-09-29 11:10 ` Jonathan Cameron
2018-09-29 23:49 ` Rob Herring
2018-09-30 15:20 ` Jonathan Cameron
2018-10-01 3:58 ` Song Qiang
2018-10-01 18:44 ` Jonathan Cameron [this message]
2018-09-19 18:58 ` [PATCH v6 1/2] iio: proximity: Add driver support for ST's VL53L0X ToF ranging sensor Sasha Levin
2018-09-20 8:41 ` Jonathan Cameron
2018-09-21 14:56 ` Sasha Levin
2018-09-22 14:46 ` Jonathan Cameron
2018-09-22 14:56 ` Himanshu Jha
2018-09-22 15:12 ` Jonathan Cameron
2018-09-22 15:28 ` Song Qiang
2018-09-22 15:44 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181001194446.2b613a69@archlinux \
--to=jic23@kernel.org \
--cc=ak@it-klinger.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matt.ranostay@konsulko.com \
--cc=pmeerw@pmeerw.net \
--cc=robh@kernel.org \
--cc=songqiang1304521@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).