* [PATCH] dpaa_eth: Remove useless declaration
@ 2018-10-01 4:10 Nathan Chancellor
2018-10-01 7:11 ` Madalin-cristian Bucur
2018-10-03 5:31 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Nathan Chancellor @ 2018-10-01 4:10 UTC (permalink / raw)
To: Madalin Bucur, David S. Miller; +Cc: netdev, linux-kernel, Nathan Chancellor
Clang warns:
drivers/net/ethernet/freescale/dpaa/dpaa_eth.c:2734:34: warning:
tentative array definition assumed to have one element
static const struct of_device_id dpaa_match[];
^
1 warning generated.
Turns out that since this driver was introduced in commit 9ad1a3749333
("dpaa_eth: add support for DPAA Ethernet"), this declaration has been
unused. Remove it to silence the warning.
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
index 84843de25c7b..6e0f47f2c8a3 100644
--- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
+++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
@@ -2731,8 +2731,6 @@ static int dpaa_ingress_cgr_init(struct dpaa_priv *priv)
return err;
}
-static const struct of_device_id dpaa_match[];
-
static inline u16 dpaa_get_headroom(struct dpaa_buffer_layout *bl)
{
u16 headroom;
--
2.19.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] dpaa_eth: Remove useless declaration
2018-10-01 4:10 [PATCH] dpaa_eth: Remove useless declaration Nathan Chancellor
@ 2018-10-01 7:11 ` Madalin-cristian Bucur
2018-10-03 5:31 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Madalin-cristian Bucur @ 2018-10-01 7:11 UTC (permalink / raw)
To: Nathan Chancellor, David S. Miller; +Cc: netdev, linux-kernel
> -----Original Message-----
> From: Nathan Chancellor [mailto:natechancellor@gmail.com]
> Sent: Monday, October 1, 2018 7:10 AM
> To: Madalin-cristian Bucur <madalin.bucur@nxp.com>; David S. Miller
> <davem@davemloft.net>
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Nathan
> Chancellor <natechancellor@gmail.com>
> Subject: [PATCH] dpaa_eth: Remove useless declaration
>
> Clang warns:
>
> drivers/net/ethernet/freescale/dpaa/dpaa_eth.c:2734:34: warning:
> tentative array definition assumed to have one element
> static const struct of_device_id dpaa_match[];
> ^
> 1 warning generated.
>
> Turns out that since this driver was introduced in commit 9ad1a3749333
> ("dpaa_eth: add support for DPAA Ethernet"), this declaration has been
> unused. Remove it to silence the warning.
>
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
> drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> index 84843de25c7b..6e0f47f2c8a3 100644
> --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> @@ -2731,8 +2731,6 @@ static int dpaa_ingress_cgr_init(struct dpaa_priv
> *priv)
> return err;
> }
>
> -static const struct of_device_id dpaa_match[];
> -
> static inline u16 dpaa_get_headroom(struct dpaa_buffer_layout *bl)
> {
> u16 headroom;
> --
> 2.19.0
Acked-by: Madalin Bucur <madalin.bucur@nxp.com>
Thank you
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dpaa_eth: Remove useless declaration
2018-10-01 4:10 [PATCH] dpaa_eth: Remove useless declaration Nathan Chancellor
2018-10-01 7:11 ` Madalin-cristian Bucur
@ 2018-10-03 5:31 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-10-03 5:31 UTC (permalink / raw)
To: natechancellor; +Cc: madalin.bucur, netdev, linux-kernel
From: Nathan Chancellor <natechancellor@gmail.com>
Date: Sun, 30 Sep 2018 21:10:29 -0700
> Clang warns:
>
> drivers/net/ethernet/freescale/dpaa/dpaa_eth.c:2734:34: warning:
> tentative array definition assumed to have one element
> static const struct of_device_id dpaa_match[];
> ^
> 1 warning generated.
>
> Turns out that since this driver was introduced in commit 9ad1a3749333
> ("dpaa_eth: add support for DPAA Ethernet"), this declaration has been
> unused. Remove it to silence the warning.
>
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Applied to net-next.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-03 5:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-01 4:10 [PATCH] dpaa_eth: Remove useless declaration Nathan Chancellor
2018-10-01 7:11 ` Madalin-cristian Bucur
2018-10-03 5:31 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).