From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CF21C43143 for ; Tue, 2 Oct 2018 03:15:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 049CC20652 for ; Tue, 2 Oct 2018 03:15:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 049CC20652 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gondor.apana.org.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726746AbeJBJ4s (ORCPT ); Tue, 2 Oct 2018 05:56:48 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:49602 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726239AbeJBJ4s (ORCPT ); Tue, 2 Oct 2018 05:56:48 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1g7BA3-0004wA-Sr; Tue, 02 Oct 2018 11:15:47 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1g7B9y-0002H9-UD; Tue, 02 Oct 2018 11:15:42 +0800 Date: Tue, 2 Oct 2018 11:15:42 +0800 From: Herbert Xu To: "Jason A. Donenfeld" Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-crypto@vger.kernel.org, davem@davemloft.net, gregkh@linuxfoundation.org, Jason@zx2c4.com, sneves@dei.uc.pt, luto@kernel.org, jeanphilippe.aumasson@gmail.com Subject: Re: [PATCH net-next v6 03/23] zinc: ChaCha20 generic C implementation and selftest Message-ID: <20181002031542.dbxu44gvqrughlgw@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180925145622.29959-4-Jason@zx2c4.com> X-Newsgroups: apana.lists.os.linux.cryptoapi,apana.lists.os.linux.kernel,apana.lists.os.linux.netdev Organization: Core User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jason A. Donenfeld wrote: > This implements the ChaCha20 permutation as a single C statement, by way > of the comma operator, which the compiler is able to simplify > terrifically. > > Information: https://cr.yp.to/chacha.html > > Signed-off-by: Jason A. Donenfeld > Cc: Samuel Neves > Cc: Andy Lutomirski > Cc: Greg KH > Cc: Jean-Philippe Aumasson I don't have any problems with this interface. However, I'm very unhappy about the fact that this adds another copy of the chacha20 implementation to the kernel. Either this is better than the one that we already have or it isn't. So if it's better please replace the existing chacha20 C implementation with this or otherwise just adapt the existing implementation to this interface. If we're replacing the existing one then you can either replace it directly within this patch or in a subsequent patch but please do it in the same series because otherwise we could wind up with two implementations for years to come. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt