From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E52DC43143 for ; Tue, 2 Oct 2018 09:11:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C8EFA2064E for ; Tue, 2 Oct 2018 09:11:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C8EFA2064E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726243AbeJBPxP (ORCPT ); Tue, 2 Oct 2018 11:53:15 -0400 Received: from mga06.intel.com ([134.134.136.31]:63555 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725994AbeJBPxP (ORCPT ); Tue, 2 Oct 2018 11:53:15 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Oct 2018 02:11:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,331,1534834800"; d="scan'208";a="262151428" Received: from shbuild888.sh.intel.com (HELO localhost) ([10.239.146.239]) by orsmga005.jf.intel.com with ESMTP; 02 Oct 2018 02:10:58 -0700 Date: Tue, 2 Oct 2018 17:16:27 +0800 From: Feng Tang To: Borislav Petkov Cc: Thomas Gleixner , Ingo Molnar , H Peter Anvin , Peter Zijlstra , "Stuart R . Anderson" , alan@linux.intel.com, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] x86/earlyprintk: Add a force option for pciserial device Message-ID: <20181002091627.3vm6ow4y7me2uju3@shbuild888> References: <20180928094008.23138-1-feng.tang@intel.com> <20180929163458.GA25608@zn.tnic> <20180930131619.jecqh4umrkmifavb@shbuild888> <20181001123916.GC7269@zn.tnic> <20181001141810.fbo3amfqnr5243mc@shbuild888> <20181001203004.GG7269@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181001203004.GG7269@zn.tnic> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Boris, On Mon, Oct 01, 2018 at 10:30:04PM +0200, Borislav Petkov wrote: > On Mon, Oct 01, 2018 at 10:18:10PM +0800, Feng Tang wrote: > > As I rechecked, the baud rate for pciserial is optional, so there may > > be no ",baudrate" following the "force". So this 2 strncmp is to > > cover conditions for with and without baudrate. > > And what guarantees you have a space after the "force"? > > !strncmp(s, "force ", 6) > ^ You are right, it can't be guranteed. Can we still use strncmp(s, "force", 5) and rely on developer to set it right? any suggestions? thanks, - Feng