From: Sudeep Holla <sudeep.holla@arm.com>
To: Jeffrey Hugo <jhugo@codeaurora.org>
Cc: gregkh@linuxfoundation.org, rjw@rjwysocki.net,
linux-acpi@vger.kernel.org, jeremy.linton@arm.com,
linux-kernel@vger.kernel.org, vkilari@codeaurora.org
Subject: Re: [PATCH v3 1/2] drivers: base: cacheinfo: Do not populate sysfs for unknown cache types
Date: Tue, 2 Oct 2018 11:49:46 +0100 [thread overview]
Message-ID: <20181002104946.GA1086@e107155-lin> (raw)
In-Reply-To: <1538103477-15513-2-git-send-email-jhugo@codeaurora.org>
On Thu, Sep 27, 2018 at 08:57:56PM -0600, Jeffrey Hugo wrote:
> If a cache has an unknown type because neither the hardware nor the
> firmware told us, an entry in the sysfs tree will be made, but the type
> file will not be present. lscpu depends on the type file being present
> for every entry, and will error out without printing system information
> if lscpu cannot open the type file.
>
> Presenting information about a cache without indicating its type is not
> useful, therefore if we hit a cache with an unknown type, stop populating
> sysfs so that userspace has the maximum amount of useful information.
>
> This addresses the following lscpu error, which prevents any output.
> lscpu: cannot open /sys/devices/system/cpu/cpu0/cache/index3/type: No such
> file or directory
>
> Suggested-by: Sudeep Holla <sudeep.holla@arm.com>
> Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
> Reviewed-by: Jeremy Linton <jeremy.linton@arm.com>
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
--
Regards,
Sudeep
next prev parent reply other threads:[~2018-10-02 10:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 2:57 [PATCH v3 0/2] PPTT handle Handle architecturally unknown cache types Jeffrey Hugo
2018-09-28 2:57 ` [PATCH v3 1/2] drivers: base: cacheinfo: Do not populate sysfs for " Jeffrey Hugo
2018-10-02 10:49 ` Sudeep Holla [this message]
2018-10-03 9:35 ` Rafael J. Wysocki
2018-10-03 13:47 ` Jeffrey Hugo
2018-09-28 2:57 ` [PATCH v3 2/2] ACPI/PPTT: Handle architecturally " Jeffrey Hugo
2018-09-28 21:52 ` Jeremy Linton
2018-10-02 10:57 ` Sudeep Holla
2018-10-02 15:30 ` Jeffrey Hugo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181002104946.GA1086@e107155-lin \
--to=sudeep.holla@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jeremy.linton@arm.com \
--cc=jhugo@codeaurora.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=vkilari@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).