From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACC2DC43143 for ; Tue, 2 Oct 2018 10:57:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 73198205C9 for ; Tue, 2 Oct 2018 10:57:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 73198205C9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727561AbeJBRju (ORCPT ); Tue, 2 Oct 2018 13:39:50 -0400 Received: from foss.arm.com ([217.140.101.70]:34368 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726244AbeJBRju (ORCPT ); Tue, 2 Oct 2018 13:39:50 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5A7BC7A9; Tue, 2 Oct 2018 03:57:09 -0700 (PDT) Received: from e107155-lin (e107155-lin.emea.arm.com [10.4.12.116]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C75853F5B7; Tue, 2 Oct 2018 03:57:07 -0700 (PDT) Date: Tue, 2 Oct 2018 11:57:05 +0100 From: Sudeep Holla To: Jeffrey Hugo Cc: gregkh@linuxfoundation.org, rjw@rjwysocki.net, linux-acpi@vger.kernel.org, jeremy.linton@arm.com, linux-kernel@vger.kernel.org, vkilari@codeaurora.org, Sudeep Holla Subject: Re: [PATCH v3 2/2] ACPI/PPTT: Handle architecturally unknown cache types Message-ID: <20181002105705.GB1086@e107155-lin> References: <1538103477-15513-1-git-send-email-jhugo@codeaurora.org> <1538103477-15513-3-git-send-email-jhugo@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1538103477-15513-3-git-send-email-jhugo@codeaurora.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 27, 2018 at 08:57:57PM -0600, Jeffrey Hugo wrote: > The type of a cache might not be specified by architectural mechanisms (ie > system registers), but its type might be specified in the PPTT. In this > case, we should populate the type of the cache, rather than leave it > undefined. > > This fixes the issue where the cacheinfo driver will not populate sysfs > for such caches, resulting in the information missing from utilities like > lstopo and lscpu, thus degrading the user experience. > > Fixes: 2bd00bcd73e5 (ACPI/PPTT: Add Processor Properties Topology Table parsing) > Reported-by: Vijaya Kumar K > Signed-off-by: Jeffrey Hugo > --- > drivers/acpi/pptt.c | 30 +++++++++++++----------------- > 1 file changed, 13 insertions(+), 17 deletions(-) > > diff --git a/drivers/acpi/pptt.c b/drivers/acpi/pptt.c > index d1e26cb..38ac30e 100644 > --- a/drivers/acpi/pptt.c > +++ b/drivers/acpi/pptt.c > @@ -357,25 +357,15 @@ static void update_cache_properties(struct cacheinfo *this_leaf, > struct acpi_pptt_cache *found_cache, > struct acpi_pptt_processor *cpu_node) > { > - int valid_flags = 0; > - > this_leaf->fw_token = cpu_node; > - if (found_cache->flags & ACPI_PPTT_SIZE_PROPERTY_VALID) { > + if (found_cache->flags & ACPI_PPTT_SIZE_PROPERTY_VALID) > this_leaf->size = found_cache->size; > - valid_flags++; > - } > - if (found_cache->flags & ACPI_PPTT_LINE_SIZE_VALID) { > + if (found_cache->flags & ACPI_PPTT_LINE_SIZE_VALID) > this_leaf->coherency_line_size = found_cache->line_size; > - valid_flags++; > - } > - if (found_cache->flags & ACPI_PPTT_NUMBER_OF_SETS_VALID) { > + if (found_cache->flags & ACPI_PPTT_NUMBER_OF_SETS_VALID) > this_leaf->number_of_sets = found_cache->number_of_sets; > - valid_flags++; > - } > - if (found_cache->flags & ACPI_PPTT_ASSOCIATIVITY_VALID) { > + if (found_cache->flags & ACPI_PPTT_ASSOCIATIVITY_VALID) > this_leaf->ways_of_associativity = found_cache->associativity; > - valid_flags++; > - } > if (found_cache->flags & ACPI_PPTT_WRITE_POLICY_VALID) { > switch (found_cache->attributes & ACPI_PPTT_MASK_WRITE_POLICY) { > case ACPI_PPTT_CACHE_POLICY_WT: > @@ -402,11 +392,17 @@ static void update_cache_properties(struct cacheinfo *this_leaf, > } > } > /* > - * If the above flags are valid, and the cache type is NOCACHE > - * update the cache type as well. > + * If cache type is NOCACHE, then the cache hasn't been specified > + * via other mechanisms. Update the type if a cache type has been > + * provided. > + * > + * Note, we assume such caches are unified based on conventional system > + * design and known examples. Significant work is required elsewhere to > + * fully support data/instruction only type caches which are only > + * specified in PPTT. > */ > if (this_leaf->type == CACHE_TYPE_NOCACHE && > - valid_flags == PPTT_CHECKED_ATTRIBUTES) I don't think we use PPTT_CHECKED_ATTRIBUTES elsewhere. If so, can we drop that ? Other than that: Reviewed-by: Sudeep Holla -- Regards, Sudeep