From: Matthew Wilcox <willy@infradead.org>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] drm/virtio: Use IDAs more efficiently
Date: Tue, 2 Oct 2018 05:55:37 -0700 [thread overview]
Message-ID: <20181002125537.GA15740@bombadil.infradead.org> (raw)
In-Reply-To: <20181002114328.kltyrjlojzrhzwgl@sirius.home.kraxel.org>
On Tue, Oct 02, 2018 at 01:43:28PM +0200, Gerd Hoffmann wrote:
> On Wed, Sep 26, 2018 at 09:04:55AM -0700, Matthew Wilcox wrote:
> > On Wed, Sep 26, 2018 at 09:00:31AM -0700, Matthew Wilcox wrote:
> > > @@ -59,6 +59,7 @@ static int virtio_gpu_context_create(struct virtio_gpu_device *vgdev,
> > >
> > > if (handle < 0)
> > > return handle;
> > > + handle++;
> > > virtio_gpu_cmd_context_create(vgdev, handle, nlen, name);
> > > return handle;
> > > }
> >
> > Uh. This line is missing.
> >
> > - int handle = ida_alloc_min(&vgdev->ctx_id_ida, 1, GFP_KERNEL);
> > + int handle = ida_alloc(&vgdev->ctx_id_ida, GFP_KERNEL);
> >
> > It'll be there in v2 ;-)
>
> I've touched the resource/object id handling too, see my "drm/virtio:
> rework ttm resource handling" patch series
> (https://patchwork.freedesktop.org/series/50382/). Which still needs a
> review btw.
Um, according to patchwork, you only posted it yesterday. Does DRM
normally expect a review within 24 hours?
> I think that series obsoletes patch 3/4 (object id fixes) of your
> series. The other patches should rebase without too much trouble, you
> could do that as well when preparing v2 ...
It seems a little odd to me to expect a drive-by contributor (ie me) to
rebase their patches on top of a patch series which wasn't even posted
at the time they contributed their original patch. If it was already
in -next, that'd be a reasonable request.
next prev parent reply other threads:[~2018-10-02 12:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 16:00 [PATCH 0/4] Improve virtio ID allocation Matthew Wilcox
2018-09-26 16:00 ` [PATCH 1/4] drm/virtio: Replace IDRs with IDAs Matthew Wilcox
2018-09-26 16:00 ` [PATCH 2/4] drm/virtio: Handle context ID allocation errors Matthew Wilcox
2018-09-26 16:00 ` [PATCH 3/4] drm/virtio: Handle object " Matthew Wilcox
2018-09-26 16:00 ` [PATCH 4/4] drm/virtio: Use IDAs more efficiently Matthew Wilcox
2018-09-26 16:04 ` Matthew Wilcox
2018-10-02 11:43 ` Gerd Hoffmann
2018-10-02 12:55 ` Matthew Wilcox [this message]
2018-10-29 21:53 ` [PATCH 0/4] Improve virtio ID allocation Gerd Hoffmann
2018-10-30 16:52 ` Matthew Wilcox
2018-10-30 16:53 ` [PATCH v2 1/2] drm/virtio: Handle error from virtio_gpu_resource_id_get Matthew Wilcox
2018-10-30 16:53 ` [PATCH v2 2/2] drm/virtio: Use IDAs more efficiently Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181002125537.GA15740@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).