From: Christoph Hellwig <hch@infradead.org>
To: Zong Li <zongbox@gmail.com>
Cc: palmer@sifive.com, aou@eecs.berkeley.edu, hch@infradead.org,
zong@andestech.com, linux-riscv@lists.infradead.org,
Vincent Chen <vincentc@andestech.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 5/5] RISC-V: Avoid corrupting the upper 32-bit of phys_addr_t in ioremap
Date: Tue, 2 Oct 2018 07:51:16 -0700 [thread overview]
Message-ID: <20181002145116.GE3889@infradead.org> (raw)
In-Reply-To: <54849b9d9a709525640011814872155eafa7a9d7.1538470103.git.zongbox@gmail.com>
On Tue, Oct 02, 2018 at 04:52:31PM +0800, Zong Li wrote:
> From: Vincent Chen <vincentc@andestech.com>
>
> For 32bit, the upper 32-bit of phys_addr_t will be flushed to zero
> after AND with PAGE_MASK because the data type of PAGE_MASK is
> unsigned long. To fix this problem, the page alignment is done by
> subtracting the page offset instead of AND with PAGE_MASK.
>
> Signed-off-by: Vincent Chen <vincentc@andestech.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
(and I'm pretty sure I reviewed this before..)
next prev parent reply other threads:[~2018-10-02 14:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1538470103.git.zongbox@gmail.com>
2018-10-02 8:52 ` [PATCH v3 1/5] RISC-V: Build tishift only on 64-bit Zong Li
2018-10-02 14:47 ` Christoph Hellwig
2018-10-02 8:52 ` [PATCH v3 2/5] RISC-V: Use swiotlb on RV64 only Zong Li
2018-10-02 14:47 ` Christoph Hellwig
2018-10-02 8:52 ` [PATCH v3 3/5] lib: Add umoddi3 and udivmoddi4 of GCC library routines Zong Li
2018-10-02 14:50 ` Christoph Hellwig
2018-10-02 15:02 ` Palmer Dabbelt
2018-10-03 1:39 ` Zong Li
2018-10-02 8:52 ` [PATCH v3 4/5] RISC-V: Select GENERIC_LIB_UMODDI3 on RV32 Zong Li
2018-10-02 14:50 ` Christoph Hellwig
2018-10-02 8:52 ` [PATCH v3 5/5] RISC-V: Avoid corrupting the upper 32-bit of phys_addr_t in ioremap Zong Li
2018-10-02 14:51 ` Christoph Hellwig [this message]
2018-10-03 3:26 ` Zong Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181002145116.GE3889@infradead.org \
--to=hch@infradead.org \
--cc=aou@eecs.berkeley.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=vincentc@andestech.com \
--cc=zong@andestech.com \
--cc=zongbox@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).