From: Oscar Salvador <osalvador@techadventures.net>
To: linux-mm@kvack.org
Cc: mhocko@suse.com, dan.j.williams@intel.com,
yasu.isimatu@gmail.com, rppt@linux.vnet.ibm.com,
malat@debian.org, linux-kernel@vger.kernel.org,
pavel.tatashin@microsoft.com, jglisse@redhat.com,
Jonathan.Cameron@huawei.com, rafael@kernel.org, david@redhat.com,
dave.jiang@intel.com, Oscar Salvador <osalvador@suse.de>
Subject: [RFC PATCH v3 3/5] mm/memory_hotplug: Check for IORESOURCE_SYSRAM in release_mem_region_adjustable
Date: Tue, 2 Oct 2018 17:00:27 +0200 [thread overview]
Message-ID: <20181002150029.23461-4-osalvador@techadventures.net> (raw)
In-Reply-To: <20181002150029.23461-1-osalvador@techadventures.net>
From: Oscar Salvador <osalvador@suse.de>
This is a preparation for the next patch.
Currently, we only call release_mem_region_adjustable() in __remove_pages
if the zone is not ZONE_DEVICE, because resources that belong to
HMM/devm are being released by themselves with devm_release_mem_region.
Since we do not want to touch any zone/page stuff during the removing
of the memory (but during the offlining), we do not want to check for
the zone here.
So we need another way to tell release_mem_region_adjustable() to not realease
the resource in case it belongs to HMM/devm.
HMM/devm acquires/releases a resource through
devm_request_mem_region/devm_release_mem_region.
These resources have the flag IORESOURCE_MEM, while resources acquired by
hot-add memory path (register_memory_resource()) contain
IORESOURCE_SYSTEM_RAM.
So, we can check for this flag in release_mem_region_adjustable, and if the
resource does not contain such flag, we know that we are dealing with a HMM/devm
resource, so we can back off.
Signed-off-by: Oscar Salvador <osalvador@suse.de>
---
kernel/resource.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/kernel/resource.c b/kernel/resource.c
index 81937830a42f..6956ce3a4730 100644
--- a/kernel/resource.c
+++ b/kernel/resource.c
@@ -1272,6 +1272,21 @@ int release_mem_region_adjustable(struct resource *parent,
continue;
}
+ /*
+ * All memory regions added from memory-hotplug path
+ * have the flag IORESOURCE_SYSTEM_RAM.
+ * If the resource does not have this flag, we know that
+ * we are dealing with a resource coming from HMM/devm.
+ * HMM/devm use another mechanism to add/release a resource.
+ * This goes via devm_request_mem_region/devm_release_mem_region.
+ * HMM/devm take care to release their resources when they want, so
+ * if we are dealing with them, let us just back off here.
+ */
+ if (!(res->flags & IORESOURCE_SYSRAM)) {
+ ret = 0;
+ break;
+ }
+
if (!(res->flags & IORESOURCE_MEM))
break;
--
2.13.6
next prev parent reply other threads:[~2018-10-02 15:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 15:00 [RFC PATCH v3 0/5] Do not touch pages/zones during hot-remove path Oscar Salvador
2018-10-02 15:00 ` [RFC PATCH v3 1/5] mm/memory_hotplug: Add nid parameter to arch_remove_memory Oscar Salvador
2018-10-04 9:52 ` David Hildenbrand
2018-10-02 15:00 ` [RFC PATCH v3 2/5] mm/memory_hotplug: Create add/del_device_memory functions Oscar Salvador
2018-10-02 15:00 ` Oscar Salvador [this message]
2018-10-02 15:00 ` [RFC PATCH v3 4/5] mm/memory_hotplug: Move zone/pages handling to offline stage Oscar Salvador
2018-10-02 15:00 ` [RFC PATCH v3 5/5] mm/memory-hotplug: Rework unregister_mem_sect_under_nodes Oscar Salvador
2018-10-08 13:56 ` [RFC PATCH v3 0/5] Do not touch pages/zones during hot-remove path Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181002150029.23461-4-osalvador@techadventures.net \
--to=osalvador@techadventures.net \
--cc=Jonathan.Cameron@huawei.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=david@redhat.com \
--cc=jglisse@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=malat@debian.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=pavel.tatashin@microsoft.com \
--cc=rafael@kernel.org \
--cc=rppt@linux.vnet.ibm.com \
--cc=yasu.isimatu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).