linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org,
	Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [ftrace/kprobes PATCH 3/3] tracing/kprobes: Allow kprobe-events to record module symbol
Date: Wed, 3 Oct 2018 15:12:27 -0400	[thread overview]
Message-ID: <20181003151227.4a730dcb@gandalf.local.home> (raw)
In-Reply-To: <153547312336.26502.11432902826345374463.stgit@devbox>

On Wed, 29 Aug 2018 01:18:43 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:

> Allow kprobe-events to record module symbols.
> 
> Since data symbols in a non-loaded module doesn't exist, it fails to
> define such symbol as an argument of kprobe-event. But if the kprobe
> event is defined on that module, we can defer to resolve the symbol
> address.
> 
> Note that if given symbol is not found, the event is kept unavailable.
> User can enable it but the event is not recorded.
> 
>

Hi Masami,

The first two patches look like they should be applied now and marked
for stable, as they are fixes. This patch looks like an added feature,
and will go into the next merge window.

Is that what you think too?

Thanks!

-- Steve

  reply	other threads:[~2018-10-03 19:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-28 16:17 [ftrace/kprobes PATCH 0/3] tracing: probeevent: Fix module symbol probing Masami Hiramatsu
2018-08-28 16:17 ` [ftrace/kprobes PATCH 1/3] tracing/uprobes: Fix to return -EFAULT if copy_from_user failed Masami Hiramatsu
2018-08-28 16:18 ` [ftrace/kprobes PATCH 2/3] tracing/kprobes: Check the probe on unloaded module correctly Masami Hiramatsu
2018-08-28 16:18 ` [ftrace/kprobes PATCH 3/3] tracing/kprobes: Allow kprobe-events to record module symbol Masami Hiramatsu
2018-10-03 19:12   ` Steven Rostedt [this message]
2018-10-04  1:11     ` Steven Rostedt
2018-10-05  8:53       ` Masami Hiramatsu
2018-09-27 10:48 ` [ftrace/kprobes PATCH 0/3] tracing: probeevent: Fix module symbol probing Masami Hiramatsu
2018-10-01 15:48   ` Steven Rostedt
2018-10-03  2:47     ` Steven Rostedt
2018-10-03 13:26       ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181003151227.4a730dcb@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=dan.carpenter@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).