From: Daniel Vetter <daniel@ffwll.ch>
To: "Noralf Trønnes" <noralf@tronnes.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Philipp Zabel <p.zabel@pengutronix.de>,
David Airlie <airlied@linux.ie>,
Lucas Stach <l.stach@pengutronix.de>,
Sam Ravnborg <sam@ravnborg.org>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Souptick Joarder <jrdr.linux@gmail.com>,
Leonard Crestez <leonard.crestez@nxp.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/imx: move 'legacyfb_depth' definition out of #ifdef
Date: Wed, 3 Oct 2018 18:13:26 +0200 [thread overview]
Message-ID: <20181003161326.GD31561@phenom.ffwll.local> (raw)
In-Reply-To: <123f7e1c-8f2b-5797-de16-650ec01d0b24@tronnes.org>
On Wed, Oct 03, 2018 at 05:49:32PM +0200, Noralf Trønnes wrote:
>
>
> Den 02.10.2018 22.58, skrev Arnd Bergmann:
> > The variable is now referenced unconditionally, but still
> > declared in an #ifdef:
> >
> > drivers/gpu/drm/imx/imx-drm-core.c: In function 'imx_drm_bind':
> > drivers/gpu/drm/imx/imx-drm-core.c:264:6: error: 'legacyfb_depth' undeclared (first use in this function); did you mean 'lockdep_depth'?
> >
> > Remove the #ifdef so it can always be accessed.
> >
> > Fixes: f53705fd9803 ("drm/imx: Use drm_fbdev_generic_setup()")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
>
> I've already applied the previous one you sent:
> https://cgit.freedesktop.org/drm/drm-misc/commit/?id=064b06bbf117f8b5e64a5143e970d5a1cf602fd6
>
> Not sure when it reaches linux-next now that we are past rc6.
Only once we're past -rc1.
-Daniel
>
> Noralf.
>
> > drivers/gpu/drm/imx/imx-drm-core.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c
> > index a70f3131a377..0e6942f21a4e 100644
> > --- a/drivers/gpu/drm/imx/imx-drm-core.c
> > +++ b/drivers/gpu/drm/imx/imx-drm-core.c
> > @@ -35,10 +35,8 @@
> > #define MAX_CRTC 4
> > -#if IS_ENABLED(CONFIG_DRM_FBDEV_EMULATION)
> > static int legacyfb_depth = 16;
> > module_param(legacyfb_depth, int, 0444);
> > -#endif
> > DEFINE_DRM_GEM_CMA_FOPS(imx_drm_driver_fops);
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2018-10-03 16:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 20:58 [PATCH] drm/imx: move 'legacyfb_depth' definition out of #ifdef Arnd Bergmann
2018-10-03 15:49 ` Noralf Trønnes
2018-10-03 16:13 ` Daniel Vetter [this message]
2018-10-03 19:51 ` Arnd Bergmann
2018-10-04 7:48 ` Daniel Vetter
2018-10-04 14:43 ` Noralf Trønnes
2018-10-04 15:04 ` Arnd Bergmann
2018-10-04 19:35 ` Daniel Vetter
2018-10-05 10:22 ` Noralf Trønnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181003161326.GD31561@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@linux.ie \
--cc=arnd@arndb.de \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jrdr.linux@gmail.com \
--cc=l.stach@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=noralf@tronnes.org \
--cc=p.zabel@pengutronix.de \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).