From: Jan Kara <jack@suse.cz>
To: John Hubbard <jhubbard@nvidia.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
john.hubbard@gmail.com, Matthew Wilcox <willy@infradead.org>,
Michal Hocko <mhocko@kernel.org>,
Christopher Lameter <cl@linux.com>,
Dan Williams <dan.j.williams@intel.com>, Jan Kara <jack@suse.cz>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
linux-rdma <linux-rdma@vger.kernel.org>,
linux-fsdevel@vger.kernel.org, Doug Ledford <dledford@redhat.com>,
Mike Marciniszyn <mike.marciniszyn@intel.com>,
Dennis Dalessandro <dennis.dalessandro@intel.com>,
Christian Benvenuti <benve@cisco.com>
Subject: Re: [PATCH 3/4] infiniband/mm: convert to the new put_user_page() call
Date: Wed, 3 Oct 2018 18:27:58 +0200 [thread overview]
Message-ID: <20181003162758.GI24030@quack2.suse.cz> (raw)
In-Reply-To: <36bc65a3-8c2a-87df-44fc-89a1891b86db@nvidia.com>
On Fri 28-09-18 20:12:33, John Hubbard wrote:
> static inline void release_user_pages(struct page **pages,
> - unsigned long npages)
> + unsigned long npages,
> + bool set_dirty)
> {
> - while (npages)
> - put_user_page(pages[--npages]);
> + if (set_dirty)
> + release_user_pages_dirty(pages, npages);
> + else
> + release_user_pages_basic(pages, npages);
> +}
Is there a good reason to have this with set_dirty argument? Generally bool
arguments are not great for readability (or greppability for that matter).
Also in this case callers can just as easily do:
if (set_dirty)
release_user_pages_dirty(...);
else
release_user_pages(...);
And furthermore it makes the code author think more whether he needs
set_page_dirty() or set_page_dirty_lock(), rather than just passing 'true'
and hoping the function magically does the right thing for him.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2018-10-03 16:28 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 5:39 [PATCH 0/4] get_user_pages*() and RDMA: first steps john.hubbard
2018-09-28 5:39 ` [PATCH 1/4] mm: get_user_pages: consolidate error handling john.hubbard
2018-09-28 5:39 ` [PATCH 3/4] infiniband/mm: convert to the new put_user_page() call john.hubbard
2018-09-28 15:39 ` Jason Gunthorpe
2018-09-29 3:12 ` John Hubbard
2018-09-29 16:21 ` Matthew Wilcox
2018-09-29 19:19 ` Jason Gunthorpe
2018-10-01 12:50 ` Christoph Hellwig
2018-10-01 15:29 ` Matthew Wilcox
2018-10-01 15:51 ` Christoph Hellwig
2018-10-01 14:35 ` Dennis Dalessandro
2018-10-03 5:40 ` John Hubbard
2018-10-03 16:27 ` Jan Kara [this message]
2018-10-03 23:19 ` John Hubbard
2018-09-28 5:39 ` [PATCH 2/4] mm: introduce put_user_page(), placeholder version john.hubbard
2018-10-03 16:22 ` Jan Kara
2018-10-03 23:23 ` John Hubbard
2018-09-28 5:39 ` [PATCH 4/4] goldfish_pipe/mm: convert to the new release_user_pages() call john.hubbard
2018-09-28 15:29 ` [PATCH 0/4] get_user_pages*() and RDMA: first steps Jerome Glisse
2018-09-28 19:06 ` John Hubbard
2018-09-28 21:49 ` Jerome Glisse
2018-09-29 2:28 ` John Hubbard
2018-09-29 8:46 ` Jerome Glisse
2018-10-01 6:11 ` Dave Chinner
2018-10-01 12:47 ` Christoph Hellwig
2018-10-02 1:14 ` Dave Chinner
2018-10-03 16:21 ` Jan Kara
2018-10-01 15:31 ` Jason Gunthorpe
2018-10-03 16:08 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181003162758.GI24030@quack2.suse.cz \
--to=jack@suse.cz \
--cc=benve@cisco.com \
--cc=cl@linux.com \
--cc=dan.j.williams@intel.com \
--cc=dennis.dalessandro@intel.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=jhubbard@nvidia.com \
--cc=john.hubbard@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=mike.marciniszyn@intel.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).