From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Thomas Tai <thomas.tai@oracle.com>,
linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Cc: Tyler Baicar <tbaicar@codeaurora.org>
Subject: Re: [PATCH v1] ras: Use consistent types for UUIDs
Date: Wed, 3 Oct 2018 20:26:22 +0300 [thread overview]
Message-ID: <20181003172622.GO15943@smile.fi.intel.com> (raw)
In-Reply-To: <20180713131027.77362-1-andriy.shevchenko@linux.intel.com>
On Fri, Jul 13, 2018 at 04:10:27PM +0300, Andy Shevchenko wrote:
> The commit
>
> 297b64c74385 ("ras: acpi / apei: generate trace event for unrecognized CPER section")
>
> brought inconsistency in UUID types which are used across the RAS subsystem.
>
> Fix this by moving to use guid_t everywhere.
Any comments on this?
>
> Cc: Tyler Baicar <tbaicar@codeaurora.org>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/ras/ras.c | 2 +-
> include/ras/ras_event.h | 8 ++++----
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/ras/ras.c b/drivers/ras/ras.c
> index 3f38907320dc..95540ea8dd9d 100644
> --- a/drivers/ras/ras.c
> +++ b/drivers/ras/ras.c
> @@ -14,7 +14,7 @@
> #define TRACE_INCLUDE_PATH ../../include/ras
> #include <ras/ras_event.h>
>
> -void log_non_standard_event(const uuid_le *sec_type, const uuid_le *fru_id,
> +void log_non_standard_event(const guid_t *sec_type, const guid_t *fru_id,
> const char *fru_text, const u8 sev, const u8 *err,
> const u32 len)
> {
> diff --git a/include/ras/ras_event.h b/include/ras/ras_event.h
> index a0794632fd01..36c5c5e38c1d 100644
> --- a/include/ras/ras_event.h
> +++ b/include/ras/ras_event.h
> @@ -27,7 +27,7 @@
> TRACE_EVENT(extlog_mem_event,
> TP_PROTO(struct cper_sec_mem_err *mem,
> u32 err_seq,
> - const uuid_le *fru_id,
> + const guid_t *fru_id,
> const char *fru_text,
> u8 sev),
>
> @@ -39,7 +39,7 @@ TRACE_EVENT(extlog_mem_event,
> __field(u8, sev)
> __field(u64, pa)
> __field(u8, pa_mask_lsb)
> - __field_struct(uuid_le, fru_id)
> + __field_struct(guid_t, fru_id)
> __string(fru_text, fru_text)
> __field_struct(struct cper_mem_err_compact, data)
> ),
> @@ -218,8 +218,8 @@ TRACE_EVENT(arm_event,
> */
> TRACE_EVENT(non_standard_event,
>
> - TP_PROTO(const uuid_le *sec_type,
> - const uuid_le *fru_id,
> + TP_PROTO(const guid_t *sec_type,
> + const guid_t *fru_id,
> const char *fru_text,
> const u8 sev,
> const u8 *err,
> --
> 2.18.0
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2018-10-03 17:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 13:10 [PATCH v1] ras: Use consistent types for UUIDs Andy Shevchenko
2018-10-03 17:26 ` Andy Shevchenko [this message]
2018-10-05 7:33 ` Christoph Hellwig
2019-01-09 16:07 ` Andy Shevchenko
2019-01-24 21:15 ` Thomas Tai
2019-01-24 20:57 ` Andy Shevchenko
2019-01-24 21:25 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181003172622.GO15943@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tbaicar@codeaurora.org \
--cc=thomas.tai@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).