Re: [RFC PATCH 00/10] arch/x86: AMD QoS support

From: Fenghua Yu <fenghua.yu@intel.com>
To: "Moger, Babu" <Babu.Moger@amd.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"reinette.chatre@intel.com" <reinette.chatre@intel.com>,
	"tony.luck@intel.com" <tony.luck@intel.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"pombredanne@nexb.com" <pombredanne@nexb.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"kstewart@linuxfoundation.org" <kstewart@linuxfoundation.org>,
	"bp@suse.de" <bp@suse.de>,
	"rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
	"ak@linux.intel.com" <ak@linux.intel.com>,
	"kirill.shutemov@linux.intel.com"
	<kirill.shutemov@linux.intel.com>,
	"xiaochen.shen@intel.com" <xiaochen.shen@intel.com>,
	"colin.king@canonical.com" <colin.king@canonical.com>,
	"Hurwitz, Sherry" <sherry.hurwitz@amd.com>,
	"Lendacky, Thomas" <Thomas.Lendacky@amd.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"dwmw@amazon.co.uk" <dwmw@amazon.co.uk>,
	"luto@kernel.org" <luto@kernel.org>,
	"jroedel@suse.de" <jroedel@suse.de>,
	"jannh@google.com" <jannh@google.com>,
	"dima@arista.com" <dima@arista.com>,
	"jpoimboe@redhat.com" <jpoimboe@redhat.com>,
	"vkuznets@redhat.com" <vkuznets@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	James Morse <james.morse@arm.com>
Subject: Re: [RFC PATCH 00/10] arch/x86: AMD QoS support
Date: Wed, 3 Oct 2018 11:52:09 -0700	[thread overview]
Message-ID: <20181003185209.GA98542@romley-ivt3.sc.intel.com> (raw)
In-Reply-To: <2549597a-440c-ab77-2c35-01a648703b9f@amd.com>

On Tue, Oct 02, 2018 at 07:16:23PM +0000, Moger, Babu wrote:
> 
> 
> On 10/02/2018 01:46 PM, Fenghua Yu wrote:
> > On Tue, Oct 02, 2018 at 05:44:47PM +0000, Moger, Babu wrote:
> >> Hi Fenghua,
> >>
> >>> -----Original Message-----
> >>> From: Fenghua Yu <fenghua.yu@intel.com>
> >>> Sent: Tuesday, October 2, 2018 12:07 PM
> >>> On Mon, Sep 24, 2018 at 07:18:54PM +0000, Moger, Babu wrote:
> >>>> The public specification is still in works. Will add the link when it is
> >>>> available.
> >>>
> >>> Is this the public AMD QoS spec?
> >>> https://support.amd.com/TechDocs/56375_Quality_of_Service_Extensions.
> >>> pdf
> >>>
> >>
> >> Yes. That is the one. 
> >> I was going to send the link after refreshing the patches on 4-19-rc5.  You already got it. Please let know if you have any feedback on the patches. 
> > 
> > I don't see the name 'RDT' (Resource Director Technology) in the
> > spec "AMD64 Technology Platform Quality of Service Extensions".
> > Does AMD use the same name 'RDT' as Intel?
> 
> No. AMD uses the word "Platform Quality of Service"(or in short QoS) to
> refer this feature.

Hi, Thomas, Babu, and James,

Can we use "resctrl" to replace "intel_rdt" and "rdt" in kernel? "resctrl"
is a neutral name and has been used in user interface already. Hopefully
"resctrl" can be acceptable by ARM, AMD, and Intel. We only use "intel_rdt",
"amd_qos", or "arm mpam" for vendor specific code.

Can we move all of Intel RDT, AMD QoS, and ARM MPAM code into a generic
place fs/resctrl where both ARM and X86 code can stay?

Thanks.

-Fenghua