From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA0E5C00449 for ; Wed, 3 Oct 2018 19:38:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9381D2148D for ; Wed, 3 Oct 2018 19:38:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9381D2148D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727167AbeJDC2n (ORCPT ); Wed, 3 Oct 2018 22:28:43 -0400 Received: from mail.bootlin.com ([62.4.15.54]:48279 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726964AbeJDC2n (ORCPT ); Wed, 3 Oct 2018 22:28:43 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id B59C1207F0; Wed, 3 Oct 2018 21:38:54 +0200 (CEST) Received: from bbrezillon (91-160-177-164.subs.proxad.net [91.160.177.164]) by mail.bootlin.com (Postfix) with ESMTPSA id 666162071E; Wed, 3 Oct 2018 21:38:44 +0200 (CEST) Date: Wed, 3 Oct 2018 21:38:44 +0200 From: Boris Brezillon To: Naga Sureshkumar Relli Cc: , , , , , michals@xilinx.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, nagasuresh12@gmail.com Subject: Re: [LINUX PATCH v11 3/3] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller Message-ID: <20181003213844.14d4095e@bbrezillon> In-Reply-To: <1537878031-22253-4-git-send-email-naga.sureshkumar.relli@xilinx.com> References: <1537878031-22253-1-git-send-email-naga.sureshkumar.relli@xilinx.com> <1537878031-22253-4-git-send-email-naga.sureshkumar.relli@xilinx.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Naga, On Tue, 25 Sep 2018 17:50:31 +0530 Naga Sureshkumar Relli wrote: > +static int anfc_read_param_get_feature_sp_read_type_exec(struct nand_chip *chip, > + const struct nand_subop > + *subop) > +{ > + const struct nand_op_instr *instr; > + struct anfc_nand_controller *nfc = to_anfc(chip->controller); > + unsigned int op_id, len; > + struct anfc_op nfc_op = {}; > + struct mtd_info *mtd = nand_to_mtd(chip); > + struct anfc_nand_chip *achip = to_anfc_nand(chip); > + u32 dma_mode, addrcycles, write_size; > + > + anfc_parse_instructions(chip, subop, &nfc_op); > + instr = nfc_op.data_instr; > + op_id = nfc_op.data_instr_idx; > + > + if (nfc_op.cmds[0] == NAND_CMD_PARAM) { > + nfc->prog = PROG_RDPARAM; > + dma_mode = 0; > + addrcycles = 1; > + write_size = 0; > + } > + if (nfc_op.cmds[0] == NAND_CMD_GET_FEATURES) { > + nfc->prog = PROG_GET_FEATURE; > + dma_mode = 0; > + addrcycles = 1; > + write_size = 0; > + } > + if (nfc_op.cmds[0] == NAND_CMD_READ0) { > + nfc->prog = PROG_PGRD; > + addrcycles = achip->raddr_cycles + achip->caddr_cycles; > + write_size = mtd->writesize; > + dma_mode = 1; > + } > + Sorry, but I still don't understand why nfc->prog is different. Did you try using PROG_PGRD for all these ops? I mean, the sequence is the same, and you keep passing the opcode and the number of address cycles to the engine using other reg fields. Also, you're not using the addrcycles info provided by the the address instruction and instead deduce it based on the opcode, which is wrong. To make it clearer, I'd like to avoid those nfc_op.cmds[0] == NAND_OPCODE tests, because it's exactly the kind of things we were trying to get rid off by introducing the ->exec_op() interface. > + anfc_prepare_cmd(nfc, nfc_op.cmds[0], 0, dma_mode, write_size, > + addrcycles); > + anfc_setpagecoladdr(nfc, nfc_op.row, nfc_op.col); > + > + if (!nfc_op.data_instr) > + return 0; > + > + len = nand_subop_get_data_len(subop, op_id); > + anfc_rw_pio_op(mtd, nfc->buf, roundup(len, 4), 1, nfc->prog, 1, 0); > + memcpy(instr->ctx.data.buf.in, nfc->buf, len); > + > + return 0; > +}