From: David Sterba <dsterba@suse.cz>
To: zhong jiang <zhongjiang@huawei.com>
Cc: dsterba@suse.cz, osandov@osandov.com, dsterba@suse.com,
jbacik@fb.com, clm@fb.com, linux-btrfs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] btrfs: list usage cleanup
Date: Thu, 4 Oct 2018 12:02:20 +0200 [thread overview]
Message-ID: <20181004100220.GA29418@twin.jikos.cz> (raw)
In-Reply-To: <1538628507-32593-1-git-send-email-zhongjiang@huawei.com>
On Thu, Oct 04, 2018 at 12:48:27PM +0800, zhong jiang wrote:
> Trival cleanup, list_move_tail will implement the same function that
> list_del() + list_add_tail() will do. hence just replace them.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> fs/btrfs/send.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
> index 094cc144..30e7e12 100644
> --- a/fs/btrfs/send.c
> +++ b/fs/btrfs/send.c
> @@ -2075,8 +2075,8 @@ static struct name_cache_entry *name_cache_search(struct send_ctx *sctx,
> */
> static void name_cache_used(struct send_ctx *sctx, struct name_cache_entry *nce)
> {
> - list_del(&nce->list);
> - list_add_tail(&nce->list, &sctx->name_cache_list);
> + /* delete from sctx->name_cache_list and add as its tail */
> + list_move_tail(&nce->list, &sctx->name_cache_list);
The suggestion was to drop name_cache_used and replace it with
list_move_tail(...), the comment as you wrote it does not bring much
information as it merely repeats how list_move_tail is implemeted. A
useful comment explains something that's not obvious.
prev parent reply other threads:[~2018-10-04 10:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 4:48 [PATCHv2] btrfs: list usage cleanup zhong jiang
2018-10-04 10:02 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181004100220.GA29418@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=osandov@osandov.com \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).