From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14AEFC64EBC for ; Thu, 4 Oct 2018 14:30:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D5AEA2082A for ; Thu, 4 Oct 2018 14:30:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D5AEA2082A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727684AbeJDVX6 (ORCPT ); Thu, 4 Oct 2018 17:23:58 -0400 Received: from muru.com ([72.249.23.125]:58196 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727322AbeJDVX6 (ORCPT ); Thu, 4 Oct 2018 17:23:58 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 0943D8160; Thu, 4 Oct 2018 14:34:53 +0000 (UTC) Date: Thu, 4 Oct 2018 07:30:22 -0700 From: Tony Lindgren To: Aaro Koskinen Cc: Janusz Krzysztofik , linux-arm-kernel@lists.infradead.org, Dan Carpenter , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: OMAP1: ams-delta: Fix impossible .irq < 0 Message-ID: <20181004143021.GC5662@atomide.com> References: <20181001102453.GA18947@mwanda> <20181002094529.30564-1-jmkrzyszt@gmail.com> <20181002174745.GG3461@darkstar.musicnaut.iki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181002174745.GG3461@darkstar.musicnaut.iki.fi> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Aaro Koskinen [181002 17:52]: > Hi, > > On Tue, Oct 02, 2018 at 11:45:29AM +0200, Janusz Krzysztofik wrote: > > Since the very beginning, unsigned int .irq member of struct > > plat_serial8250_port introduced by commit eff443df679e ("OMAP1: > > AMS_DELTA: add modem support") was statically initialized to a negative > > value -EINVAL. Moreover, commit 0812db943748 ("ARM: OMAP1: ams-delta: > > assign MODEM IRQ from GPIO descriptor") has introduced some new code > > which checks for that member carrying a negative value which is > > impossible. > > > > Use IRQ_NOTCONNECTED instead of -EINVAL. Also, drop the valueless check > > and let the modem device be registered regardless of .irq value, and > > the value handled by "serial8250" driver. > > > > Fixes: 0812db943748 ("ARM: OMAP1: ams-delta: assign MODEM IRQ from GPIO descriptor") > > Reported-by: Dan Carpenter > > Signed-off-by: Janusz Krzysztofik > > Acked-by: Aaro Koskinen Applying into omap-for-v4.20/omap1 thanks. Regards, Tony