* [PATCH] sbus: Use of_get_child_by_name helper
@ 2018-08-29 20:03 Rob Herring
2018-10-08 5:57 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring @ 2018-08-29 20:03 UTC (permalink / raw)
To: David S. Miller; +Cc: linux-kernel, sparclinux
Use the of_get_child_by_name() helper instead of open coding searching
for the '/options' node. This removes directly accessing the name
pointer as well.
Cc: "David S. Miller" <davem@davemloft.net>
Cc: sparclinux@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
drivers/sbus/char/openprom.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/sbus/char/openprom.c b/drivers/sbus/char/openprom.c
index 7b31f19ade83..050879a2ddef 100644
--- a/drivers/sbus/char/openprom.c
+++ b/drivers/sbus/char/openprom.c
@@ -715,22 +715,13 @@ static struct miscdevice openprom_dev = {
static int __init openprom_init(void)
{
- struct device_node *dp;
int err;
err = misc_register(&openprom_dev);
if (err)
return err;
- dp = of_find_node_by_path("/");
- dp = dp->child;
- while (dp) {
- if (!strcmp(dp->name, "options"))
- break;
- dp = dp->sibling;
- }
- options_node = dp;
-
+ options_node = of_get_child_by_name(of_find_node_by_path("/"), "options");
if (!options_node) {
misc_deregister(&openprom_dev);
return -EIO;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sbus: Use of_get_child_by_name helper
2018-08-29 20:03 [PATCH] sbus: Use of_get_child_by_name helper Rob Herring
@ 2018-10-08 5:57 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-10-08 5:57 UTC (permalink / raw)
To: robh; +Cc: linux-kernel, sparclinux
From: Rob Herring <robh@kernel.org>
Date: Wed, 29 Aug 2018 15:03:37 -0500
> Use the of_get_child_by_name() helper instead of open coding searching
> for the '/options' node. This removes directly accessing the name
> pointer as well.
>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: sparclinux@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-08 5:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-29 20:03 [PATCH] sbus: Use of_get_child_by_name helper Rob Herring
2018-10-08 5:57 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).