* [PATCH] net: wireless: iwlegacy: Add a lock assertion in il4965_send_rxon_assoc()
@ 2018-10-05 13:55 Jia-Ju Bai
2018-10-08 8:54 ` Stanislaw Gruszka
2018-10-13 17:02 ` [PATCH] " Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Jia-Ju Bai @ 2018-10-05 13:55 UTC (permalink / raw)
To: sgruszka, kvalo, davem; +Cc: linux-wireless, netdev, linux-kernel, Jia-Ju Bai
The variables il->staging.filter_flags, rxon1->filter_flags and
rxon2->filter_flags need to be protected by the mutex lock il->mutex.
This patch adds a lock assertion of il->mutex to check whether
this lock is held.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
---
drivers/net/wireless/intel/iwlegacy/4965.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/wireless/intel/iwlegacy/4965.c b/drivers/net/wireless/intel/iwlegacy/4965.c
index c3c638ed0ed7..ce4144a89217 100644
--- a/drivers/net/wireless/intel/iwlegacy/4965.c
+++ b/drivers/net/wireless/intel/iwlegacy/4965.c
@@ -1297,6 +1297,8 @@ il4965_send_rxon_assoc(struct il_priv *il)
const struct il_rxon_cmd *rxon1 = &il->staging;
const struct il_rxon_cmd *rxon2 = &il->active;
+ lockdep_assert_held(&il->mutex);
+
if (rxon1->flags == rxon2->flags &&
rxon1->filter_flags == rxon2->filter_flags &&
rxon1->cck_basic_rates == rxon2->cck_basic_rates &&
--
2.17.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: wireless: iwlegacy: Add a lock assertion in il4965_send_rxon_assoc()
2018-10-05 13:55 [PATCH] net: wireless: iwlegacy: Add a lock assertion in il4965_send_rxon_assoc() Jia-Ju Bai
@ 2018-10-08 8:54 ` Stanislaw Gruszka
2018-10-13 17:02 ` [PATCH] " Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Stanislaw Gruszka @ 2018-10-08 8:54 UTC (permalink / raw)
To: Jia-Ju Bai; +Cc: kvalo, davem, linux-wireless, netdev, linux-kernel
On Fri, Oct 05, 2018 at 09:55:46PM +0800, Jia-Ju Bai wrote:
> The variables il->staging.filter_flags, rxon1->filter_flags and
> rxon2->filter_flags need to be protected by the mutex lock il->mutex.
> This patch adds a lock assertion of il->mutex to check whether
> this lock is held.
>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Acked-by: Stanislaw Gruszka <sgruszka@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iwlegacy: Add a lock assertion in il4965_send_rxon_assoc()
2018-10-05 13:55 [PATCH] net: wireless: iwlegacy: Add a lock assertion in il4965_send_rxon_assoc() Jia-Ju Bai
2018-10-08 8:54 ` Stanislaw Gruszka
@ 2018-10-13 17:02 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2018-10-13 17:02 UTC (permalink / raw)
To: Jia-Ju Bai
Cc: sgruszka, davem, linux-wireless, netdev, linux-kernel, Jia-Ju Bai
Jia-Ju Bai <baijiaju1990@gmail.com> wrote:
> The variables il->staging.filter_flags, rxon1->filter_flags and
> rxon2->filter_flags need to be protected by the mutex lock il->mutex.
> This patch adds a lock assertion of il->mutex to check whether
> this lock is held.
>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
> Acked-by: Stanislaw Gruszka <sgruszka@redhat.com>
Patch applied to wireless-drivers-next.git, thanks.
52a312673aff iwlegacy: Add a lock assertion in il4965_send_rxon_assoc()
--
https://patchwork.kernel.org/patch/10628205/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-13 17:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-05 13:55 [PATCH] net: wireless: iwlegacy: Add a lock assertion in il4965_send_rxon_assoc() Jia-Ju Bai
2018-10-08 8:54 ` Stanislaw Gruszka
2018-10-13 17:02 ` [PATCH] " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).