From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 087A4C00449 for ; Mon, 8 Oct 2018 10:59:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CE4A320878 for ; Mon, 8 Oct 2018 10:59:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE4A320878 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727669AbeJHSKJ (ORCPT ); Mon, 8 Oct 2018 14:10:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59764 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726656AbeJHSKI (ORCPT ); Mon, 8 Oct 2018 14:10:08 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D72EAC049D66; Mon, 8 Oct 2018 10:58:59 +0000 (UTC) Received: from krava (unknown [10.43.17.152]) by smtp.corp.redhat.com (Postfix) with SMTP id 321CA60C4D; Mon, 8 Oct 2018 10:58:58 +0000 (UTC) Date: Mon, 8 Oct 2018 12:58:57 +0200 From: Jiri Olsa To: Alexey Budankov Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Namhyung Kim , Andi Kleen , linux-kernel Subject: Re: [PATCH v11 2/3]: perf record: enable asynchronous trace writing Message-ID: <20181008105857.GJ17270@krava> References: <7d42aa80-8e69-44e4-b963-e8ef89df2099@linux.intel.com> <31b0ae5f-e1b5-4255-11af-46c8ebe8e2be@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <31b0ae5f-e1b5-4255-11af-46c8ebe8e2be@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 08 Oct 2018 10:59:00 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 08, 2018 at 09:17:11AM +0300, Alexey Budankov wrote: SNIP > static int record__mmap_read_evlist(struct record *rec, struct perf_evlist *evlist, > bool overwrite) > { > @@ -520,7 +644,10 @@ static int record__mmap_read_evlist(struct record *rec, struct perf_evlist *evli > int i; > int rc = 0; > struct perf_mmap *maps; > - > +#ifdef HAVE_AIO_SUPPORT > + int trace_fd = rec->data.file.fd; > + off_t off; > +#endif > if (!evlist) > return 0; > > @@ -531,14 +658,34 @@ static int record__mmap_read_evlist(struct record *rec, struct perf_evlist *evli > if (overwrite && evlist->bkw_mmap_state != BKW_MMAP_DATA_PENDING) > return 0; > > +#ifdef HAVE_AIO_SUPPORT > + off = lseek(trace_fd, 0, SEEK_CUR); > +#endif > for (i = 0; i < evlist->nr_mmaps; i++) { > struct perf_mmap *map = &maps[i]; > > if (map->base) { > - if (perf_mmap__push(map, rec, record__pushfn) != 0) { > - rc = -1; > - goto out; > +#ifdef HAVE_AIO_SUPPORT > + if (!rec->opts.nr_cblocks) { > +#endif maybe it'd be less confusing having something like rec->opts.aio.enabled or aio__is_enabled() global with the dummy counterpart jirka