From: Borislav Petkov <bp@suse.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Naresh Kamboju <naresh.kamboju@linaro.org>,
Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
m.mizuma@jp.fujitsu.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Baoquan He <bhe@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-tip-commits@vger.kernel.org, lkft-triage@lists.linaro.org
Subject: Re: [tip:x86/boot] x86/kaslr, ACPI/NUMA: Fix KASLR build error
Date: Mon, 8 Oct 2018 16:10:49 +0200 [thread overview]
Message-ID: <20181008141049.GG6490@zn.tnic> (raw)
In-Reply-To: <CAK8P3a3Lek2NryUqFZGxSSG2PZD3McS7bezK9Ur3AAX2v6=mgQ@mail.gmail.com>
On Mon, Oct 08, 2018 at 03:48:28PM +0200, Arnd Bergmann wrote:
> I think __weak functions are too fragile, when you do this and it
> turns out that another architecture does need to do something,
> you won't ever get any indication of it.
>
> If we know that arm64 doesn't need to do anything here, just
> add an arch/arm64/include/asm/kaslr.h with an empty function
> there.
I'm looking at fs/proc/vmcore.c and all those other weak functions there
and just doing the same.
Also, judging by
$ git grep CONFIG_PROC_VMCORE
output, ia64, mips and powerpc would need that include too.
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2018-10-08 14:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-01 14:08 [PATCH v5 0/3] Add a kernel parameter to change the padding size for KASLR Masayoshi Mizuma
2018-10-01 14:08 ` [PATCH v5 1/3] x86/mm: Add a kernel parameter to change the padding used for the physical memory mapping Masayoshi Mizuma
2018-10-02 10:18 ` [tip:x86/boot] " tip-bot for Masayoshi Mizuma
2018-10-01 14:08 ` [PATCH v5 2/3] ACPI / NUMA: Add warning message if the padding size for KASLR is not enough Masayoshi Mizuma
2018-10-02 10:18 ` [tip:x86/boot] ACPI/NUMA: " tip-bot for Masayoshi Mizuma
2018-10-02 15:05 ` Borislav Petkov
2018-10-02 21:19 ` Masayoshi Mizuma
2018-10-03 10:58 ` Masayoshi Mizuma
2018-10-03 12:34 ` Peter Zijlstra
2018-10-03 12:48 ` Borislav Petkov
2018-10-03 13:02 ` Masayoshi Mizuma
2018-10-03 14:21 ` [tip:x86/boot] x86/kaslr, ACPI/NUMA: Fix KASLR build error tip-bot for Peter Zijlstra (Intel)
2018-10-08 11:03 ` Naresh Kamboju
2018-10-08 13:01 ` Borislav Petkov
2018-10-08 13:48 ` Arnd Bergmann
2018-10-08 14:10 ` Borislav Petkov [this message]
2018-10-09 10:39 ` tip-bot for Peter Zijlstra (Intel)
2018-10-01 14:08 ` [PATCH v5 3/3] docs: kernel-parameters.txt: document rand_mem_physical_padding Masayoshi Mizuma
2018-10-02 10:19 ` [tip:x86/boot] Documentation/kernel-parameters.txt: Document rand_mem_physical_padding= tip-bot for Masayoshi Mizuma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181008141049.GG6490@zn.tnic \
--to=bp@suse.de \
--cc=arnd@arndb.de \
--cc=bhe@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=lkft-triage@lists.linaro.org \
--cc=m.mizuma@jp.fujitsu.com \
--cc=mingo@kernel.org \
--cc=naresh.kamboju@linaro.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).