linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Greg KH <greg@kroah.com>, Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Linux-Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Rob Herring <robh@kernel.org>,
	Steve Longerbeam <slongerbeam@gmail.com>
Subject: linux-next: manual merge of the staging tree with the v4l-dvb tree
Date: Mon, 8 Oct 2018 15:47:43 +1100	[thread overview]
Message-ID: <20181008154743.156e63be@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 3267 bytes --]

Hi all,

Today's linux-next merge of the staging tree got a conflict in:

  drivers/staging/media/imx/imx-media-dev.c

between commit:

  b803cd359833 ("media: staging/imx: Switch to v4l2_async_notifier_add_*_subdev")

from the v4l-dvb tree and commit:

  f93861c2d611 ("staging: Convert to using %pOFn instead of device_node.name")

from the staging tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc drivers/staging/media/imx/imx-media-dev.c
index 481840195071,3f48f5ceb6ea..000000000000
--- a/drivers/staging/media/imx/imx-media-dev.c
+++ b/drivers/staging/media/imx/imx-media-dev.c
@@@ -47,34 -80,52 +47,43 @@@ int imx_media_add_async_subdev(struct i
  	struct imx_media_async_subdev *imxasd;
  	struct v4l2_async_subdev *asd;
  	const char *devname = NULL;
 -	int ret = 0;
 -
 -	mutex_lock(&imxmd->mutex);
 +	int ret;
  
 -	if (pdev)
 +	if (fwnode) {
 +		asd = v4l2_async_notifier_add_fwnode_subdev(
 +			&imxmd->notifier, fwnode, sizeof(*imxasd));
 +	} else {
  		devname = dev_name(&pdev->dev);
 -
 -	/* return -EEXIST if this asd already added */
 -	if (find_async_subdev(imxmd, fwnode, devname)) {
 -		if (np)
 -			dev_dbg(imxmd->md.dev, "%s: already added %pOFn\n",
 -			__func__, np);
 -		else
 -			dev_dbg(imxmd->md.dev, "%s: already added %s\n",
 -			__func__, devname);
 -		ret = -EEXIST;
 -		goto out;
 +		asd = v4l2_async_notifier_add_devname_subdev(
 +			&imxmd->notifier, devname, sizeof(*imxasd));
  	}
  
 -	imxasd = devm_kzalloc(imxmd->md.dev, sizeof(*imxasd), GFP_KERNEL);
 -	if (!imxasd) {
 -		ret = -ENOMEM;
 -		goto out;
 +	if (IS_ERR(asd)) {
 +		ret = PTR_ERR(asd);
- 		if (ret == -EEXIST)
- 			dev_dbg(imxmd->md.dev, "%s: already added %s\n",
- 				__func__, np ? np->name : devname);
++		if (ret == -EEXIST) {
++			if (np)
++				dev_dbg(imxmd->md.dev, "%s: already added %pOFn\n",
++				__func__, np);
++			else
++				dev_dbg(imxmd->md.dev, "%s: already added %s\n",
++				__func__, devname);
++		}
 +		return ret;
  	}
 -	asd = &imxasd->asd;
  
 -	if (fwnode) {
 -		asd->match_type = V4L2_ASYNC_MATCH_FWNODE;
 -		asd->match.fwnode = fwnode;
 +	imxasd = to_imx_media_asd(asd);
 +
 +	if (devname)
 +		imxasd->pdev = pdev;
 +
- 	dev_dbg(imxmd->md.dev, "%s: added %s, match type %s\n",
- 		__func__, np ? np->name : devname, np ? "FWNODE" : "DEVNAME");
++	if (fwnode)
+ 		dev_dbg(imxmd->md.dev, "%s: added %pOFn, match type FWNODE\n",
+ 			__func__, np);
 -	} else {
 -		asd->match_type = V4L2_ASYNC_MATCH_DEVNAME;
 -		asd->match.device_name = devname;
 -		imxasd->pdev = pdev;
++	else
+ 		dev_dbg(imxmd->md.dev, "%s: added %s, match type DEVNAME\n",
+ 			__func__, devname);
 -	}
 -
 -	list_add_tail(&imxasd->list, &imxmd->asd_list);
 -
 -	imxmd->subdev_notifier.num_subdevs++;
  
 -out:
 -	mutex_unlock(&imxmd->mutex);
 -	return ret;
 +	return 0;
  }
  
  /*

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2018-10-08  4:47 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-08  4:47 Stephen Rothwell [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-02-13  2:13 linux-next: manual merge of the staging tree with the v4l-dvb tree Stephen Rothwell
2023-02-13  7:05 ` Greg KH
2020-03-23  4:18 Stephen Rothwell
2020-03-23  9:56 ` Greg KH
2020-03-19  3:44 Stephen Rothwell
2020-03-19  8:30 ` Greg KH
2019-04-26  6:06 Stephen Rothwell
2019-04-27  6:36 ` Greg KH
2019-05-08  1:54 ` Stephen Rothwell
2019-04-04  2:43 Stephen Rothwell
2018-12-10  5:53 Stephen Rothwell
2018-10-08  4:53 Stephen Rothwell
2018-05-17  4:17 Stephen Rothwell
2018-05-17  7:22 ` Greg KH
2018-05-17 10:06 ` Mauro Carvalho Chehab
2018-05-26  4:45   ` Stephen Rothwell
2017-11-02  4:30 Stephen Rothwell
2017-04-11  3:32 Stephen Rothwell
2017-04-06  3:34 Stephen Rothwell
2017-04-06 18:58 ` Sean Young
2017-04-06 19:19   ` Greg KH
2017-04-06 20:39     ` Sean Young
2017-04-06 21:51       ` Stephen Rothwell
2017-02-06  4:31 Stephen Rothwell
2017-02-06  8:37 ` Greg KH
2016-03-04  5:24 Stephen Rothwell
2016-03-04 16:58 ` Greg KH
2015-05-11  5:28 Stephen Rothwell
2015-05-11 18:34 ` Greg KH
2015-03-24  5:29 Stephen Rothwell
2014-11-24  8:10 Stephen Rothwell
2014-11-24  8:09 Stephen Rothwell
2014-11-05  4:37 Stephen Rothwell
2014-11-05  4:31 Stephen Rothwell
2014-11-05  4:29 Stephen Rothwell
2014-11-06  2:19 ` Greg KH
2014-07-16  6:46 Stephen Rothwell
2014-07-16 20:52 ` Greg KH
2014-03-18  6:15 Stephen Rothwell
2014-03-17  7:55 Stephen Rothwell
2014-03-17 11:01 ` Mauro Carvalho Chehab
2014-03-17 18:29   ` Greg KH
     [not found]     ` < 20140317162937.2ccdec83@infradead.org>
2014-03-17 19:29     ` Mauro Carvalho Chehab
2014-03-17 22:27       ` Russell King
2014-03-19 15:30         ` Greg KH
2014-03-21 12:24           ` Grant Likely
2014-03-21 14:37             ` Grant Likely
2011-09-27  6:10 Stephen Rothwell
2011-09-27 14:18 ` Greg KH
2011-09-27 20:14 ` Paul Gortmaker
2011-07-16 13:03 Stephen Rothwell
2011-07-17  9:15 ` Greg KH
2011-03-04  5:39 Stephen Rothwell
2011-03-04 17:14 ` Greg KH
2011-03-04  5:39 Stephen Rothwell
2011-03-04 17:14 ` Greg KH
2011-03-04  5:39 Stephen Rothwell
2011-03-04 17:13 ` Greg KH
2011-03-04 17:54   ` Mauro Carvalho Chehab
2011-03-04 21:23     ` Greg KH
2011-03-04 22:17       ` Mauro Carvalho Chehab
2011-03-04  5:38 Stephen Rothwell
2011-03-04 17:12 ` Greg KH
2011-03-04  5:38 Stephen Rothwell
2011-03-04 17:13 ` Greg KH
2011-03-04  5:38 Stephen Rothwell
2011-03-04 17:12 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181008154743.156e63be@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=robh@kernel.org \
    --cc=slongerbeam@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).