linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 00/11] staging:rtl8192u: Coding Style changes
@ 2018-10-07 21:40 John Whitmore
  2018-10-07 21:40 ` [PATCH 01/11] staging:rtl8192u: Add missing SPDX-License-Identifier - Style John Whitmore
                   ` (10 more replies)
  0 siblings, 11 replies; 14+ messages in thread
From: John Whitmore @ 2018-10-07 21:40 UTC (permalink / raw)
  To: linux-kernel; +Cc: devel, gregkh, John Whitmore

Just a number of simple coding style changes in the file
ieee80211_module.c

John Whitmore (11):
  staging:rtl8192u: Add missing SPDX-License-Identifier - Style
  staging:rtl8192u: Removed commented out include - Style
  staging:rtl8192u: Clear error with line ending ( - Style
  staging:rtl8192u: Remove extra blank lines - Style
  staging:rtl8192u: Add spaces around + operator - Style
  staging:rtl8192u: Rewrite test for null - Style
  staging:rtl8192u: Correct code indentation - Style
  staging:rtl8192u: Add missing blank lines - Style
  staging:rtl8192u: Remove unnecessary line continuation - Style
  staging:rtl8192u: Correct code alignment - Style
  staging:rtl8192u: Correct comparison with NULL - Style

 .../rtl8192u/ieee80211/ieee80211_module.c     | 32 +++++++++----------
 1 file changed, 15 insertions(+), 17 deletions(-)

-- 
2.19.0


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 01/11] staging:rtl8192u: Add missing SPDX-License-Identifier - Style
  2018-10-07 21:40 [PATCH 00/11] staging:rtl8192u: Coding Style changes John Whitmore
@ 2018-10-07 21:40 ` John Whitmore
  2018-10-07 21:40 ` [PATCH 02/11] staging:rtl8192u: Removed commented out include " John Whitmore
                   ` (9 subsequent siblings)
  10 siblings, 0 replies; 14+ messages in thread
From: John Whitmore @ 2018-10-07 21:40 UTC (permalink / raw)
  To: linux-kernel; +Cc: devel, gregkh, John Whitmore

Add the missing SPDX-License-Identifier tag to file to clear the
checkpatch issue.

This is a coding style change which should have no impact on runtime
code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
---
 drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
index 90a097f2cd4e..5f8229f2c757 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
 /*******************************************************************************
  *
  *  Copyright(c) 2004 Intel Corporation. All rights reserved.
-- 
2.19.0


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 02/11] staging:rtl8192u: Removed commented out include - Style
  2018-10-07 21:40 [PATCH 00/11] staging:rtl8192u: Coding Style changes John Whitmore
  2018-10-07 21:40 ` [PATCH 01/11] staging:rtl8192u: Add missing SPDX-License-Identifier - Style John Whitmore
@ 2018-10-07 21:40 ` John Whitmore
  2018-10-09 13:25   ` Greg KH
  2018-10-07 21:40 ` [PATCH 03/11] staging:rtl8192u: Clear error with line ending ( " John Whitmore
                   ` (8 subsequent siblings)
  10 siblings, 1 reply; 14+ messages in thread
From: John Whitmore @ 2018-10-07 21:40 UTC (permalink / raw)
  To: linux-kernel; +Cc: devel, gregkh, John Whitmore

Remove commented out #include directive.

Additionally shorted a block comment to clear the checkpatch issue
with line length.

These are coding style changes which should have no impact on runtime
code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
---
 drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
index 5f8229f2c757..bd64d126ba2b 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
@@ -29,10 +29,9 @@
  *  James P. Ketrenos <ipw2100-admin@linux.intel.com>
  *  Intel Corporation, 5200 N.E. Elam Young Parkway, Hillsboro, OR 97124-6497
  *
- *******************************************************************************/
+ ******************************************************************************/
 
 #include <linux/compiler.h>
-/* #include <linux/config.h> */
 #include <linux/errno.h>
 #include <linux/if_arp.h>
 #include <linux/in6.h>
-- 
2.19.0


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 03/11] staging:rtl8192u: Clear error with line ending ( - Style
  2018-10-07 21:40 [PATCH 00/11] staging:rtl8192u: Coding Style changes John Whitmore
  2018-10-07 21:40 ` [PATCH 01/11] staging:rtl8192u: Add missing SPDX-License-Identifier - Style John Whitmore
  2018-10-07 21:40 ` [PATCH 02/11] staging:rtl8192u: Removed commented out include " John Whitmore
@ 2018-10-07 21:40 ` John Whitmore
  2018-10-07 21:40 ` [PATCH 04/11] staging:rtl8192u: Remove extra blank lines " John Whitmore
                   ` (7 subsequent siblings)
  10 siblings, 0 replies; 14+ messages in thread
From: John Whitmore @ 2018-10-07 21:40 UTC (permalink / raw)
  To: linux-kernel; +Cc: devel, gregkh, John Whitmore

Rewrite function call to clear the checkpatch issue with lines ending
with a '(' character.

This is a coding style change which should have no impact on runtime
code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
---
 drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
index bd64d126ba2b..20348a1f2d32 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
@@ -64,9 +64,9 @@ static inline int ieee80211_networks_allocate(struct ieee80211_device *ieee)
 	if (ieee->networks)
 		return 0;
 
-	ieee->networks = kcalloc(
-		MAX_NETWORK_COUNT, sizeof(struct ieee80211_network),
-		GFP_KERNEL);
+	ieee->networks = kcalloc(MAX_NETWORK_COUNT,
+				 sizeof(struct ieee80211_network),
+				 GFP_KERNEL);
 	if (!ieee->networks) {
 		printk(KERN_WARNING "%s: Out of memory allocating beacons\n",
 		       ieee->dev->name);
-- 
2.19.0


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 04/11] staging:rtl8192u: Remove extra blank lines - Style
  2018-10-07 21:40 [PATCH 00/11] staging:rtl8192u: Coding Style changes John Whitmore
                   ` (2 preceding siblings ...)
  2018-10-07 21:40 ` [PATCH 03/11] staging:rtl8192u: Clear error with line ending ( " John Whitmore
@ 2018-10-07 21:40 ` John Whitmore
  2018-10-07 21:40 ` [PATCH 05/11] staging:rtl8192u: Add spaces around + operator " John Whitmore
                   ` (6 subsequent siblings)
  10 siblings, 0 replies; 14+ messages in thread
From: John Whitmore @ 2018-10-07 21:40 UTC (permalink / raw)
  To: linux-kernel; +Cc: devel, gregkh, John Whitmore

Remove the extra blank lines to clear checkpatch issue.

This is a simple coding style change which should have no impact
on runtime code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
---
 drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
index 20348a1f2d32..c52eac0bf6f6 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
@@ -94,7 +94,6 @@ static inline void ieee80211_networks_initialize(struct ieee80211_device *ieee)
 		list_add_tail(&ieee->networks[i].list, &ieee->network_free_list);
 }
 
-
 struct net_device *alloc_ieee80211(int sizeof_priv)
 {
 	struct ieee80211_device *ieee;
@@ -121,7 +120,6 @@ struct net_device *alloc_ieee80211(int sizeof_priv)
 	}
 	ieee80211_networks_initialize(ieee);
 
-
 	/* Default fragmentation threshold is maximum payload size */
 	ieee->fts = DEFAULT_FTS;
 	ieee->scan_age = DEFAULT_MAX_SCAN_AGE;
@@ -186,7 +184,6 @@ struct net_device *alloc_ieee80211(int sizeof_priv)
 	return NULL;
 }
 
-
 void free_ieee80211(struct net_device *dev)
 {
 	struct ieee80211_device *ieee = netdev_priv(dev);
-- 
2.19.0


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 05/11] staging:rtl8192u: Add spaces around + operator - Style
  2018-10-07 21:40 [PATCH 00/11] staging:rtl8192u: Coding Style changes John Whitmore
                   ` (3 preceding siblings ...)
  2018-10-07 21:40 ` [PATCH 04/11] staging:rtl8192u: Remove extra blank lines " John Whitmore
@ 2018-10-07 21:40 ` John Whitmore
  2018-10-07 21:40 ` [PATCH 06/11] staging:rtl8192u: Rewrite test for null " John Whitmore
                   ` (5 subsequent siblings)
  10 siblings, 0 replies; 14+ messages in thread
From: John Whitmore @ 2018-10-07 21:40 UTC (permalink / raw)
  To: linux-kernel; +Cc: devel, gregkh, John Whitmore

Add spaces around '+' operator to clear the checkpatch issue.

This is a coding style change which should have no impact on runtime
code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
---
 drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
index c52eac0bf6f6..0fe65dd8c407 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
@@ -109,7 +109,7 @@ struct net_device *alloc_ieee80211(int sizeof_priv)
 	}
 
 	ieee = netdev_priv(dev);
-	memset(ieee, 0, sizeof(struct ieee80211_device)+sizeof_priv);
+	memset(ieee, 0, sizeof(struct ieee80211_device) + sizeof_priv);
 	ieee->dev = dev;
 
 	err = ieee80211_networks_allocate(ieee);
-- 
2.19.0


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 06/11] staging:rtl8192u: Rewrite test for null - Style
  2018-10-07 21:40 [PATCH 00/11] staging:rtl8192u: Coding Style changes John Whitmore
                   ` (4 preceding siblings ...)
  2018-10-07 21:40 ` [PATCH 05/11] staging:rtl8192u: Add spaces around + operator " John Whitmore
@ 2018-10-07 21:40 ` John Whitmore
  2018-10-09 13:26   ` Greg KH
  2018-10-07 21:40 ` [PATCH 07/11] staging:rtl8192u: Correct code indentation " John Whitmore
                   ` (4 subsequent siblings)
  10 siblings, 1 reply; 14+ messages in thread
From: John Whitmore @ 2018-10-07 21:40 UTC (permalink / raw)
  To: linux-kernel; +Cc: devel, gregkh, John Whitmore

Rewrite a test for NULL to comply with the coding style and clear the
checkpatch issue.

This is a coding style change which should not impact runtime
code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
---
 drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
index 0fe65dd8c407..9bbacec52e1f 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
@@ -155,7 +155,7 @@ struct net_device *alloc_ieee80211(int sizeof_priv)
 	ieee80211_softmac_init(ieee);
 
 	ieee->pHTInfo = kzalloc(sizeof(RT_HIGH_THROUGHPUT), GFP_KERNEL);
-	if (ieee->pHTInfo == NULL) {
+	if (!ieee->pHTInfo) {
 		IEEE80211_DEBUG(IEEE80211_DL_ERR, "can't alloc memory for HTInfo\n");
 		goto failed;
 	}
-- 
2.19.0


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 07/11] staging:rtl8192u: Correct code indentation - Style
  2018-10-07 21:40 [PATCH 00/11] staging:rtl8192u: Coding Style changes John Whitmore
                   ` (5 preceding siblings ...)
  2018-10-07 21:40 ` [PATCH 06/11] staging:rtl8192u: Rewrite test for null " John Whitmore
@ 2018-10-07 21:40 ` John Whitmore
  2018-10-07 21:40 ` [PATCH 08/11] staging:rtl8192u: Add missing blank lines " John Whitmore
                   ` (3 subsequent siblings)
  10 siblings, 0 replies; 14+ messages in thread
From: John Whitmore @ 2018-10-07 21:40 UTC (permalink / raw)
  To: linux-kernel; +Cc: devel, gregkh, John Whitmore

Rewrite code block to correct the indentation of code. This clears the
resulting checkpatch issue.

This is a coding style change which should not impact runtime code
execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
---
 drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
index 9bbacec52e1f..c31db21f7e63 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
@@ -167,9 +167,9 @@ struct net_device *alloc_ieee80211(int sizeof_priv)
 		INIT_LIST_HEAD(&ieee->ibss_mac_hash[i]);
 
 	for (i = 0; i < 17; i++) {
-	  ieee->last_rxseq_num[i] = -1;
-	  ieee->last_rxfrag_num[i] = -1;
-	  ieee->last_packet_time[i] = 0;
+		ieee->last_rxseq_num[i] = -1;
+		ieee->last_rxfrag_num[i] = -1;
+		ieee->last_packet_time[i] = 0;
 	}
 
 /* These function were added to load crypte module autoly */
-- 
2.19.0


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 08/11] staging:rtl8192u: Add missing blank lines - Style
  2018-10-07 21:40 [PATCH 00/11] staging:rtl8192u: Coding Style changes John Whitmore
                   ` (6 preceding siblings ...)
  2018-10-07 21:40 ` [PATCH 07/11] staging:rtl8192u: Correct code indentation " John Whitmore
@ 2018-10-07 21:40 ` John Whitmore
  2018-10-07 21:40 ` [PATCH 09/11] staging:rtl8192u: Remove unnecessary line continuation " John Whitmore
                   ` (2 subsequent siblings)
  10 siblings, 0 replies; 14+ messages in thread
From: John Whitmore @ 2018-10-07 21:40 UTC (permalink / raw)
  To: linux-kernel; +Cc: devel, gregkh, John Whitmore

Add missing blank lines after declarations. This clears the resulting
checkpatch issue.

This is a simple coding style change which should not impact runtime
code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
---
 drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
index c31db21f7e63..f134cd5a9829 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
@@ -199,6 +199,7 @@ void free_ieee80211(struct net_device *dev)
 
 	for (i = 0; i < WEP_KEYS; i++) {
 		struct ieee80211_crypt_data *crypt = ieee->crypt[i];
+
 		if (crypt) {
 			if (crypt->ops)
 				crypt->ops->deinit(crypt->priv);
@@ -248,6 +249,7 @@ static ssize_t write_debug_level(struct file *file, const char __user *buffer,
 {
 	unsigned long val;
 	int err = kstrtoul_from_user(buffer, count, 0, &val);
+
 	if (err)
 		return err;
 	ieee80211_debug_level = val;
-- 
2.19.0


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 09/11] staging:rtl8192u: Remove unnecessary line continuation - Style
  2018-10-07 21:40 [PATCH 00/11] staging:rtl8192u: Coding Style changes John Whitmore
                   ` (7 preceding siblings ...)
  2018-10-07 21:40 ` [PATCH 08/11] staging:rtl8192u: Add missing blank lines " John Whitmore
@ 2018-10-07 21:40 ` John Whitmore
  2018-10-07 21:40 ` [PATCH 10/11] staging:rtl8192u: Correct code alignment " John Whitmore
  2018-10-07 21:40 ` [PATCH 11/11] staging:rtl8192u: Correct comparison with NULL " John Whitmore
  10 siblings, 0 replies; 14+ messages in thread
From: John Whitmore @ 2018-10-07 21:40 UTC (permalink / raw)
  To: linux-kernel; +Cc: devel, gregkh, John Whitmore

Remove the unnecessary line continuation character to clear checkpatch
issue.

This is a simple coding style change which should not impact runtime
code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
---
 drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
index f134cd5a9829..1b0f45f1bb84 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
@@ -215,8 +215,7 @@ void free_ieee80211(struct net_device *dev)
 #ifdef CONFIG_IEEE80211_DEBUG
 
 u32 ieee80211_debug_level;
-static int debug = \
-	//		    IEEE80211_DL_INFO	|
+static int debug = //	    IEEE80211_DL_INFO	|
 	//		    IEEE80211_DL_WX	|
 	//		    IEEE80211_DL_SCAN	|
 	//		    IEEE80211_DL_STATE	|
-- 
2.19.0


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 10/11] staging:rtl8192u: Correct code alignment - Style
  2018-10-07 21:40 [PATCH 00/11] staging:rtl8192u: Coding Style changes John Whitmore
                   ` (8 preceding siblings ...)
  2018-10-07 21:40 ` [PATCH 09/11] staging:rtl8192u: Remove unnecessary line continuation " John Whitmore
@ 2018-10-07 21:40 ` John Whitmore
  2018-10-07 21:40 ` [PATCH 11/11] staging:rtl8192u: Correct comparison with NULL " John Whitmore
  10 siblings, 0 replies; 14+ messages in thread
From: John Whitmore @ 2018-10-07 21:40 UTC (permalink / raw)
  To: linux-kernel; +Cc: devel, gregkh, John Whitmore

Correct the alignment of a function, this clears checkpatch issue.

This is a simple coding style change which should not impact runtime
code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
---
 drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
index 1b0f45f1bb84..5dc780119eff 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
@@ -244,7 +244,7 @@ static int show_debug_level(struct seq_file *m, void *v)
 }
 
 static ssize_t write_debug_level(struct file *file, const char __user *buffer,
-			     size_t count, loff_t *ppos)
+				 size_t count, loff_t *ppos)
 {
 	unsigned long val;
 	int err = kstrtoul_from_user(buffer, count, 0, &val);
-- 
2.19.0


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 11/11] staging:rtl8192u: Correct comparison with NULL - Style
  2018-10-07 21:40 [PATCH 00/11] staging:rtl8192u: Coding Style changes John Whitmore
                   ` (9 preceding siblings ...)
  2018-10-07 21:40 ` [PATCH 10/11] staging:rtl8192u: Correct code alignment " John Whitmore
@ 2018-10-07 21:40 ` John Whitmore
  10 siblings, 0 replies; 14+ messages in thread
From: John Whitmore @ 2018-10-07 21:40 UTC (permalink / raw)
  To: linux-kernel; +Cc: devel, gregkh, John Whitmore

Correct code to remote comparison with NULL, this clears the resulting
checkpatch issue.

This is a coding style change which should not impact runtime code
execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
---
 drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
index 5dc780119eff..57127d2a462a 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
@@ -275,7 +275,7 @@ int __init ieee80211_debug_init(void)
 	ieee80211_debug_level = debug;
 
 	ieee80211_proc = proc_mkdir(DRV_NAME, init_net.proc_net);
-	if (ieee80211_proc == NULL) {
+	if (!ieee80211_proc) {
 		IEEE80211_ERROR("Unable to create " DRV_NAME
 				" proc directory\n");
 		return -EIO;
-- 
2.19.0


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* Re: [PATCH 02/11] staging:rtl8192u: Removed commented out include - Style
  2018-10-07 21:40 ` [PATCH 02/11] staging:rtl8192u: Removed commented out include " John Whitmore
@ 2018-10-09 13:25   ` Greg KH
  0 siblings, 0 replies; 14+ messages in thread
From: Greg KH @ 2018-10-09 13:25 UTC (permalink / raw)
  To: John Whitmore; +Cc: linux-kernel, devel

On Sun, Oct 07, 2018 at 10:40:16PM +0100, John Whitmore wrote:
> Remove commented out #include directive.
> 
> Additionally shorted a block comment to clear the checkpatch issue
> with line length.

You really should only do one type of thing per patch, but I'll let this
one go...


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 06/11] staging:rtl8192u: Rewrite test for null - Style
  2018-10-07 21:40 ` [PATCH 06/11] staging:rtl8192u: Rewrite test for null " John Whitmore
@ 2018-10-09 13:26   ` Greg KH
  0 siblings, 0 replies; 14+ messages in thread
From: Greg KH @ 2018-10-09 13:26 UTC (permalink / raw)
  To: John Whitmore; +Cc: linux-kernel, devel

On Sun, Oct 07, 2018 at 10:40:20PM +0100, John Whitmore wrote:
> Rewrite a test for NULL to comply with the coding style and clear the
> checkpatch issue.
> 
> This is a coding style change which should not impact runtime
> code execution.
> 
> Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
> ---
>  drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This patch did not apply :(


^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2018-10-09 13:26 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-07 21:40 [PATCH 00/11] staging:rtl8192u: Coding Style changes John Whitmore
2018-10-07 21:40 ` [PATCH 01/11] staging:rtl8192u: Add missing SPDX-License-Identifier - Style John Whitmore
2018-10-07 21:40 ` [PATCH 02/11] staging:rtl8192u: Removed commented out include " John Whitmore
2018-10-09 13:25   ` Greg KH
2018-10-07 21:40 ` [PATCH 03/11] staging:rtl8192u: Clear error with line ending ( " John Whitmore
2018-10-07 21:40 ` [PATCH 04/11] staging:rtl8192u: Remove extra blank lines " John Whitmore
2018-10-07 21:40 ` [PATCH 05/11] staging:rtl8192u: Add spaces around + operator " John Whitmore
2018-10-07 21:40 ` [PATCH 06/11] staging:rtl8192u: Rewrite test for null " John Whitmore
2018-10-09 13:26   ` Greg KH
2018-10-07 21:40 ` [PATCH 07/11] staging:rtl8192u: Correct code indentation " John Whitmore
2018-10-07 21:40 ` [PATCH 08/11] staging:rtl8192u: Add missing blank lines " John Whitmore
2018-10-07 21:40 ` [PATCH 09/11] staging:rtl8192u: Remove unnecessary line continuation " John Whitmore
2018-10-07 21:40 ` [PATCH 10/11] staging:rtl8192u: Correct code alignment " John Whitmore
2018-10-07 21:40 ` [PATCH 11/11] staging:rtl8192u: Correct comparison with NULL " John Whitmore

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).